Commit 97c70cb3 authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Avoid unnecessary UpdateUI for cookie controls

The UI would get updated twice when cookie blocking was enabled for
a specific site. Avoid this unnecessary step by not stepping through
state updates separately.

Bug: 967668
Change-Id: I9d6c836031dc9ef7adf1a4888b6e8c8483c22ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862693
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705951}
parent 2194e689
...@@ -61,7 +61,8 @@ void CookieControlsBubbleView::OnStatusChanged( ...@@ -61,7 +61,8 @@ void CookieControlsBubbleView::OnStatusChanged(
OnBlockedCookiesCountChanged(blocked_cookies); OnBlockedCookiesCountChanged(blocked_cookies);
return; return;
} }
intermediate_step_ = IntermediateStep::kNone; if (new_status != CookieControlsController::Status::kEnabled)
intermediate_step_ = IntermediateStep::kNone;
status_ = new_status; status_ = new_status;
blocked_cookies_ = blocked_cookies; blocked_cookies_ = blocked_cookies;
UpdateUi(); UpdateUi();
...@@ -268,9 +269,8 @@ bool CookieControlsBubbleView::Accept() { ...@@ -268,9 +269,8 @@ bool CookieControlsBubbleView::Accept() {
} else { } else {
DCHECK_EQ(status_, CookieControlsController::Status::kDisabledForSite); DCHECK_EQ(status_, CookieControlsController::Status::kDisabledForSite);
DCHECK_EQ(intermediate_step_, IntermediateStep::kNone); DCHECK_EQ(intermediate_step_, IntermediateStep::kNone);
controller_->OnCookieBlockingEnabledForSite(true);
intermediate_step_ = IntermediateStep::kBlockingIsOn; intermediate_step_ = IntermediateStep::kBlockingIsOn;
UpdateUi(); controller_->OnCookieBlockingEnabledForSite(true);
} }
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment