Commit 982eb07d authored by mgiuca@chromium.org's avatar mgiuca@chromium.org

AppListViewDelegate: Moved TODO to the correct line.

BUG=399131
NOTRY=true

Review URL: https://codereview.chromium.org/492643002

Cr-Commit-Position: refs/heads/master@{#290781}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290781 0039d316-1c4b-4281-b951-d872f2087c98
parent f2ad0afe
......@@ -121,8 +121,6 @@ void GetCustomLauncherPageUrls(content::BrowserContext* browser_context,
if (custom_launcher_page_url.SchemeIs(extensions::kExtensionScheme)) {
urls->push_back(custom_launcher_page_url);
} else {
// TODO(mgiuca): Add a proper manifest parser to catch this error properly
// and display it on the extensions page.
LOG(ERROR) << "Invalid custom launcher page URL: "
<< custom_launcher_page_url.possibly_invalid_spec();
}
......@@ -143,6 +141,8 @@ void GetCustomLauncherPageUrls(content::BrowserContext* browser_context,
std::string launcher_page_page;
if (!manifest->GetString(extensions::manifest_keys::kLauncherPagePage,
&launcher_page_page)) {
// TODO(mgiuca): Add a proper manifest parser to catch this error properly
// and display it on the extensions page.
LOG(ERROR) << "Extension " << extension->id() << ": "
<< extensions::manifest_keys::kLauncherPage
<< " has no 'page' attribute; will be ignored.";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment