Commit 9840dd70 authored by rafaelw@chromium.org's avatar rafaelw@chromium.org

Move extension install to after .crx download completes

This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager.

BUG=15881
R=mpcomplete

Review URL: http://codereview.chromium.org/149161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20083 0039d316-1c4b-4281-b951-d872f2087c98
parent e0749fdd
...@@ -820,8 +820,6 @@ void DownloadManager::DownloadFinished(int32 download_id, int64 size) { ...@@ -820,8 +820,6 @@ void DownloadManager::DownloadFinished(int32 download_id, int64 size) {
void DownloadManager::DownloadRenamedToFinalName(int download_id, void DownloadManager::DownloadRenamedToFinalName(int download_id,
const FilePath& full_path) { const FilePath& full_path) {
if (Extension::IsExtension(full_path))
OpenChromeExtension(full_path);
} }
void DownloadManager::ContinueDownloadFinished(DownloadItem* download) { void DownloadManager::ContinueDownloadFinished(DownloadItem* download) {
...@@ -840,8 +838,7 @@ void DownloadManager::ContinueDownloadFinished(DownloadItem* download) { ...@@ -840,8 +838,7 @@ void DownloadManager::ContinueDownloadFinished(DownloadItem* download) {
// Handle chrome extensions explicitly and skip the shell execute. // Handle chrome extensions explicitly and skip the shell execute.
if (Extension::IsExtension(download->full_path())) { if (Extension::IsExtension(download->full_path())) {
// Skip the shell execute. This will be handled in OpenChromeExtension(download->full_path());
// DownloadRenamedToFinalName
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment