Commit 984619dd authored by isherman@chromium.org's avatar isherman@chromium.org

[rAc OSX] Ensure that the "Save in Chrome?" tooltip is only visible when the checkbox is.

BUG=314959
TEST=unit_tests
R=groby@chromium.org

Review URL: https://codereview.chromium.org/58913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233395 0039d316-1c4b-4281-b951-d872f2087c98
parent 66382a92
...@@ -62,7 +62,6 @@ ...@@ -62,7 +62,6 @@
[saveInChromeCheckbox_ setButtonType:NSSwitchButton]; [saveInChromeCheckbox_ setButtonType:NSSwitchButton];
[saveInChromeCheckbox_ setTitle: [saveInChromeCheckbox_ setTitle:
base::SysUTF16ToNSString(delegate_->SaveLocallyText())]; base::SysUTF16ToNSString(delegate_->SaveLocallyText())];
[self updateSaveInChrome];
[saveInChromeCheckbox_ sizeToFit]; [saveInChromeCheckbox_ sizeToFit];
[[self view] addSubview:saveInChromeCheckbox_]; [[self view] addSubview:saveInChromeCheckbox_];
...@@ -74,6 +73,7 @@ ...@@ -74,6 +73,7 @@
base::SysUTF16ToNSString(delegate_->SaveLocallyTooltip())]; base::SysUTF16ToNSString(delegate_->SaveLocallyTooltip())];
[saveInChromeTooltip_ setFrameSize:[[saveInChromeTooltip_ image] size]]; [saveInChromeTooltip_ setFrameSize:[[saveInChromeTooltip_ image] size]];
[[self view] addSubview:saveInChromeTooltip_]; [[self view] addSubview:saveInChromeTooltip_];
[self updateSaveInChrome];
detailsContainer_.reset( detailsContainer_.reset(
[[AutofillDetailsContainer alloc] initWithDelegate:delegate_]); [[AutofillDetailsContainer alloc] initWithDelegate:delegate_]);
......
...@@ -111,9 +111,13 @@ TEST_F(AutofillMainContainerTest, SaveInChromeCheckboxVisibility) { ...@@ -111,9 +111,13 @@ TEST_F(AutofillMainContainerTest, SaveInChromeCheckboxVisibility) {
RebuildView(); RebuildView();
NSButton* checkbox = [container_ saveInChromeCheckboxForTesting]; NSButton* checkbox = [container_ saveInChromeCheckboxForTesting];
NSImageView* tooltip = [container_ saveInChromeTooltipForTesting];
ASSERT_TRUE(checkbox); ASSERT_TRUE(checkbox);
ASSERT_TRUE(tooltip);
EXPECT_TRUE([checkbox isHidden]); EXPECT_TRUE([checkbox isHidden]);
EXPECT_TRUE([tooltip isHidden]);
[container_ modelChanged]; [container_ modelChanged];
EXPECT_FALSE([checkbox isHidden]); EXPECT_FALSE([checkbox isHidden]);
EXPECT_FALSE([tooltip isHidden]);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment