Commit 984dcbf9 authored by zhaoyangli's avatar zhaoyangli Committed by Commit Bot

Toggle flag to make automation_egtest record exception in -setUp()

Current autofill automation framework attempts 5 times for a test to
deal with flaky issue. To achieve this, XCTestCase's
recordFailureWithDescription:inFile:atLine:expected: method is disabled
before 5th attempt with a flag. The flag is false by default and this
makes assertion failure won't fail the test during -setUp() period.
This change toggle the flag to true before -setUp() so assertions will
work as expected in -setUp().

Bug: 1006452
Change-Id: I6d902e23e7d74dcac9f3ee279a1bd65c00f468db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817296Reviewed-by: default avatarEric Noyau <noyau@chromium.org>
Reviewed-by: default avatarYun Liu <yliuyliu@google.com>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702092}
parent 8b2fe62f
......@@ -196,6 +196,8 @@ static const int kRecipeRetryLimit = 5;
}
- (void)setUp {
self->shouldRecordException = true;
[super setUp];
const base::FilePath recipePath = [[self class] recipePath];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment