Commit 986ee1a7 authored by gab@chromium.org's avatar gab@chromium.org

Fix metrics-reporting-enabled date expectations post metrics IDs reset.

BUG=400561
TEST=Add a Sleep(1000) before this section of the test: fails before this CL, succeeds now.

Review URL: https://codereview.chromium.org/442853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287632 0039d316-1c4b-4281-b951-d872f2087c98
parent 20d10077
...@@ -220,6 +220,8 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) { ...@@ -220,6 +220,8 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) {
const int64 kFakeInstallationDate = 12345; const int64 kFakeInstallationDate = 12345;
prefs_.SetInt64(prefs::kInstallDate, kFakeInstallationDate); prefs_.SetInt64(prefs::kInstallDate, kFakeInstallationDate);
const int64 test_begin_time = base::Time::Now().ToTimeT();
// Holds ClientInfo from previous scoped test for extra checks. // Holds ClientInfo from previous scoped test for extra checks.
scoped_ptr<ClientInfo> previous_client_info; scoped_ptr<ClientInfo> previous_client_info;
...@@ -236,7 +238,8 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) { ...@@ -236,7 +238,8 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) {
EXPECT_FALSE(stored_client_info_backup_); EXPECT_FALSE(stored_client_info_backup_);
state_manager->ForceClientIdCreation(); state_manager->ForceClientIdCreation();
EXPECT_NE(std::string(), state_manager->client_id()); EXPECT_NE(std::string(), state_manager->client_id());
EXPECT_GT(prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp), 0); EXPECT_GE(prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp),
test_begin_time);
ASSERT_TRUE(stored_client_info_backup_); ASSERT_TRUE(stored_client_info_backup_);
EXPECT_EQ(state_manager->client_id(), EXPECT_EQ(state_manager->client_id(),
...@@ -341,8 +344,9 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) { ...@@ -341,8 +344,9 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) {
scoped_ptr<MetricsStateManager> state_manager(CreateStateManager()); scoped_ptr<MetricsStateManager> state_manager(CreateStateManager());
EXPECT_EQ(kBackupClientId, state_manager->client_id()); EXPECT_EQ(kBackupClientId, state_manager->client_id());
EXPECT_GT(prefs_.GetInt64(prefs::kInstallDate), 0); EXPECT_GE(prefs_.GetInt64(prefs::kInstallDate), test_begin_time);
EXPECT_GT(prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp), 0); EXPECT_GE(prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp),
test_begin_time);
EXPECT_TRUE(stored_client_info_backup_); EXPECT_TRUE(stored_client_info_backup_);
previous_client_info = stored_client_info_backup_.Pass(); previous_client_info = stored_client_info_backup_.Pass();
...@@ -362,11 +366,13 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) { ...@@ -362,11 +366,13 @@ TEST_F(MetricsStateManagerTest, ForceClientIdCreation) {
EXPECT_NE(std::string(), state_manager->client_id()); EXPECT_NE(std::string(), state_manager->client_id());
EXPECT_NE(previous_client_info->client_id, state_manager->client_id()); EXPECT_NE(previous_client_info->client_id, state_manager->client_id());
// Dates should not have been affected. // The installation date should not have been affected.
EXPECT_EQ(previous_client_info->installation_date, EXPECT_EQ(previous_client_info->installation_date,
prefs_.GetInt64(prefs::kInstallDate)); prefs_.GetInt64(prefs::kInstallDate));
EXPECT_EQ(previous_client_info->reporting_enabled_date,
prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp)); // The metrics-reporting-enabled date will be reset to Now().
EXPECT_GE(prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp),
previous_client_info->reporting_enabled_date);
stored_client_info_backup_.reset(); stored_client_info_backup_.reset();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment