Remove SigninManager::DiagnosticsClient

It's no longer used after
https://chromium-review.googlesource.com/c/chromium/src/+/1224790.

Bug: 883722
Change-Id: Ie55a7941fca82f6558cd2f2ecf0a65f2b345b701
Reviewed-on: https://chromium-review.googlesource.com/1224792Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592357}

components/signin/core/browser/signin_manager.cc

@@ -40,7 +40,6 @@ SigninManager::SigninManager(
       prohibit_signout_(false),
       type_(SIGNIN_TYPE_NONE),
       client_(client),
-      diagnostics_client_(nullptr),
       token_service_(token_service),
       cookie_manager_service_(cookie_manager_service),
       account_consistency_(account_consistency),
@@ -459,11 +458,6 @@ void SigninManager::OnSignedIn() {
 }
 
 void SigninManager::FireGoogleSigninSucceeded() {
-  if (diagnostics_client_) {
-    diagnostics_client_->WillFireGoogleSigninSucceeded(
-        GetAuthenticatedAccountInfo());
-  }
-
   std::string account_id = GetAuthenticatedAccountId();
   std::string email = GetAuthenticatedAccountInfo().email;
   for (auto& observer : observer_list_) {
@@ -475,10 +469,6 @@ void SigninManager::FireGoogleSigninSucceeded() {
 
 void SigninManager::FireGoogleSignedOut(const std::string& account_id,
                                         const AccountInfo& account_info) {
-  if (diagnostics_client_) {
-    diagnostics_client_->WillFireGoogleSignedOut(account_info);
-  }
-
   for (auto& observer : observer_list_) {
     observer.GoogleSignedOut(account_id, account_info.email);
     observer.GoogleSignedOut(account_info);

components/signin/core/browser/signin_manager.h

@@ -203,23 +203,6 @@ class SigninManager : public SigninManagerBase,
                          RemoveAccountsOption remove_option);
 
  private:
-  // Interface that gives information on internal SigninManager operations. Only
-  // for use by IdentityManager during the conversion of the codebase to use
-  // //services/identity/public/cpp.
-  class DiagnosticsClient {
-   public:
-    // Sent just before GoogleSigninSucceeded() is fired on observers.
-    virtual void WillFireGoogleSigninSucceeded(
-        const AccountInfo& account_info) = 0;
-    // Sent just before GoogleSignedOut() is fired on observers.
-    virtual void WillFireGoogleSignedOut(const AccountInfo& account_info) = 0;
-  };
-
-  void set_diagnostics_client(DiagnosticsClient* diagnostics_client) {
-    DCHECK(!diagnostics_client_ || !diagnostics_client);
-    diagnostics_client_ = diagnostics_client;
-  }
-
   enum SigninType {
     SIGNIN_TYPE_NONE,
     SIGNIN_TYPE_WITH_REFRESH_TOKEN,
@@ -305,9 +288,6 @@ class SigninManager : public SigninManagerBase,
   // object.
   SigninClient* client_;
 
-  // The DiagnosticsClient object associated with this object. May be null.
-  DiagnosticsClient* diagnostics_client_;
-
   // The ProfileOAuth2TokenService instance associated with this object. Must
   // outlive this object.
   ProfileOAuth2TokenService* token_service_;