[Android] Don't subclass ChromeActivityTestRule in SyncTestRule

Removes subclassing of ChromeActivityTestRule in SyncTestRule. This
subclassing meant that every test using SyncTestRule would start
ChromeActivity before starting the test. This was producing several
issues:
1. It's hard and confusing to use SyncTestRule in tests that start
  other activity types: FRE tests, bookmark tests, settings tests.
2. It makes tests longer.
3. It might make tests flaky.

Some tests need ChromeActivity to be started, so this CL adds a bunch of
explicit ChromeTabbedActivityTestRule fields along with calls to
startMainActivityOnBlankPage.

This CL also fixes and cleans up FirstRunTest. Tests will be enabled in
a separate CL (in case they're still flaky).

Bug: 616456, 1135990
Change-Id: I5a3d4a27f051cdfc4df2d4dc12a27899084b91db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450291
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818891}

chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/PasswordGenerationIntegrationTest.java

@@ -33,6 +33,7 @@ import org.chromium.chrome.browser.flags.ChromeSwitches;
 import org.chromium.chrome.browser.infobar.InfoBarContainer;
 import org.chromium.chrome.browser.sync.SyncTestRule;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.components.browser_ui.modaldialog.AppModalPresenter;
 import org.chromium.content_public.browser.test.util.CriteriaHelper;
 import org.chromium.content_public.browser.test.util.DOMUtils;
@@ -52,6 +53,10 @@ public class PasswordGenerationIntegrationTest {
     @Rule
     public SyncTestRule mSyncTestRule = new SyncTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     private static final String PASSWORD_NODE_ID = "password_field";
     private static final String PASSWORD_NODE_ID_MANUAL = "password_field_manual";
     private static final String SUBMIT_NODE_ID = "input_submit_button";
@@ -62,7 +67,7 @@ public class PasswordGenerationIntegrationTest {
     private static final String ELIGIBLE_FOR_GENERATION = "1";
     private static final String INFOBAR_MESSAGE = "Password saved";
 
-    private final ManualFillingTestHelper mHelper = new ManualFillingTestHelper(mSyncTestRule);
+    private final ManualFillingTestHelper mHelper = new ManualFillingTestHelper(mActivityTestRule);
 
     @Before
     public void setUp() throws InterruptedException {
@@ -191,7 +196,7 @@ public class PasswordGenerationIntegrationTest {
     private void waitForGenerationDialog() {
         waitForModalDialogPresenter();
         ModalDialogManager manager = TestThreadUtils.runOnUiThreadBlockingNoException(
-                mSyncTestRule.getActivity()::getModalDialogManager);
+                mActivityTestRule.getActivity()::getModalDialogManager);
         Window window = ((AppModalPresenter) manager.getCurrentPresenterForTest()).getWindow();
         mHelper.waitForViewOnRoot(
                 window.getDecorView().getRootView(), withId(password_generation_dialog));
@@ -199,7 +204,7 @@ public class PasswordGenerationIntegrationTest {
 
     private void waitForModalDialogPresenter() {
         CriteriaHelper.pollUiThread(()
-                                            -> mSyncTestRule.getActivity()
+                                            -> mActivityTestRule.getActivity()
                                                        .getModalDialogManager()
                                                        .getCurrentPresenterForTest()
                         != null);
@@ -207,8 +212,9 @@ public class PasswordGenerationIntegrationTest {
 
     private void assertNoInfobarsAreShown() {
         TestThreadUtils.runOnUiThreadBlocking(() -> {
-            Assert.assertFalse(InfoBarContainer.from(mSyncTestRule.getActivity().getActivityTab())
-                                       .hasInfoBars());
+            Assert.assertFalse(
+                    InfoBarContainer.from(mActivityTestRule.getActivity().getActivityTab())
+                            .hasInfoBars());
         });
     }
 

chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkPersonalizedSigninPromoDismissTest.java

@@ -32,6 +32,7 @@ import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.signin.SigninPromoController;
 import org.chromium.chrome.browser.sync.SyncTestRule;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.BookmarkTestRule;
 import org.chromium.chrome.test.util.BookmarkTestUtil;
 import org.chromium.chrome.test.util.ChromeTabUtils;
@@ -47,6 +48,10 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
 
     private final BookmarkTestRule mBookmarkTestRule = new BookmarkTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     // As bookmarks need the fake AccountManagerFacade in SyncTestRule,
     // BookmarkTestRule should be initialized after and destroyed before the
     // SyncTestRule.
@@ -59,9 +64,10 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
         BookmarkPromoHeader.setPrefPersonalizedSigninPromoDeclinedForTests(false);
         SigninPromoController.setSigninPromoImpressionsCountBookmarksForTests(0);
 
+        mActivityTestRule.startMainActivityOnBlankPage();
         TestThreadUtils.runOnUiThreadBlocking(() -> {
             BookmarkModel bookmarkModel = new BookmarkModel(Profile.fromWebContents(
-                    mSyncTestRule.getActivity().getActivityTab().getWebContents()));
+                    mActivityTestRule.getActivity().getActivityTab().getWebContents()));
             bookmarkModel.loadFakePartnerBookmarkShimForTesting();
         });
         BookmarkTestUtil.waitForBookmarkModelLoaded();
@@ -76,20 +82,20 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
     @Test
     @MediumTest
     public void testPromoNotShownAfterBeingDismissed() {
-        mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
+        mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
         onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
         onView(withId(R.id.signin_promo_close_button)).perform(click());
         onView(withId(R.id.signin_promo_view_container)).check(doesNotExist());
 
         closeBookmarkManager();
-        mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
+        mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
         onView(withId(R.id.signin_promo_view_container)).check(doesNotExist());
     }
 
     private void closeBookmarkManager() {
-        if (mSyncTestRule.getActivity().isTablet()) {
+        if (mActivityTestRule.getActivity().isTablet()) {
             ChromeTabbedActivity chromeTabbedActivity =
-                    (ChromeTabbedActivity) mSyncTestRule.getActivity();
+                    (ChromeTabbedActivity) mActivityTestRule.getActivity();
             ChromeTabUtils.closeCurrentTab(
                     InstrumentationRegistry.getInstrumentation(), chromeTabbedActivity);
         } else {
@@ -102,7 +108,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
     public void testPromoNotExistWhenImpressionLimitReached() {
         SigninPromoController.setSigninPromoImpressionsCountBookmarksForTests(
                 SigninPromoController.getMaxImpressionsBookmarksForTests());
-        mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
+        mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
         onView(withId(R.id.signin_promo_view_container)).check(doesNotExist());
     }
 
@@ -110,7 +116,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
     @MediumTest
     public void testPromoImpressionCountIncrementAfterDisplayingSigninPromo() {
         assertEquals(0, SigninPromoController.getSigninPromoImpressionsCountBookmarks());
-        mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
+        mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
         onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
         assertEquals(1, SigninPromoController.getSigninPromoImpressionsCountBookmarks());
     }

chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkPersonalizedSigninPromoTest.java

@@ -37,6 +37,7 @@ import org.chromium.chrome.browser.flags.ChromeSwitches;
 import org.chromium.chrome.browser.signin.SigninActivityLauncherImpl;
 import org.chromium.chrome.browser.sync.SyncTestRule;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.BookmarkTestRule;
 import org.chromium.components.signin.metrics.SigninAccessPoint;
 
@@ -50,6 +51,10 @@ public class BookmarkPersonalizedSigninPromoTest {
 
     private final BookmarkTestRule mBookmarkTestRule = new BookmarkTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     // As bookmarks need the fake AccountManagerFacade in SyncTestRule,
     // BookmarkTestRule should be initialized after and destroyed before the
     // SyncTestRule.
@@ -64,6 +69,7 @@ public class BookmarkPersonalizedSigninPromoTest {
         BookmarkPromoHeader.forcePromoStateForTests(
                 BookmarkPromoHeader.PromoState.PROMO_SIGNIN_PERSONALIZED);
         SigninActivityLauncherImpl.setLauncherForTest(mMockSigninActivityLauncherImpl);
+        mActivityTestRule.startMainActivityOnBlankPage();
     }
 
     @After
@@ -114,7 +120,7 @@ public class BookmarkPersonalizedSigninPromoTest {
     }
 
     private void showBookmarkManagerAndCheckSigninPromoIsDisplayed() {
-        mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
+        mBookmarkTestRule.showBookmarkManager(mActivityTestRule.getActivity());
         onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
     }
 }

chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SyncErrorInfoBarTest.java

@@ -22,6 +22,7 @@ import org.chromium.chrome.browser.sync.SyncTestRule;
 import org.chromium.chrome.browser.sync.settings.SyncSettingsUtils;
 import org.chromium.chrome.browser.sync.settings.SyncSettingsUtils.SyncError;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.ChromeRenderTestRule;
 import org.chromium.chrome.test.util.InfoBarUtil;
 import org.chromium.chrome.test.util.browser.sync.SyncTestUtil;
@@ -48,6 +49,10 @@ import java.io.IOException;
         }
     };
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     @Rule
     public final ChromeRenderTestRule mRenderTestRule =
             ChromeRenderTestRule.Builder.withPublicCorpus().build();
@@ -56,58 +61,58 @@ import java.io.IOException;
     public void setUp() {
         deleteSyncErrorInfoBarShowTimePref();
         mFakeProfileSyncService = (FakeProfileSyncService) mSyncTestRule.getProfileSyncService();
-        mSyncTestRule.startMainActivityOnBlankPage();
+        mActivityTestRule.startMainActivityOnBlankPage();
     }
 
     @Test
     @LargeTest
     public void testSyncErrorInfoBarShownForAuthError() throws Exception {
         Assert.assertEquals("InfoBar should not be shown before signing in", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
         showSyncErrorInfoBarForAuthError();
-        Assert.assertEquals("InfoBar should be shown", 1, mSyncTestRule.getInfoBars().size());
+        Assert.assertEquals("InfoBar should be shown", 1, mActivityTestRule.getInfoBars().size());
 
         // Resolving the error should not show the infobar again.
         deleteSyncErrorInfoBarShowTimePref();
         mFakeProfileSyncService.setAuthError(GoogleServiceAuthError.State.NONE);
-        InfoBarUtil.waitUntilNoInfoBarsExist(mSyncTestRule.getInfoBars());
+        InfoBarUtil.waitUntilNoInfoBarsExist(mActivityTestRule.getInfoBars());
     }
 
     @Test
     @LargeTest
     public void testSyncErrorInfoBarShownForSyncSetupIncomplete() {
         Assert.assertEquals("InfoBar should not be shown before signing in", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
         showSyncErrorInfoBarForSyncSetupIncomplete();
-        Assert.assertEquals("InfoBar should be shown", 1, mSyncTestRule.getInfoBars().size());
+        Assert.assertEquals("InfoBar should be shown", 1, mActivityTestRule.getInfoBars().size());
 
         // Resolving the error should not show the infobar again.
         deleteSyncErrorInfoBarShowTimePref();
         TestThreadUtils.runOnUiThreadBlocking(() -> {
             mFakeProfileSyncService.setFirstSetupComplete(SyncFirstSetupCompleteSource.BASIC_FLOW);
         });
-        InfoBarUtil.waitUntilNoInfoBarsExist(mSyncTestRule.getInfoBars());
+        InfoBarUtil.waitUntilNoInfoBarsExist(mActivityTestRule.getInfoBars());
     }
 
     @Test
     @LargeTest
     public void testSyncErrorInfoBarShownForPassphraseRequired() {
         Assert.assertEquals("InfoBar should not be shown before signing in", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
         showSyncErrorInfoBarForPassphraseRequired();
-        Assert.assertEquals("InfoBar should be shown", 1, mSyncTestRule.getInfoBars().size());
+        Assert.assertEquals("InfoBar should be shown", 1, mActivityTestRule.getInfoBars().size());
 
         // Resolving the error should not show the infobar again.
         deleteSyncErrorInfoBarShowTimePref();
         mFakeProfileSyncService.setPassphraseRequiredForPreferredDataTypes(false);
-        InfoBarUtil.waitUntilNoInfoBarsExist(mSyncTestRule.getInfoBars());
+        InfoBarUtil.waitUntilNoInfoBarsExist(mActivityTestRule.getInfoBars());
     }
 
     @Test
     @LargeTest
     public void testSyncErrorInfoBarNotShownWhenNoError() {
         Assert.assertEquals("InfoBar should not be shown before signing in", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
         mSyncTestRule.setUpAccountAndEnableSyncForTesting();
         SyncTestUtil.waitForSyncActive();
         mFakeProfileSyncService.setEngineInitialized(true);
@@ -125,7 +130,7 @@ import java.io.IOException;
         Assert.assertTrue(syncError != SyncError.SYNC_SETUP_INCOMPLETE);
 
         Assert.assertEquals("InfoBar should not be shown when there is no error", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
     }
 
     @Test
@@ -133,14 +138,14 @@ import java.io.IOException;
     public void testSyncErrorInfoBarIsNotShownBeforeMinimalIntervalPassed() {
         // Initiate auth error to show the infobar.
         Assert.assertEquals("InfoBar should not be shown before signing in", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
         showSyncErrorInfoBarForAuthError();
-        Assert.assertEquals("InfoBar should be shown", 1, mSyncTestRule.getInfoBars().size());
+        Assert.assertEquals("InfoBar should be shown", 1, mActivityTestRule.getInfoBars().size());
 
         // Create another new tab.
-        mSyncTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
+        mActivityTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
         Assert.assertEquals("InfoBar should not be shown again before minimum interval passed", 0,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
 
         // Override the time of last seen infobar to minimum required time before current time.
         ContextUtils.getAppSharedPreferences()
@@ -149,9 +154,9 @@ import java.io.IOException;
                         System.currentTimeMillis()
                                 - SyncErrorInfoBar.MINIMAL_DURATION_BETWEEN_INFOBARS_MS)
                 .apply();
-        mSyncTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
+        mActivityTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
         Assert.assertEquals("InfoBar should be shown again after minimum interval passed", 1,
-                mSyncTestRule.getInfoBars().size());
+                mActivityTestRule.getInfoBars().size());
     }
 
     @Test
@@ -159,7 +164,7 @@ import java.io.IOException;
     @Feature("RenderTest")
     public void testSyncErrorInfoBarForAuthErrorView() throws IOException {
         showSyncErrorInfoBarForAuthError();
-        mRenderTestRule.render(mSyncTestRule.getInfoBarContainer().getContainerViewForTesting(),
+        mRenderTestRule.render(mActivityTestRule.getInfoBarContainer().getContainerViewForTesting(),
                 "sync_error_infobar_auth_error");
     }
 
@@ -168,7 +173,7 @@ import java.io.IOException;
     @Feature("RenderTest")
     public void testSyncErrorInfoBarForSyncSetupIncompleteView() throws IOException {
         showSyncErrorInfoBarForSyncSetupIncomplete();
-        mRenderTestRule.render(mSyncTestRule.getInfoBarContainer().getContainerViewForTesting(),
+        mRenderTestRule.render(mActivityTestRule.getInfoBarContainer().getContainerViewForTesting(),
                 "sync_error_infobar_sync_setup_incomplete");
     }
 
@@ -177,26 +182,26 @@ import java.io.IOException;
     @Feature("RenderTest")
     public void testSyncErrorInfoBarForPassphraseRequiredView() throws IOException {
         showSyncErrorInfoBarForPassphraseRequired();
-        mRenderTestRule.render(mSyncTestRule.getInfoBarContainer().getContainerViewForTesting(),
+        mRenderTestRule.render(mActivityTestRule.getInfoBarContainer().getContainerViewForTesting(),
                 "sync_error_infobar_passphrase_required");
     }
 
     private void showSyncErrorInfoBarForAuthError() {
         mSyncTestRule.setUpAccountAndEnableSyncForTesting();
         mFakeProfileSyncService.setAuthError(GoogleServiceAuthError.State.INVALID_GAIA_CREDENTIALS);
-        mSyncTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
+        mActivityTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
     }
 
     private void showSyncErrorInfoBarForPassphraseRequired() {
         mSyncTestRule.setUpAccountAndEnableSyncForTesting();
         mFakeProfileSyncService.setEngineInitialized(true);
         mFakeProfileSyncService.setPassphraseRequiredForPreferredDataTypes(true);
-        mSyncTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
+        mActivityTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
     }
 
     private void showSyncErrorInfoBarForSyncSetupIncomplete() {
         mSyncTestRule.setUpTestAccountAndSignInWithSyncSetupAsIncomplete();
-        mSyncTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
+        mActivityTestRule.loadUrlInNewTab(UrlConstants.CHROME_BLANK_URL);
     }
 
     private void deleteSyncErrorInfoBarShowTimePref() {

chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninFragmentTest.java

@@ -28,6 +28,7 @@ import androidx.test.filters.MediumTest;
 import org.hamcrest.Matcher;
 import org.junit.After;
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -41,6 +42,7 @@ import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.sync.ProfileSyncService;
 import org.chromium.chrome.browser.sync.SyncTestRule;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.ActivityUtils;
 import org.chromium.chrome.test.util.ApplicationTestUtils;
 import org.chromium.chrome.test.util.ChromeRenderTestRule;
@@ -64,12 +66,21 @@ public class SigninFragmentTest {
     @Rule
     public final SyncTestRule mSyncTestRule = new SyncTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     @Rule
     public final ChromeRenderTestRule mRenderTestRule =
             ChromeRenderTestRule.Builder.withPublicCorpus().build();
 
     private SigninActivity mSigninActivity;
 
+    @Before
+    public void setUp() {
+        mActivityTestRule.startMainActivityOnBlankPage();
+    }
+
     @After
     public void tearDown() throws Exception {
         // Since SigninActivity is launched inside this test class, we need to
@@ -86,7 +97,7 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivityForPromoAddAccountFlow(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER);
+                            mActivityTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER);
                 });
         mRenderTestRule.render(mSigninActivity.findViewById(R.id.fragment_container),
                 "signin_fragment_new_account");
@@ -101,7 +112,7 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivityForPromoChooseAccountFlow(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
+                            mActivityTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
                             account.name);
                 });
         mRenderTestRule.render(mSigninActivity.findViewById(R.id.fragment_container),
@@ -118,7 +129,7 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivityForPromoChooseAccountFlow(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
+                            mActivityTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
                             secondAccountName);
                 });
         mRenderTestRule.render(mSigninActivity.findViewById(R.id.fragment_container),
@@ -133,7 +144,7 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivityForPromoDefaultFlow(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
+                            mActivityTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
                             account.name);
                 });
         mRenderTestRule.render(mSigninActivity.findViewById(R.id.fragment_container),
@@ -147,7 +158,8 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivityForPromoDefaultFlow(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.SETTINGS, account.name);
+                            mActivityTestRule.getActivity(), SigninAccessPoint.SETTINGS,
+                            account.name);
                 });
         onView(withText(account.name)).check(matches(isDisplayed()));
         onView(withId(R.id.signin_details_description)).perform(clickOnClickableSpan());
@@ -171,7 +183,7 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivity(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.SETTINGS);
+                            mActivityTestRule.getActivity(), SigninAccessPoint.SETTINGS);
                 });
         onView(withId(R.id.positive_button)).check(matches(withText(R.string.signin_add_account)));
         onView(withId(R.id.negative_button)).check(matches(withText(R.string.cancel)));
@@ -186,7 +198,7 @@ public class SigninFragmentTest {
         mSigninActivity = ActivityUtils.waitForActivity(
                 InstrumentationRegistry.getInstrumentation(), SigninActivity.class, () -> {
                     SigninActivityLauncherImpl.get().launchActivityForPromoDefaultFlow(
-                            mSyncTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
+                            mActivityTestRule.getActivity(), SigninAccessPoint.BOOKMARK_MANAGER,
                             defaultAccount.name);
                 });
         onView(withText(defaultAccount.name)).check(matches(isDisplayed())).perform(click());

chrome/android/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java

@@ -5,15 +5,13 @@
 package org.chromium.chrome.browser.sync;
 
 import android.accounts.Account;
-import android.app.Activity;
-import android.app.Instrumentation;
-import android.app.Instrumentation.ActivityMonitor;
+import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
 import android.support.test.InstrumentationRegistry;
 
-import androidx.test.filters.SmallTest;
+import androidx.test.filters.LargeTest;
 
 import org.junit.After;
 import org.junit.Assert;
@@ -26,14 +24,15 @@ import org.chromium.base.CommandLine;
 import org.chromium.base.test.util.CallbackHelper;
 import org.chromium.base.test.util.DisabledTest;
 import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.FlakyTest;
+import org.chromium.chrome.browser.SyncFirstSetupCompleteSource;
+import org.chromium.chrome.browser.document.ChromeLauncherActivity;
 import org.chromium.chrome.browser.firstrun.FirstRunActivity;
 import org.chromium.chrome.browser.firstrun.FirstRunActivity.FirstRunActivityObserver;
 import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;
 import org.chromium.chrome.browser.firstrun.FirstRunSignInProcessor;
 import org.chromium.chrome.browser.flags.ChromeSwitches;
 import org.chromium.chrome.browser.settings.SettingsActivity;
-import org.chromium.chrome.browser.sync.settings.AccountManagementFragment;
+import org.chromium.chrome.browser.sync.settings.SyncAndServicesSettings;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
 import org.chromium.chrome.test.util.ActivityUtils;
 import org.chromium.chrome.test.util.browser.sync.SyncTestUtil;
@@ -48,51 +47,7 @@ import java.util.concurrent.TimeoutException;
 @RunWith(ChromeJUnit4ClassRunner.class)
 public class FirstRunTest {
     @Rule
-    public SyncTestRule mSyncTestRule = new SyncTestRule() {
-        @Override
-        public void startMainActivityForSyncTest() {
-            FirstRunActivity.setObserverForTest(mTestObserver);
-
-            // Starts up and waits for the FirstRunActivity to be ready.
-            // This isn't exactly what startMainActivity is supposed to be doing, but short of a
-            // refactoring of SyncTestBase to use something other than ChromeTabbedActivity,
-            // it's the only way to reuse the rest of the setup and initialization code inside of
-            // it.
-            final Instrumentation instrumentation = InstrumentationRegistry.getInstrumentation();
-            final Context context = instrumentation.getTargetContext();
-
-            // Create an Intent that causes Chrome to run.
-            final Intent intent = new Intent(TEST_ACTION);
-            intent.setPackage(context.getPackageName());
-            intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
-
-            // Start the FRE.
-            final ActivityMonitor freMonitor =
-                    new ActivityMonitor(FirstRunActivity.class.getName(), null, false);
-            instrumentation.addMonitor(freMonitor);
-            TestThreadUtils.runOnUiThreadBlocking(() -> {
-                FirstRunFlowSequencer.launch(context, intent, false /* requiresBroadcast */,
-                        false /* preferLightweightFre */);
-            });
-
-            // Wait for the FRE to be ready to use.
-            Activity activity =
-                    freMonitor.waitForActivityWithTimeout(CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL);
-            instrumentation.removeMonitor(freMonitor);
-
-            mActivity = (FirstRunActivity) activity;
-
-            try {
-                mTestObserver.flowIsKnownCallback.waitForCallback(0);
-            } catch (TimeoutException e) {
-                Assert.fail();
-            }
-            CriteriaHelper.pollUiThread((() -> mActivity.isNativeSideIsInitializedForTest()),
-                    "native never initialized.");
-        }
-    };
-
-    private static final String TEST_ACTION = "com.artificial.package.TEST_ACTION";
+    public SyncTestRule mSyncTestRule = new SyncTestRule();
 
     private static final class TestObserver implements FirstRunActivityObserver {
         public final CallbackHelper flowIsKnownCallback = new CallbackHelper();
@@ -125,6 +80,29 @@ public class FirstRunTest {
     public void setUp() {
         Assert.assertFalse(
                 CommandLine.getInstance().hasSwitch(ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE));
+
+        FirstRunActivity.setObserverForTest(mTestObserver);
+
+        Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
+        Intent intent = new Intent(Intent.ACTION_MAIN);
+        intent.setPackage(context.getPackageName());
+        intent.setComponent(new ComponentName(context, ChromeLauncherActivity.class));
+        intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+
+        Runnable activityTrigger = () -> TestThreadUtils.runOnUiThreadBlocking(() -> {
+            FirstRunFlowSequencer.launch(context, intent, false /* requiresBroadcast */,
+                    false /* preferLightweightFre */);
+        });
+        mActivity = ActivityUtils.waitForActivity(InstrumentationRegistry.getInstrumentation(),
+                FirstRunActivity.class, activityTrigger);
+
+        try {
+            mTestObserver.flowIsKnownCallback.waitForCallback(0);
+        } catch (TimeoutException e) {
+            Assert.fail();
+        }
+        CriteriaHelper.pollUiThread(
+                (() -> mActivity.isNativeSideIsInitializedForTest()), "native never initialized.");
     }
 
     @After
@@ -133,12 +111,10 @@ public class FirstRunTest {
     }
 
     // Test that signing in through FirstRun signs in and starts sync.
-    /*
-     * @SmallTest
-     * @Feature({"Sync"})
-     */
     @Test
-    @FlakyTest(message = "https://crbug.com/616456")
+    @LargeTest
+    @Feature({"Sync"})
+    @DisabledTest(message = "https://crbug.com/616456")
     public void testSignIn() {
         Account testAccount = mSyncTestRule.addTestAccount();
         Assert.assertNull(mSyncTestRule.getCurrentSignedInAccount());
@@ -151,12 +127,10 @@ public class FirstRunTest {
 
     // Test that signing in and opening settings through FirstRun signs in and doesn't fully start
     // sync until the settings page is closed.
-    /*
-     * @SmallTest
-     * @Feature({"Sync"})
-     */
     @Test
-    @FlakyTest(message = "https://crbug.com/616456")
+    @LargeTest
+    @Feature({"Sync"})
+    @DisabledTest(message = "https://crbug.com/616456")
     public void testSignInWithOpenSettings() {
         final Account testAccount = mSyncTestRule.addTestAccount();
         final SettingsActivity settingsActivity =
@@ -169,20 +143,27 @@ public class FirstRunTest {
         Assert.assertFalse(SyncTestUtil.isSyncActive());
 
         // Close the settings fragment.
-        AccountManagementFragment fragment =
-                (AccountManagementFragment) settingsActivity.getMainFragment();
+        SyncAndServicesSettings fragment =
+                (SyncAndServicesSettings) settingsActivity.getMainFragment();
         Assert.assertNotNull(fragment);
         settingsActivity.getSupportFragmentManager().beginTransaction().remove(fragment).commit();
 
-        // Sync should immediately become active.
+        TestThreadUtils.runOnUiThreadBlocking(() -> {
+            // First setup should not be marked as complete just by closing the fragment.
+            Assert.assertFalse(mSyncTestRule.getProfileSyncService().isFirstSetupComplete());
+
+            // Marking the first setup as complete should make sync active.
+            mSyncTestRule.getProfileSyncService().setFirstSetupComplete(
+                    SyncFirstSetupCompleteSource.BASIC_FLOW);
+        });
         Assert.assertTrue(SyncTestUtil.isSyncActive());
     }
 
     // Test that not signing in through FirstRun does not sign in sync.
     @Test
-    @SmallTest
+    @LargeTest
     @Feature({"Sync"})
-    @DisabledTest // https://crbug.com/901488
+    @DisabledTest(message = "https://crbug.com/616456")
     public void testNoSignIn() {
         mSyncTestRule.addTestAccount();
         Assert.assertFalse(SyncTestUtil.isSyncRequested());

chrome/android/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java

@@ -24,6 +24,7 @@ import org.chromium.chrome.browser.flags.ChromeSwitches;
 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
 import org.chromium.chrome.browser.tabmodel.TabModelUtils;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.browser.sync.SyncTestUtil;
 import org.chromium.components.sync.protocol.EntitySpecifics;
 import org.chromium.components.sync.protocol.SessionHeader;
@@ -51,6 +52,10 @@ public class OpenTabsTest {
     @Rule
     public SyncTestRule mSyncTestRule = new SyncTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     private static final String TAG = "OpenTabsTest";
 
     private static final String OPEN_TABS_TYPE = "Sessions";
@@ -96,6 +101,8 @@ public class OpenTabsTest {
         mSyncTestRule.setUpAccountAndEnableSyncForTesting();
         mClientName = getClientName();
         mSessionTagCounter = 0;
+
+        mActivityTestRule.startMainActivityOnBlankPage();
     }
 
     // Test syncing an open tab from client to server.
@@ -103,7 +110,7 @@ public class OpenTabsTest {
     @LargeTest
     @Feature({"Sync"})
     public void testUploadOpenTab() {
-        mSyncTestRule.loadUrl(URL);
+        mActivityTestRule.loadUrl(URL);
         waitForLocalTabsForClient(mClientName, URL);
         waitForServerTabs(URL);
     }
@@ -113,9 +120,9 @@ public class OpenTabsTest {
     @LargeTest
     @Feature({"Sync"})
     public void testUploadMultipleOpenTabs() {
-        mSyncTestRule.loadUrl(URL);
-        mSyncTestRule.loadUrlInNewTab(URL2);
-        mSyncTestRule.loadUrlInNewTab(URL3);
+        mActivityTestRule.loadUrl(URL);
+        mActivityTestRule.loadUrlInNewTab(URL2);
+        mActivityTestRule.loadUrlInNewTab(URL3);
         waitForLocalTabsForClient(mClientName, URL, URL2, URL3);
         waitForServerTabs(URL, URL2, URL3);
     }
@@ -125,14 +132,14 @@ public class OpenTabsTest {
     @LargeTest
     @Feature({"Sync"})
     public void testUploadAndCloseOpenTab() {
-        mSyncTestRule.loadUrl(URL);
+        mActivityTestRule.loadUrl(URL);
         // Can't have zero tabs, so we have to open two to test closing one.
-        mSyncTestRule.loadUrlInNewTab(URL2);
+        mActivityTestRule.loadUrlInNewTab(URL2);
         waitForLocalTabsForClient(mClientName, URL, URL2);
         waitForServerTabs(URL, URL2);
 
         TestThreadUtils.runOnUiThreadBlocking(() -> {
-            TabModelSelector selector = mSyncTestRule.getActivity().getTabModelSelector();
+            TabModelSelector selector = mActivityTestRule.getActivity().getTabModelSelector();
             Assert.assertTrue(TabModelUtils.closeCurrentTab(selector.getCurrentModel()));
         });
 

chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTestRule.java

@@ -16,19 +16,17 @@ import androidx.annotation.Nullable;
 import androidx.preference.TwoStatePreference;
 
 import org.junit.Assert;
+import org.junit.rules.TestRule;
 import org.junit.runner.Description;
 import org.junit.runners.model.Statement;
 
 import org.chromium.base.Promise;
-import org.chromium.chrome.browser.app.ChromeActivity;
 import org.chromium.chrome.browser.autofill.PersonalDataManager;
 import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard;
+import org.chromium.chrome.browser.init.ProcessInitializationHandler;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.signin.UnifiedConsentServiceBridge;
-import org.chromium.chrome.browser.uid.UniqueIdentificationGenerator;
 import org.chromium.chrome.browser.uid.UniqueIdentificationGeneratorFactory;
-import org.chromium.chrome.browser.uid.UuidBasedUniqueIdentificationGenerator;
-import org.chromium.chrome.test.ChromeActivityTestRule;
 import org.chromium.chrome.test.util.browser.signin.AccountManagerTestRule;
 import org.chromium.chrome.test.util.browser.signin.SigninTestUtil;
 import org.chromium.chrome.test.util.browser.sync.SyncTestUtil;
@@ -52,7 +50,7 @@ import java.util.concurrent.Callable;
 /**
  * TestRule for common functionality between sync tests.
  */
-public class SyncTestRule extends ChromeActivityTestRule<ChromeActivity> {
+public class SyncTestRule implements TestRule {
     private static final String TAG = "SyncTestBase";
 
     private static final String CLIENT_ID = "Client_ID";
@@ -142,9 +140,7 @@ public class SyncTestRule extends ChromeActivityTestRule<ChromeActivity> {
         ProfileSyncService.resetForTests();
     }
 
-    public SyncTestRule() {
-        super(ChromeActivity.class);
-    }
+    public SyncTestRule() {}
 
     /**Getters for Test variables */
     public Context getTargetContext() {
@@ -163,12 +159,6 @@ public class SyncTestRule extends ChromeActivityTestRule<ChromeActivity> {
         return mSyncContentResolver;
     }
 
-    public void startMainActivityForSyncTest() throws Exception {
-        // Start the activity by opening about:blank. This URL is ideal because it is not synced as
-        // a typed URL. If another URL is used, it could interfere with test data.
-        startMainActivityOnBlankPage();
-    }
-
     /**
      * Adds an account of default account name to AccountManagerFacade and waits for the seeding.
      */
@@ -315,7 +305,7 @@ public class SyncTestRule extends ChromeActivityTestRule<ChromeActivity> {
 
     @Override
     public Statement apply(final Statement statement, final Description desc) {
-        final Statement base = super.apply(new Statement() {
+        return mAccountManagerTestRule.apply(new Statement() {
             @Override
             public void evaluate() throws Throwable {
                 mSyncContentResolver = new MockSyncContentResolverDelegate();
@@ -328,6 +318,9 @@ public class SyncTestRule extends ChromeActivityTestRule<ChromeActivity> {
 
                 // Load native since the FakeServer needs it and possibly ProfileSyncService as well
                 // (depends on what fake is provided by |createProfileSyncService()|).
+                TestThreadUtils.runOnUiThreadBlocking(() -> {
+                    ProcessInitializationHandler.getInstance().initializePreNative();
+                });
                 NativeLibraryTestUtils.loadNativeLibraryAndInitBrowserProcess();
 
                 TestThreadUtils.runOnUiThreadBlocking(() -> {
@@ -343,27 +336,13 @@ public class SyncTestRule extends ChromeActivityTestRule<ChromeActivity> {
                 });
 
                 UniqueIdentificationGeneratorFactory.registerGenerator(
-                        UuidBasedUniqueIdentificationGenerator.GENERATOR_ID,
-                        new UniqueIdentificationGenerator() {
-                            @Override
-                            public String getUniqueId(String salt) {
-                                return CLIENT_ID;
-                            }
-                        },
-                        true);
-
-                startMainActivityForSyncTest();
+                        SyncController.GENERATOR_ID, salt -> CLIENT_ID, true);
 
                 // Ensure SyncController is created.
                 TestThreadUtils.runOnUiThreadBlocking(() -> SyncController.get());
 
                 statement.evaluate();
-            }
-        }, desc);
-        return mAccountManagerTestRule.apply(new Statement() {
-            @Override
-            public void evaluate() throws Throwable {
-                base.evaluate();
+
                 ruleTearDown();
             }
         }, desc);

chrome/android/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java

@@ -21,6 +21,7 @@ import org.chromium.base.test.util.CommandLineFlags;
 import org.chromium.base.test.util.Feature;
 import org.chromium.chrome.browser.flags.ChromeSwitches;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.browser.sync.SyncTestUtil;
 import org.chromium.components.sync.ModelType;
 import org.chromium.components.sync.protocol.EntitySpecifics;
@@ -45,6 +46,10 @@ public class TypedUrlsTest {
     @Rule
     public SyncTestRule mSyncTestRule = new SyncTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     private static final String TAG = "TypedUrlsTest";
 
     private static final String TYPED_URLS_TYPE = "Typed URLs";
@@ -70,6 +75,7 @@ public class TypedUrlsTest {
     @Before
     public void setUp() throws Exception {
         mSyncTestRule.setUpAccountAndEnableSyncForTesting();
+        mActivityTestRule.startMainActivityOnBlankPage();
         // Make sure the initial state is clean.
         assertClientTypedUrlCount(0);
         assertServerTypedUrlCountWithName(0, URL);
@@ -122,7 +128,7 @@ public class TypedUrlsTest {
     private void loadUrlByTyping(final String url) {
         TestThreadUtils.runOnUiThreadBlocking(() -> {
             LoadUrlParams params = new LoadUrlParams(url, PageTransition.TYPED);
-            mSyncTestRule.getActivity().getActivityTab().loadUrl(params);
+            mActivityTestRule.getActivity().getActivityTab().loadUrl(params);
         });
     }
 

chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseTypeDialogFragmentTest.java

@@ -12,6 +12,7 @@ import android.widget.ListView;
 import androidx.test.filters.SmallTest;
 
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -23,6 +24,7 @@ import org.chromium.chrome.R;
 import org.chromium.chrome.browser.flags.ChromeSwitches;
 import org.chromium.chrome.browser.sync.SyncTestRule;
 import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
+import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.components.sync.PassphraseType;
 
 /**
@@ -34,6 +36,10 @@ public class PassphraseTypeDialogFragmentTest {
     @Rule
     public SyncTestRule mSyncTestRule = new SyncTestRule();
 
+    @Rule
+    public final ChromeTabbedActivityTestRule mActivityTestRule =
+            new ChromeTabbedActivityTestRule();
+
     private static final String TAG = "PassphraseTypeDialogFragmentTest";
 
     private static final boolean ENABLED = true;
@@ -54,6 +60,11 @@ public class PassphraseTypeDialogFragmentTest {
 
     private PassphraseTypeDialogFragment mTypeFragment;
 
+    @Before
+    public void setUp() {
+        mActivityTestRule.startMainActivityOnBlankPage();
+    }
+
     @Test
     @SmallTest
     @Feature({"Sync"})
@@ -119,7 +130,7 @@ public class PassphraseTypeDialogFragmentTest {
 
     public void createFragment(@PassphraseType int type, boolean isEncryptEverythingAllowed) {
         mTypeFragment = PassphraseTypeDialogFragment.create(type, 0, isEncryptEverythingAllowed);
-        mTypeFragment.show(mSyncTestRule.getActivity().getSupportFragmentManager(), TAG);
+        mTypeFragment.show(mActivityTestRule.getActivity().getSupportFragmentManager(), TAG);
         InstrumentationRegistry.getInstrumentation().waitForIdleSync();
     }