Commit 98849b93 authored by ggaren@apple.com's avatar ggaren@apple.com

2011-04-04 Geoffrey Garen <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
        https://bugs.webkit.org/show_bug.cgi?id=57790

        * collector/handles/HandleHeap.cpp:
        (JSC::HandleHeap::updateWeakHandles): Updated for rename.

        * collector/handles/HandleHeap.h: Removed comment claiming that this
        function should only be called during teardown, because it's actually
        called after every GC pass.

        * runtime/Heap.cpp:
        (JSC::Heap::destroy):
        (JSC::Heap::markRoots): Updated for rename.


git-svn-id: svn://svn.chromium.org/blink/trunk@82875 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 89f977fb
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
https://bugs.webkit.org/show_bug.cgi?id=57790
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::updateWeakHandles): Updated for rename.
* collector/handles/HandleHeap.h: Removed comment claiming that this
function should only be called during teardown, because it's actually
called after every GC pass.
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots): Updated for rename.
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
......
......@@ -55,12 +55,7 @@ void HandleHeap::markStrongHandles(HeapRootMarker& heapRootMarker)
heapRootMarker.mark(node->slot());
}
void HandleHeap::updateAfterMark()
{
clearWeakPointers();
}
void HandleHeap::clearWeakPointers()
void HandleHeap::updateWeakHandles()
{
Node* end = m_weakList.end();
for (Node* node = m_weakList.begin(); node != end; node = m_nextToFinalize) {
......
......@@ -56,10 +56,7 @@ public:
void makeWeak(HandleSlot, WeakHandleOwner* = 0, void* context = 0);
void markStrongHandles(HeapRootMarker&);
void updateAfterMark();
// Should only be called during teardown.
void clearWeakPointers();
void updateWeakHandles();
void writeBarrier(HandleSlot, const JSValue&);
......
......@@ -82,7 +82,7 @@ void Heap::destroy()
delete m_markListSet;
m_markListSet = 0;
m_markedSpace.clearMarks();
m_handleHeap.clearWeakPointers();
m_handleHeap.updateWeakHandles();
m_markedSpace.destroy();
m_globalData = 0;
......@@ -249,7 +249,7 @@ void Heap::markRoots()
markStack.drain();
markStack.compact();
m_handleHeap.updateAfterMark();
m_handleHeap.updateWeakHandles();
m_operationInProgress = NoOperation;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment