TWA Quality enforcement on failing digital assert link

This CL adds the TWA quality enforcement for the launching URL failing
the digital assert link verification.

Bug: 1109609
Change-Id: I459015c0a70d4c00a5c3ec4f6f4506ff914c0552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339228Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798653}

chrome/android/java/src/org/chromium/chrome/browser/browserservices/QualityEnforcer.java

@@ -24,6 +24,8 @@ import org.chromium.chrome.browser.customtabs.content.TabObserverRegistrar;
 import org.chromium.chrome.browser.customtabs.content.TabObserverRegistrar.CustomTabTabObserver;
 import org.chromium.chrome.browser.dependency_injection.ActivityScope;
 import org.chromium.chrome.browser.flags.ChromeFeatureList;
+import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
+import org.chromium.chrome.browser.lifecycle.NativeInitObserver;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.content_public.browser.NavigationHandle;
 import org.chromium.net.NetError;
@@ -44,7 +46,7 @@ import javax.inject.Inject;
  * will crash. We should hold web apps to the same standard.
  */
 @ActivityScope
-public class QualityEnforcer {
+public class QualityEnforcer implements NativeInitObserver {
     @VisibleForTesting
     static final String NOTIFY = "quality_enforcement.notify";
     @VisibleForTesting
@@ -58,6 +60,7 @@ public class QualityEnforcer {
     private final CustomTabsConnection mConnection;
     private final CustomTabsSessionToken mSessionToken;
     private final ClientPackageNameProvider mClientPackageNameProvider;
+    private final BrowserServicesIntentDataProvider mIntentDataProvider;
     private final TrustedWebActivityUmaRecorder mUmaRecorder;
 
     private boolean mOriginVerified;
@@ -104,19 +107,33 @@ public class QualityEnforcer {
     };
 
     @Inject
-    public QualityEnforcer(ChromeActivity<?> activity, TabObserverRegistrar tabObserverRegistrar,
+    public QualityEnforcer(ChromeActivity<?> activity,
+            ActivityLifecycleDispatcher lifecycleDispatcher,
+            TabObserverRegistrar tabObserverRegistrar,
             BrowserServicesIntentDataProvider intentDataProvider, CustomTabsConnection connection,
             Verifier verifier, ClientPackageNameProvider clientPackageNameProvider,
             TrustedWebActivityUmaRecorder umaRecorder) {
         mActivity = activity;
         mVerifier = verifier;
-        mConnection = connection;
         mSessionToken = intentDataProvider.getSession();
+        mIntentDataProvider = intentDataProvider;
+        mConnection = connection;
         mClientPackageNameProvider = clientPackageNameProvider;
         mUmaRecorder = umaRecorder;
         // Initialize the value to true before the first navigation.
         mOriginVerified = true;
         tabObserverRegistrar.registerActivityTabObserver(mTabObserver);
+        lifecycleDispatcher.register(this);
+    }
+
+    @Override
+    public void onFinishNativeInitialization() {
+        String url = mIntentDataProvider.getUrlToLoad();
+        mVerifier.verify(url).then((verified) -> {
+            if (!verified) {
+                trigger(ViolationType.DIGITAL_ASSERTLINKS, mIntentDataProvider.getUrlToLoad(), 0);
+            }
+        });
     }
 
     private void trigger(@ViolationType int type, String url, int httpStatusCode) {
@@ -160,14 +177,20 @@ public class QualityEnforcer {
 
     /* Get the localized string for toast message. */
     private String getToastMessage(@ViolationType int type, String url, int httpStatusCode) {
-        if (type == ViolationType.ERROR_404 || type == ViolationType.ERROR_5XX) {
-            return ContextUtils.getApplicationContext().getString(
-                    R.string.twa_quality_enforcement_violation_error, httpStatusCode, url);
-        } else if (type == ViolationType.UNAVAILABLE_OFFLINE) {
-            return ContextUtils.getApplicationContext().getString(
-                    R.string.twa_quality_enforcement_violation_offline, url);
+        switch (type) {
+            case ViolationType.ERROR_404:
+            case ViolationType.ERROR_5XX:
+                return ContextUtils.getApplicationContext().getString(
+                        R.string.twa_quality_enforcement_violation_error, httpStatusCode, url);
+            case ViolationType.UNAVAILABLE_OFFLINE:
+                return ContextUtils.getApplicationContext().getString(
+                        R.string.twa_quality_enforcement_violation_offline, url);
+            case ViolationType.DIGITAL_ASSERTLINKS:
+                return ContextUtils.getApplicationContext().getString(
+                        R.string.twa_quality_enforcement_violation_assert_link, url);
+            default:
+                return "";
         }
-        return "";
     }
 
     /*
@@ -175,11 +198,16 @@ public class QualityEnforcer {
      * the toast because this is used in TWA's crash message.
      */
     private String toTwaCrashMessage(@ViolationType int type, String url, int httpStatusCode) {
-        if (type == ViolationType.ERROR_404 || type == ViolationType.ERROR_5XX) {
-            return httpStatusCode + " on " + url;
-        } else if (type == ViolationType.UNAVAILABLE_OFFLINE) {
-            return "Page unavailable offline: " + url;
+        switch (type) {
+            case ViolationType.ERROR_404:
+            case ViolationType.ERROR_5XX:
+                return httpStatusCode + " on " + url;
+            case ViolationType.UNAVAILABLE_OFFLINE:
+                return "Page unavailable offline: " + url;
+            case ViolationType.DIGITAL_ASSERTLINKS:
+                return "Digital assert links verification failed on " + url;
+            default:
+                return "";
         }
-        return "";
     }
 }

chrome/android/javatests/src/org/chromium/chrome/browser/browserservices/QualityEnforcerTest.java

@@ -119,7 +119,30 @@ public class QualityEnforcerTest {
         assertEquals(mErrorMessage, "Page unavailable offline: https://example.com/");
     }
 
+    @Test
+    @MediumTest
+    public void notifiedDigitalAssertLinkFailed() throws TimeoutException {
+        launchNotVerify(mTestPage);
+        mCallbackHelper.waitForFirst();
+    }
+
     public void launch(String testPage) throws TimeoutException {
+        Intent intent = createTrustedWebActivityIntentWithCallback(testPage);
+        spoofVerification(PACKAGE_NAME, testPage);
+        createSession(intent, PACKAGE_NAME);
+
+        mCustomTabActivityTestRule.startCustomTabActivityWithIntent(intent);
+    }
+
+    public void launchNotVerify(String testPage) throws TimeoutException {
+        Intent intent = createTrustedWebActivityIntentWithCallback(testPage);
+        createSession(intent, PACKAGE_NAME);
+
+        mCustomTabActivityTestRule.startCustomTabActivityWithIntent(intent);
+    }
+
+    private Intent createTrustedWebActivityIntentWithCallback(String testPage)
+            throws TimeoutException {
         CustomTabsSession session = CustomTabsTestUtils.bindWithCallback(mCallback).session;
         Intent intent = new CustomTabsIntent.Builder(session).build().intent;
         intent.setComponent(new ComponentName(
@@ -128,10 +151,6 @@ public class QualityEnforcerTest {
         intent.setData(Uri.parse(testPage));
         intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
         intent.putExtra(TrustedWebUtils.EXTRA_LAUNCH_AS_TRUSTED_WEB_ACTIVITY, true);
-
-        spoofVerification(PACKAGE_NAME, testPage);
-        createSession(intent, PACKAGE_NAME);
-
-        mCustomTabActivityTestRule.startCustomTabActivityWithIntent(intent);
+        return intent;
     }
 }

chrome/android/junit/src/org/chromium/chrome/browser/browserservices/QualityEnforcerUnitTest.java

@@ -39,6 +39,7 @@ import org.chromium.chrome.browser.customtabs.CustomTabsConnection;
 import org.chromium.chrome.browser.customtabs.content.TabObserverRegistrar;
 import org.chromium.chrome.browser.customtabs.content.TabObserverRegistrar.CustomTabTabObserver;
 import org.chromium.chrome.browser.flags.ChromeFeatureList;
+import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.test.util.browser.Features;
 import org.chromium.chrome.test.util.browser.Features.DisableFeatures;
@@ -63,6 +64,8 @@ public class QualityEnforcerUnitTest {
     @Mock
     private ChromeActivity mActivity;
     @Mock
+    ActivityLifecycleDispatcher mLifecycleDispatcher;
+    @Mock
     private CustomTabIntentDataProvider mIntentDataProvider;
     @Mock
     private CustomTabsConnection mCustomTabsConnection;
@@ -93,9 +96,9 @@ public class QualityEnforcerUnitTest {
         when(mVerifier.verify(TRUSTED_ORIGIN_PAGE)).thenReturn(Promise.fulfilled(true));
         when(mVerifier.verify(UNTRUSTED_PAGE)).thenReturn(Promise.fulfilled(false));
 
-        mQualityEnforcer =
-                new QualityEnforcer(mActivity, mTabObserverRegistrar, mIntentDataProvider,
-                        mCustomTabsConnection, mVerifier, mClientPackageNameProvider, mUmaRecorder);
+        mQualityEnforcer = new QualityEnforcer(mActivity, mLifecycleDispatcher,
+                mTabObserverRegistrar, mIntentDataProvider, mCustomTabsConnection, mVerifier,
+                mClientPackageNameProvider, mUmaRecorder);
     }
 
     @Test
@@ -160,7 +163,30 @@ public class QualityEnforcerUnitTest {
     @Test
     public void trigger_offline() {
         navigateToUrlInternet(TRUSTED_ORIGIN_PAGE);
-        verifyTriggeredOffline();
+        Assert.assertEquals(
+                ContextUtils.getApplicationContext().getString(
+                        R.string.twa_quality_enforcement_violation_offline, TRUSTED_ORIGIN_PAGE),
+                ShadowToast.getTextOfLatestToast());
+        verifyNotifyClientApp();
+    }
+
+    @Test
+    public void notTrigger_digitalAssertLinkPass() {
+        when(mIntentDataProvider.getUrlToLoad()).thenReturn(TRUSTED_ORIGIN_PAGE);
+        mQualityEnforcer.onFinishNativeInitialization();
+        verifyNotTriggered();
+    }
+
+    @Test
+    public void trigger_digitalAssertLinkFailed() {
+        when(mIntentDataProvider.getUrlToLoad()).thenReturn(UNTRUSTED_PAGE);
+        mQualityEnforcer.onFinishNativeInitialization();
+
+        Assert.assertEquals(
+                ContextUtils.getApplicationContext().getString(
+                        R.string.twa_quality_enforcement_violation_assert_link, UNTRUSTED_PAGE),
+                ShadowToast.getTextOfLatestToast());
+        verifyNotifyClientApp();
     }
 
     private void verifyTriggered404() {
@@ -168,15 +194,10 @@ public class QualityEnforcerUnitTest {
                                     R.string.twa_quality_enforcement_violation_error,
                                     HTTP_ERROR_NOT_FOUND, TRUSTED_ORIGIN_PAGE),
                 ShadowToast.getTextOfLatestToast());
-        verify(mCustomTabsConnection)
-                .sendExtraCallbackWithResult(any(), eq(QualityEnforcer.NOTIFY), any());
+        verifyNotifyClientApp();
     }
 
-    private void verifyTriggeredOffline() {
-        Assert.assertEquals(
-                ContextUtils.getApplicationContext().getString(
-                        R.string.twa_quality_enforcement_violation_offline, TRUSTED_ORIGIN_PAGE),
-                ShadowToast.getTextOfLatestToast());
+    private void verifyNotifyClientApp() {
         verify(mCustomTabsConnection)
                 .sendExtraCallbackWithResult(any(), eq(QualityEnforcer.NOTIFY), any());
     }

chrome/browser/ui/android/strings/android_chrome_strings.grd

@@ -3354,6 +3354,9 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p
       <message name="IDS_TWA_QUALITY_ENFORCEMENT_VIOLATION_ERROR" desc="Text shown on a toast when TWA violation 404.">
         <ph name="ERROR_CODE">%1$s<ex>404</ex></ph> on <ph name="VIOLATED_URL">%2$s<ex>https://example.com/</ex></ph>
       </message>
+      <message name="IDS_TWA_QUALITY_ENFORCEMENT_VIOLATION_ASSERT_LINK" desc="Text shown on a toast when TWA violate the quality enforcement criteria: digital assert link verification failed.">
+        Digital assert links verification failed on <ph name="VIOLATED_URL">%1$s<ex>https://example.com/</ex></ph>
+      </message>
       <message name="IDS_TWA_QUALITY_ENFORCEMENT_VIOLATION_OFFLINE" desc="Text shown on a toast when TWA violate the quality enforcement criteria: page unavailable offline.">
         Page unavailable offline: <ph name="VIOLATED_URL">%1$s<ex>https://example.com/</ex></ph>
       </message>

chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_TWA_QUALITY_ENFORCEMENT_VIOLATION_ASSERT_LINK.png.sha1

+2c71d89861d1abe6c3c2d571702bd360e75ba7cd
\ No newline at end of file