Commit 98a83013 authored by Eric Roman's avatar Eric Roman Committed by Commit Bot

Fix flakiness of FTP PAC tests.

Use 0.0.0.1:1 in place of 0.0.0.0:8000 as the address of the proxy server.

The test expects connections to the proxy server to fail - however connecting
to the ANY address (0.0.0.0) can succeed.

The new literal should fail consistently since:
  (1) 0.0.0.1 is a reserved IP address.
  (2) We disallow connections on TCP port 1.

Bug: 996367
Change-Id: I54ce278e75983110961da0cc49dd923decdd5ae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765662Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689615}
parent 6e6d13e3
......@@ -1729,9 +1729,7 @@ class NetworkContextConfigurationFtpPacBrowserTest
DISALLOW_COPY_AND_ASSIGN(NetworkContextConfigurationFtpPacBrowserTest);
};
// Flaky: crbug.com/996367
IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationFtpPacBrowserTest,
DISABLED_FtpPac) {
IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationFtpPacBrowserTest, FtpPac) {
if (IsRestartStateWithInProcessNetworkService())
return;
std::unique_ptr<network::ResourceRequest> request =
......
function FindProxyForURL(url, host){ return "PROXY 0.0.0.0:8000;"; }
function FindProxyForURL(url, host){ return "PROXY 0.0.0.1:1;"; }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment