Commit 98b751e8 authored by Yoshifumi Inoue's avatar Yoshifumi Inoue Committed by Commit Bot

Get rid of unused functions NGInlineCursor::Line{Start,End}Point()

This patch gets rid of unused functions |Line{Start,End}Point()| in
|NGInlineCursor| for improving code health.

CLs[1][2] made these functions unused.

[1] http://crrev.com/c/2467046 Make NGInlineCursor::
PositionForEndOfLine() not to use hit-testing
[2] http://crrev.com/c/2497742 Make NGInlineCursor::
PositionForStartOfLine() not to use hit-testing

Bug: 1136740
Change-Id: I3032907a738560f0789512be80175cfca2c8e2d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500687
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821124}
parent 3e256928
...@@ -655,25 +655,6 @@ LayoutUnit NGInlineCursor::InlinePositionForOffset(unsigned offset) const { ...@@ -655,25 +655,6 @@ LayoutUnit NGInlineCursor::InlinePositionForOffset(unsigned offset) const {
return LayoutUnit(); return LayoutUnit();
} }
PhysicalOffset NGInlineCursorPosition::LineStartPoint() const {
DCHECK(IsLineBox()) << this;
const LogicalOffset logical_start; // (0, 0)
const PhysicalSize pixel_size(LayoutUnit(1), LayoutUnit(1));
return logical_start.ConvertToPhysical(
{Style().GetWritingMode(), BaseDirection()}, Size(), pixel_size);
}
PhysicalOffset NGInlineCursorPosition::LineEndPoint() const {
DCHECK(IsLineBox()) << this;
const WritingMode writing_mode = Style().GetWritingMode();
const LayoutUnit inline_size =
IsHorizontalWritingMode(writing_mode) ? Size().width : Size().height;
const LogicalOffset logical_end(inline_size, LayoutUnit());
const PhysicalSize pixel_size(LayoutUnit(1), LayoutUnit(1));
return logical_end.ConvertToPhysical({writing_mode, BaseDirection()}, Size(),
pixel_size);
}
LogicalRect NGInlineCursorPosition::ConvertChildToLogical( LogicalRect NGInlineCursorPosition::ConvertChildToLogical(
const PhysicalRect& physical_rect) const { const PhysicalRect& physical_rect) const {
return WritingModeConverter( return WritingModeConverter(
......
...@@ -173,12 +173,6 @@ class CORE_EXPORT NGInlineCursorPosition { ...@@ -173,12 +173,6 @@ class CORE_EXPORT NGInlineCursorPosition {
// other than line. // other than line.
bool HasSoftWrapToNextLine() const; bool HasSoftWrapToNextLine() const;
// Returns a point at the visual start/end of the line. (0, 0) is left-top of
// the line.
// Encapsulates the handling of text direction and writing mode.
PhysicalOffset LineStartPoint() const;
PhysicalOffset LineEndPoint() const;
// LogicalRect/PhysicalRect conversions // LogicalRect/PhysicalRect conversions
// |logical_rect| and |physical_rect| are converted with |Size()| as // |logical_rect| and |physical_rect| are converted with |Size()| as
// "outer size". // "outer size".
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment