Commit 98bdb40f authored by David Benjamin's avatar David Benjamin Committed by Commit Bot

Remove unnecessary ignore_certificate_errors check.

If the HttpNetworkSession is configured to ignore certificate errors,
the errors will not be surfaced out of OnSSLCertificateError and there
is no need to second-guess it. This code dates to
https://codereview.chromium.org/2725293003 which simultaneously fixed
one bit of --ignore-certificate-errors plumbing and added that check.
Only the former was necessary.

Bug: none
Change-Id: I801da673b5dc538d34969fffd2a62080e73873fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736175
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: default avatarLuke Halliwell <halliwell@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684162}
parent c70fd70c
......@@ -240,15 +240,6 @@ void ConnectivityCheckerImpl::OnSSLCertificateError(
int net_error,
const net::SSLInfo& ssl_info,
bool fatal) {
if (url_request_context_->http_transaction_factory()
->GetSession()
->params()
.ignore_certificate_errors) {
LOG(WARNING) << "OnSSLCertificateError: ignore cert_status="
<< ssl_info.cert_status;
request->ContinueDespiteLastError();
return;
}
DCHECK(task_runner_->BelongsToCurrentThread());
LOG(ERROR) << "OnSSLCertificateError: cert_status=" << ssl_info.cert_status;
url_request_context_->http_transaction_factory()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment