Commit 98cbb0e1 authored by Dale Curtis's avatar Dale Curtis Committed by Commit Bot

Add additional comments for HBD YUV decode support.

Resolves some post-commit comments.

R=pkasting, wtc

Bug: 1008448
Change-Id: I02e503c0284726e7f5bf122130b330ecc3659901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332279
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793749}
parent ec9e5529
......@@ -66,6 +66,10 @@ class PLATFORM_EXPORT ImagePlanes final {
public:
ImagePlanes();
// |color_type| is kGray_8_SkColorType if GetYUVBitDepth() == 8 and either
// kA16_float_SkColorType or kA16_unorm_SkColorType if GetYUVBitDepth() > 8.
//
// TODO(crbug/910276): To support YUVA, ImagePlanes needs to support a
// variable number of planes.
ImagePlanes(void* planes[3],
......@@ -285,6 +289,9 @@ class PLATFORM_EXPORT ImageDecoder {
}
// Image decoders that support high bit depth YUV decoding can override this.
//
// Note: If an implementation advertises a bit depth > 8 it must support both
// kA16_unorm_SkColorType and kA16_float_SkColorType ImagePlanes.
virtual uint8_t GetYUVBitDepth() const { return 8; }
// Returns the information required to decide whether or not hardware
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment