Update reference box for all pixel moving filters

Pixel moving filters [1] can expand bounds of visual effect from the
bounds of all descendants. We need reference box for all of them.

[1] https://cs.chromium.org/chromium/src/cc/paint/filter_operations.cc?rcl=0b6c41a840ed2a011a989c5d2130b93cc038fc4d&l=82

Change-Id: I1a1fcce6b1db2d876820d263c1456fe6c482ba33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095958Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748774}

third_party/blink/renderer/core/paint/paint_layer.cc

@@ -2534,7 +2534,7 @@ PaintLayer* PaintLayer::HitTestChildren(
 }
 
 void PaintLayer::UpdateFilterReferenceBox() {
-  if (!NeedsFilterReferenceBox())
+  if (!HasFilterThatMovesPixels())
     return;
   FloatRect reference_box =
       FloatRect(PhysicalBoundingBoxIncludingStackingChildren(
@@ -2548,16 +2548,6 @@ void PaintLayer::UpdateFilterReferenceBox() {
   EnsureResourceInfo().SetFilterReferenceBox(reference_box);
 }
 
-bool PaintLayer::NeedsFilterReferenceBox() const {
-  if (GetLayoutObject().HasReflection() && GetLayoutObject().IsBox())
-    return true;
-  FilterOperations operations = GetLayoutObject().StyleRef().Filter();
-  if (operations.HasBlurOrReferenceFilter())
-    return true;
-  operations = GetLayoutObject().StyleRef().BackdropFilter();
-  return !operations.IsEmpty();
-}
-
 FloatRect PaintLayer::FilterReferenceBox() const {
   DCHECK(IsAllowedToQueryCompositingState());
   if (ResourceInfo())
@@ -3485,7 +3475,7 @@ bool PaintLayer::HasFilterThatMovesPixels() const {
   const ComputedStyle& style = GetLayoutObject().StyleRef();
   if (style.HasFilter() && style.Filter().HasFilterThatMovesPixels())
     return true;
-  if (style.HasBoxReflect())
+  if (GetLayoutObject().HasReflection())
     return true;
   return false;
 }

third_party/blink/renderer/core/paint/paint_layer.h

@@ -1270,8 +1270,6 @@ class CORE_EXPORT PaintLayer : public DisplayItemClient {
   bool ShouldApplyTransformToBoundingBox(const PaintLayer& composited_layer,
                                          CalculateBoundsOptions) const;
 
-  bool NeedsFilterReferenceBox() const;
-
   AncestorDependentCompositingInputs& EnsureAncestorDependentCompositingInputs()
       const {
     if (!ancestor_dependent_compositing_inputs_) {

third_party/blink/renderer/core/style/filter_operations.cc

@@ -70,16 +70,6 @@ bool FilterOperations::CanInterpolateWith(const FilterOperations& other) const {
   return true;
 }
 
-bool FilterOperations::HasBlurOrReferenceFilter() const {
-  for (const auto& operation : operations_) {
-    FilterOperation::OperationType type = operation->GetType();
-    if (type == FilterOperation::BLUR || type == FilterOperation::REFERENCE) {
-      return true;
-    }
-  }
-  return false;
-}
-
 FloatRect FilterOperations::MapRect(const FloatRect& rect) const {
   auto accumulate_mapped_rect = [](const FloatRect& rect,
                                    const Member<FilterOperation>& op) {

third_party/blink/renderer/core/style/filter_operations.h

@@ -70,8 +70,6 @@ class CORE_EXPORT FilterOperations {
   bool HasFilterThatAffectsOpacity() const;
   bool HasFilterThatMovesPixels() const;
 
-  bool HasBlurOrReferenceFilter() const;
-
   void AddClient(SVGResourceClient&) const;
   void RemoveClient(SVGResourceClient&) const;
 

third_party/blink/web_tests/flag-specific/composite-after-paint/paint/invalidation/filters/filter-repaint-accelerated-child-with-filter-child-expected.txt

@@ -21,7 +21,12 @@
         {
           "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow'",
           "rect": [0, 0, 214, 260],
-          "reason": "geometry"
+          "reason": "paint property change"
+        },
+        {
+          "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow'",
+          "rect": [0, 0, 160, 260],
+          "reason": "paint property change"
         }
       ],
       "transform": 1

third_party/blink/web_tests/flag-specific/composite-after-paint/paint/invalidation/filters/filter-repaint-accelerated-on-accelerated-filter-expected.txt

@@ -21,7 +21,7 @@
         {
           "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow accelerated'",
           "rect": [0, 0, 160, 260],
-          "reason": "geometry"
+          "reason": "paint property change"
         }
       ],
       "transform": 1

third_party/blink/web_tests/flag-specific/disable-layout-ng/paint/invalidation/filters/filter-repaint-accelerated-child-with-filter-child-expected.txt

@@ -19,7 +19,12 @@
         {
           "object": "LayoutBlockFlow DIV id='resize' class='drop-shadow'",
           "rect": [0, 0, 212, 257],
-          "reason": "geometry"
+          "reason": "paint property change"
+        },
+        {
+          "object": "LayoutBlockFlow DIV id='resize' class='drop-shadow'",
+          "rect": [0, 0, 158, 257],
+          "reason": "paint property change"
         }
       ],
       "transform": 1

third_party/blink/web_tests/platform/linux/paint/invalidation/filters/filter-repaint-accelerated-child-with-filter-child-expected.txt

@@ -19,7 +19,12 @@
         {
           "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow'",
           "rect": [0, 0, 212, 257],
-          "reason": "geometry"
+          "reason": "paint property change"
+        },
+        {
+          "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow'",
+          "rect": [0, 0, 158, 257],
+          "reason": "paint property change"
         }
       ],
       "transform": 1

third_party/blink/web_tests/platform/mac/paint/invalidation/filters/filter-repaint-accelerated-child-with-filter-child-expected.txt

@@ -19,7 +19,12 @@
         {
           "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow'",
           "rect": [0, 0, 212, 257],
-          "reason": "geometry"
+          "reason": "paint property change"
+        },
+        {
+          "object": "LayoutNGBlockFlow DIV id='resize' class='drop-shadow'",
+          "rect": [0, 0, 158, 257],
+          "reason": "paint property change"
         }
       ],
       "transform": 1