Commit 98f8b496 authored by Sergey Poromov's avatar Sergey Poromov Committed by Commit Bot

Enable WebRtcGetDisplayMediaBrowserTestWithPicker test on Chrome OS.

The tests were failing because on Chrome OS the desktop capture source
is named "Display", not "Entire screen".

Change-Id: I008f406557dd4bb6a55ab301b4bb1651e0726eca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517582Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824091}
parent 530a7c8e
...@@ -66,17 +66,22 @@ class WebRtcGetDisplayMediaBrowserTestWithPicker ...@@ -66,17 +66,22 @@ class WebRtcGetDisplayMediaBrowserTestWithPicker
void SetUpCommandLine(base::CommandLine* command_line) override { void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch( command_line->AppendSwitch(
switches::kEnableExperimentalWebPlatformFeatures); switches::kEnableExperimentalWebPlatformFeatures);
#if defined(OS_CHROMEOS)
command_line->AppendSwitchASCII(switches::kAutoSelectDesktopCaptureSource,
"Display");
#else
command_line->AppendSwitchASCII(switches::kAutoSelectDesktopCaptureSource, command_line->AppendSwitchASCII(switches::kAutoSelectDesktopCaptureSource,
"Entire screen"); "Entire screen");
#endif
} }
}; };
// Real desktop capture is flaky on below platforms. // Real desktop capture is flaky on below platforms.
#if defined(OS_CHROMEOS) || defined(OS_WIN) #if defined(OS_WIN)
#define MAYBE_GetDisplayMediaVideo DISABLED_GetDisplayMediaVideo #define MAYBE_GetDisplayMediaVideo DISABLED_GetDisplayMediaVideo
#else #else
#define MAYBE_GetDisplayMediaVideo GetDisplayMediaVideo #define MAYBE_GetDisplayMediaVideo GetDisplayMediaVideo
#endif // defined(OS_CHROMEOS) || defined(OS_WIN) #endif // defined(OS_WIN)
IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker, IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker,
MAYBE_GetDisplayMediaVideo) { MAYBE_GetDisplayMediaVideo) {
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
...@@ -87,7 +92,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker, ...@@ -87,7 +92,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker,
} }
// Real desktop capture is flaky on below platforms. // Real desktop capture is flaky on below platforms.
#if defined(OS_CHROMEOS) || defined(OS_WIN) #if defined(OS_WIN)
#define MAYBE_GetDisplayMediaVideoAndAudio DISABLED_GetDisplayMediaVideoAndAudio #define MAYBE_GetDisplayMediaVideoAndAudio DISABLED_GetDisplayMediaVideoAndAudio
// On linux debug bots, it's flaky as well. // On linux debug bots, it's flaky as well.
#elif (defined(OS_LINUX) && !defined(NDEBUG)) #elif (defined(OS_LINUX) && !defined(NDEBUG))
...@@ -97,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker, ...@@ -97,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker,
#define MAYBE_GetDisplayMediaVideoAndAudio DISABLED_GetDisplayMediaVideoAndAudio #define MAYBE_GetDisplayMediaVideoAndAudio DISABLED_GetDisplayMediaVideoAndAudio
#else #else
#define MAYBE_GetDisplayMediaVideoAndAudio GetDisplayMediaVideoAndAudio #define MAYBE_GetDisplayMediaVideoAndAudio GetDisplayMediaVideoAndAudio
#endif // defined(OS_CHROMEOS) || defined(OS_WIN) #endif // defined(OS_WIN)
IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker, IN_PROC_BROWSER_TEST_F(WebRtcGetDisplayMediaBrowserTestWithPicker,
MAYBE_GetDisplayMediaVideoAndAudio) { MAYBE_GetDisplayMediaVideoAndAudio) {
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment