Commit 992abbe4 authored by Danyao Wang's avatar Danyao Wang Committed by Commit Bot

[Nav Experiment] Temporarily disable tests failing with slim nav.

This allows the slim nav bots to be added to the main waterfall.

Bug: 807428
Change-Id: Ia5caca43734158f88c2292222a2cbcd70049bb75
Reviewed-on: https://chromium-review.googlesource.com/c/1334191
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607717}
parent 147873d1
......@@ -260,6 +260,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the passwords view controller appears on screen.
- (void)testPasswordsViewControllerIsPresented {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -276,6 +280,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the passwords view controller contains the "Manage Passwords..."
// action.
- (void)testPasswordsViewControllerContainsManagePasswordsAction {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -291,6 +299,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the "Manage Passwords..." action works.
- (void)testManagePasswordsActionOpensPasswordSettings {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -310,6 +322,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is not present when presenting UI.
- (void)testPasswordControllerPauses {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// For the search bar to appear in password settings at least one password is
// needed.
SaveExamplePasswordForm();
......@@ -339,6 +355,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is resumed after selecting other
// password.
- (void)testPasswordControllerResumes {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// For this test one password is needed.
SaveExamplePasswordForm();
......@@ -381,6 +401,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is resumed after dismissing "Other
// Passwords".
- (void)testPasswordControllerResumesWhenOtherPasswordsDismiss {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -415,6 +439,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is dismissed when tapping the
// keyboard icon.
- (void)testKeyboardIconDismissPasswordController {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
if (IsIPadIdiom()) {
// The keyboard icon is never present in iPads.
return;
......@@ -446,6 +474,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is dismissed when tapping the outside
// the popover on iPad.
- (void)testIPadTappingOutsidePopOverDismissPasswordController {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
if (!IsIPadIdiom()) {
return;
}
......@@ -478,6 +510,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is dismissed when tapping the
// keyboard.
- (void)testTappingKeyboardDismissPasswordControllerPopOver {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
if (!IsIPadIdiom()) {
return;
}
......@@ -507,6 +543,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that after switching fields the content size of the table view didn't
// grow.
- (void)testPasswordControllerKeepsRightSize {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -534,6 +574,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller stays on rotation.
- (void)testPasswordControllerSupportsRotation {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -556,6 +600,10 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that content is injected in iframe messaging.
- (void)testPasswordControllerSupportsIFrameMessaging {
// TODO(crbug.com/904885): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Iframe messaging is not supported on iOS < 11.3.
if (!base::ios::IsRunningOnOrLater(11, 3, 0)) {
EARL_GREY_TEST_SKIPPED(@"Skipped for iOS < 11.3");
......
......@@ -33,6 +33,7 @@
#import "ios/chrome/test/earl_grey/chrome_matchers.h"
#import "ios/chrome/test/earl_grey/chrome_test_case.h"
#import "ios/third_party/material_components_ios/src/components/Snackbar/src/MaterialSnackbar.h"
#include "ios/web/public/features.h"
#import "ios/web/public/navigation_manager.h"
#import "ios/web/public/reload_type.h"
#import "ios/web/public/test/http_server/delayed_response_provider.h"
......@@ -534,6 +535,10 @@ void AssertIsShowingDistillablePage(bool online) {
FLAKY_testSavingToReadingListAndLoadNormal
#endif
- (void)MAYBE_testSavingToReadingListAndLoadNormal {
// TODO(crbug.com/874649): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
auto network_change_disabler =
std::make_unique<net::NetworkChangeNotifier::DisableForTest>();
auto wifi_network = std::make_unique<WifiNetworkChangeNotifier>();
......@@ -581,6 +586,10 @@ void AssertIsShowingDistillablePage(bool online) {
FLAKY_testSavingToReadingListAndLoadNoNetwork
#endif
- (void)MAYBE_testSavingToReadingListAndLoadNoNetwork {
// TODO(crbug.com/874649): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
auto network_change_disabler =
std::make_unique<net::NetworkChangeNotifier::DisableForTest>();
auto wifi_network = std::make_unique<WifiNetworkChangeNotifier>();
......
......@@ -168,6 +168,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL during
// pending back and forward navigations.
- (void)testBackForwardNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -214,6 +218,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL during
// pending navigations initialted from back history popover.
- (void)testHistoryNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -253,6 +261,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that stopping a pending Back navigation and reloading reloads committed
// URL, not pending URL.
- (void)testStoppingPendingBackNavigationAndReload {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -286,6 +298,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL during
// back forward navigations initiated with JS.
- (void)testJSBackForwardNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -331,6 +347,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL during go
// navigations initiated with JS.
- (void)testJSGoNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -377,6 +397,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL during go
// back navigation started with pending reload in progress.
- (void)testBackNavigationWithPendingReload {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -422,6 +446,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
FLAKY_testBackNavigationWithPendingRendererInitiatedNavigation
#endif
- (void)MAYBE_testBackNavigationWithPendingRendererInitiatedNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -452,6 +480,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// renderer-initiated navigation started with pending back navigation in
// progress.
- (void)testRendererInitiatedNavigationWithPendingBackNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Purge web view caches and pause the server to make sure that tests can
// verify omnibox state before server starts responding.
GREYAssert(PurgeCachedWebViewPages(), @"Pages were not purged");
......@@ -482,6 +514,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL if user
// issues 2 go back commands.
- (void)testDoubleBackNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Create 3rd entry in the history, to be able to go back twice.
[ChromeEarlGrey loadURL:_testURL3];
......@@ -513,6 +549,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL if user
// issues 2 go forward commands to WebUI page (crbug.com/711465).
- (void)testDoubleForwardNavigationToWebUIPage {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Create 3rd entry in the history, to be able to go back twice.
GURL URL(kChromeUIVersionURL);
[ChromeEarlGrey loadURL:GURL(kChromeUIVersionURL)];
......@@ -540,6 +580,10 @@ class PausableResponseProvider : public HtmlResponseProvider {
// Tests that visible URL is always the same as last committed URL if page calls
// window.history.back() twice.
- (void)testDoubleBackJSNavigation {
// TODO(crbug.com/874634): re-enable this test.
if (base::FeatureList::IsEnabled(web::features::kSlimNavigationManager))
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
// Create 3rd entry in the history, to be able to go back twice.
[ChromeEarlGrey loadURL:_testURL3];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment