Commit 9937ae18 authored by msw@chromium.org's avatar msw@chromium.org

Remove deprecated version of views::CreateDialogFrameView.

Patch Set 1 here is Lei's original patch:
https://codereview.chromium.org/109623005/
That was reverted for causing http://crbug.com/343042

This performs the same cleanup without the print preview regression.
(keeps ConstrainedWebDialogDelegateViewViews::CreateNonClientFrameView)

BUG=166075
TEST=No behavior/appearance changes; no dialog frame regressions (print preview or otherwise).
TBR=wittman@chromium.org,sky@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/165073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251243 0039d316-1c4b-4281-b951-d872f2087c98
parent a9694036
...@@ -1635,15 +1635,6 @@ bool AutofillDialogViews::Accept() { ...@@ -1635,15 +1635,6 @@ bool AutofillDialogViews::Accept() {
return false; return false;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView* AutofillDialogViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(
widget,
delegate_->GetWebContents()->GetBrowserContext());
}
void AutofillDialogViews::ContentsChanged(views::Textfield* sender, void AutofillDialogViews::ContentsChanged(views::Textfield* sender,
const base::string16& new_contents) { const base::string16& new_contents) {
InputEditedOrActivated(TypeForTextfield(sender), InputEditedOrActivated(TypeForTextfield(sender),
......
...@@ -121,8 +121,6 @@ class AutofillDialogViews : public AutofillDialogView, ...@@ -121,8 +121,6 @@ class AutofillDialogViews : public AutofillDialogView,
virtual views::View* CreateFootnoteView() OVERRIDE; virtual views::View* CreateFootnoteView() OVERRIDE;
virtual bool Cancel() OVERRIDE; virtual bool Cancel() OVERRIDE;
virtual bool Accept() OVERRIDE; virtual bool Accept() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
// views::WidgetObserver implementation: // views::WidgetObserver implementation:
virtual void OnWidgetClosing(views::Widget* widget) OVERRIDE; virtual void OnWidgetClosing(views::Widget* widget) OVERRIDE;
......
...@@ -20,7 +20,6 @@ ...@@ -20,7 +20,6 @@
#include "chrome/browser/infobars/infobar_service.h" #include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/collected_cookies_infobar_delegate.h" #include "chrome/browser/ui/collected_cookies_infobar_delegate.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/browser/ui/views/cookie_info_view.h" #include "chrome/browser/ui/views/cookie_info_view.h"
#include "chrome/common/pref_names.h" #include "chrome/common/pref_names.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
...@@ -247,15 +246,6 @@ bool CollectedCookiesViews::Cancel() { ...@@ -247,15 +246,6 @@ bool CollectedCookiesViews::Cancel() {
return true; return true;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView* CollectedCookiesViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(
widget,
web_contents_->GetBrowserContext());
}
ui::ModalType CollectedCookiesViews::GetModalType() const { ui::ModalType CollectedCookiesViews::GetModalType() const {
#if defined(USE_ASH) #if defined(USE_ASH)
return ui::MODAL_TYPE_CHILD; return ui::MODAL_TYPE_CHILD;
......
...@@ -51,8 +51,6 @@ class CollectedCookiesViews : public views::DialogDelegateView, ...@@ -51,8 +51,6 @@ class CollectedCookiesViews : public views::DialogDelegateView,
ui::DialogButton button) const OVERRIDE; ui::DialogButton button) const OVERRIDE;
virtual void DeleteDelegate() OVERRIDE; virtual void DeleteDelegate() OVERRIDE;
virtual bool Cancel() OVERRIDE; virtual bool Cancel() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
virtual ui::ModalType GetModalType() const OVERRIDE; virtual ui::ModalType GetModalType() const OVERRIDE;
// views::ButtonListener: // views::ButtonListener:
......
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
#include "chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h" #include "chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
...@@ -33,11 +32,10 @@ namespace { ...@@ -33,11 +32,10 @@ namespace {
class ConstrainedWebDialogDelegateViews class ConstrainedWebDialogDelegateViews
: public ConstrainedWebDialogDelegateBase { : public ConstrainedWebDialogDelegateBase {
public: public:
ConstrainedWebDialogDelegateViews( ConstrainedWebDialogDelegateViews(content::BrowserContext* browser_context,
content::BrowserContext* browser_context, WebDialogDelegate* delegate,
WebDialogDelegate* delegate, WebDialogWebContentsDelegate* tab_delegate,
WebDialogWebContentsDelegate* tab_delegate, views::WebView* view)
views::WebView* view)
: ConstrainedWebDialogDelegateBase( : ConstrainedWebDialogDelegateBase(
browser_context, delegate, tab_delegate), browser_context, delegate, tab_delegate),
view_(view), view_(view),
...@@ -130,13 +128,9 @@ class ConstrainedWebDialogDelegateViewViews ...@@ -130,13 +128,9 @@ class ConstrainedWebDialogDelegateViewViews
virtual views::View* GetContentsView() OVERRIDE { virtual views::View* GetContentsView() OVERRIDE {
return this; return this;
} }
// TODO(wittman): Remove this override once we move to the new style frame
// view on all dialogs.
virtual views::NonClientFrameView* CreateNonClientFrameView( virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE { views::Widget* widget) OVERRIDE {
return CreateConstrainedStyleNonClientFrameView( return views::DialogDelegate::CreateDialogFrameView(widget);
widget,
GetWebContents()->GetBrowserContext());
} }
virtual bool ShouldShowCloseButton() const OVERRIDE { virtual bool ShouldShowCloseButton() const OVERRIDE {
// No close button if the dialog doesn't want a title bar. // No close button if the dialog doesn't want a title bar.
...@@ -199,7 +193,8 @@ ConstrainedWebDialogDelegateViewViews::ConstrainedWebDialogDelegateViewViews( ...@@ -199,7 +193,8 @@ ConstrainedWebDialogDelegateViewViews::ConstrainedWebDialogDelegateViewViews(
AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE)); AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
} }
ConstrainedWebDialogDelegateViewViews::~ConstrainedWebDialogDelegateViewViews() { ConstrainedWebDialogDelegateViewViews::
~ConstrainedWebDialogDelegateViewViews() {
} }
ConstrainedWebDialogDelegate* CreateConstrainedWebDialog( ConstrainedWebDialogDelegate* CreateConstrainedWebDialog(
......
...@@ -138,13 +138,3 @@ views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog, ...@@ -138,13 +138,3 @@ views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
} }
return widget; return widget;
} }
views::NonClientFrameView* CreateConstrainedStyleNonClientFrameView(
views::Widget* widget,
content::BrowserContext* browser_context) {
bool force_opaque = true;
#if defined(USE_AURA)
force_opaque = false;
#endif
return views::DialogDelegate::CreateDialogFrameView(widget, force_opaque);
}
...@@ -7,15 +7,9 @@ ...@@ -7,15 +7,9 @@
#include "ui/gfx/native_widget_types.h" #include "ui/gfx/native_widget_types.h"
namespace content {
class BrowserContext;
}
namespace views { namespace views {
class DialogDelegate; class DialogDelegate;
class NonClientFrameView;
class Widget; class Widget;
class WidgetDelegate;
} }
namespace web_modal { namespace web_modal {
...@@ -38,8 +32,4 @@ void UpdateBrowserModalDialogPosition( ...@@ -38,8 +32,4 @@ void UpdateBrowserModalDialogPosition(
views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog, views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,
gfx::NativeWindow parent); gfx::NativeWindow parent);
views::NonClientFrameView* CreateConstrainedStyleNonClientFrameView(
views::Widget* widget,
content::BrowserContext* browser_context);
#endif // CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_VIEWS_H_ #endif // CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_VIEWS_H_
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "chrome/browser/download/download_danger_prompt.h" #include "chrome/browser/download/download_danger_prompt.h"
#include "chrome/browser/download/download_stats.h" #include "chrome/browser/download/download_stats.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
...@@ -58,10 +57,6 @@ class DownloadDangerPromptViews : public DownloadDangerPrompt, ...@@ -58,10 +57,6 @@ class DownloadDangerPromptViews : public DownloadDangerPrompt,
virtual bool Cancel() OVERRIDE; virtual bool Cancel() OVERRIDE;
virtual bool Accept() OVERRIDE; virtual bool Accept() OVERRIDE;
virtual bool Close() OVERRIDE; virtual bool Close() OVERRIDE;
// TODO(wittman): Remove this override once we move to the new style frame
// view on all dialogs.
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
virtual views::View* GetInitiallyFocusedView() OVERRIDE; virtual views::View* GetInitiallyFocusedView() OVERRIDE;
virtual views::View* GetContentsView() OVERRIDE; virtual views::View* GetContentsView() OVERRIDE;
virtual views::Widget* GetWidget() OVERRIDE; virtual views::Widget* GetWidget() OVERRIDE;
...@@ -79,7 +74,6 @@ class DownloadDangerPromptViews : public DownloadDangerPrompt, ...@@ -79,7 +74,6 @@ class DownloadDangerPromptViews : public DownloadDangerPrompt,
void RunDone(Action action); void RunDone(Action action);
content::DownloadItem* download_; content::DownloadItem* download_;
content::WebContents* web_contents_;
bool show_context_; bool show_context_;
OnDone done_; OnDone done_;
...@@ -92,7 +86,6 @@ DownloadDangerPromptViews::DownloadDangerPromptViews( ...@@ -92,7 +86,6 @@ DownloadDangerPromptViews::DownloadDangerPromptViews(
bool show_context, bool show_context,
const OnDone& done) const OnDone& done)
: download_(item), : download_(item),
web_contents_(web_contents),
show_context_(show_context), show_context_(show_context),
done_(done), done_(done),
contents_view_(NULL) { contents_view_(NULL) {
...@@ -210,14 +203,6 @@ bool DownloadDangerPromptViews::Close() { ...@@ -210,14 +203,6 @@ bool DownloadDangerPromptViews::Close() {
return true; return true;
} }
// TODO(wittman): Remove this override once we move to the new style frame
// view on all dialogs.
views::NonClientFrameView* DownloadDangerPromptViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(
widget, web_contents_->GetBrowserContext());
}
views::View* DownloadDangerPromptViews::GetInitiallyFocusedView() { views::View* DownloadDangerPromptViews::GetInitiallyFocusedView() {
return GetDialogClientView()->cancel_button(); return GetDialogClientView()->cancel_button();
} }
...@@ -299,7 +284,7 @@ base::string16 DownloadDangerPromptViews::GetMessageBody() const { ...@@ -299,7 +284,7 @@ base::string16 DownloadDangerPromptViews::GetMessageBody() const {
IDS_PROMPT_DANGEROUS_DOWNLOAD, IDS_PROMPT_DANGEROUS_DOWNLOAD,
download_->GetFileNameToReportUser().LossyDisplayName()); download_->GetFileNameToReportUser().LossyDisplayName());
} }
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL: // Fall through case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL: // Fall through
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT: case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST: { case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST: {
return l10n_util::GetStringFUTF16( return l10n_util::GetStringFUTF16(
......
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
#include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h" #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
...@@ -317,15 +316,6 @@ bool MediaGalleriesDialogViews::Accept() { ...@@ -317,15 +316,6 @@ bool MediaGalleriesDialogViews::Accept() {
return true; return true;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView* MediaGalleriesDialogViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(
widget,
controller_->web_contents()->GetBrowserContext());
}
void MediaGalleriesDialogViews::ButtonPressed(views::Button* sender, void MediaGalleriesDialogViews::ButtonPressed(views::Button* sender,
const ui::Event& event) { const ui::Event& event) {
confirm_available_ = true; confirm_available_ = true;
......
...@@ -47,8 +47,6 @@ class MediaGalleriesDialogViews : public MediaGalleriesDialog, ...@@ -47,8 +47,6 @@ class MediaGalleriesDialogViews : public MediaGalleriesDialog,
virtual views::View* CreateExtraView() OVERRIDE; virtual views::View* CreateExtraView() OVERRIDE;
virtual bool Cancel() OVERRIDE; virtual bool Cancel() OVERRIDE;
virtual bool Accept() OVERRIDE; virtual bool Accept() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
// views::ButtonListener implementation: // views::ButtonListener implementation:
virtual void ButtonPressed(views::Button* sender, virtual void ButtonPressed(views::Button* sender,
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.h" #include "chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
...@@ -274,16 +273,6 @@ bool MediaGalleriesScanResultDialogViews::Accept() { ...@@ -274,16 +273,6 @@ bool MediaGalleriesScanResultDialogViews::Accept() {
return true; return true;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView*
MediaGalleriesScanResultDialogViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(
widget,
controller_->web_contents()->GetBrowserContext());
}
void MediaGalleriesScanResultDialogViews::ButtonPressed( void MediaGalleriesScanResultDialogViews::ButtonPressed(
views::Button* sender, views::Button* sender,
const ui::Event& event) { const ui::Event& event) {
......
...@@ -47,8 +47,6 @@ class MediaGalleriesScanResultDialogViews ...@@ -47,8 +47,6 @@ class MediaGalleriesScanResultDialogViews
virtual ui::ModalType GetModalType() const OVERRIDE; virtual ui::ModalType GetModalType() const OVERRIDE;
virtual bool Cancel() OVERRIDE; virtual bool Cancel() OVERRIDE;
virtual bool Accept() OVERRIDE; virtual bool Accept() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
// views::ButtonListener implementation: // views::ButtonListener implementation:
virtual void ButtonPressed(views::Button* sender, virtual void ButtonPressed(views::Button* sender,
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "chrome/browser/password_manager/password_manager.h" #include "chrome/browser/password_manager/password_manager.h"
#include "chrome/browser/tab_contents/tab_util.h" #include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/browser/ui/views/login_view.h" #include "chrome/browser/ui/views/login_view.h"
#include "chrome/common/chrome_switches.h" #include "chrome/common/chrome_switches.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
...@@ -110,15 +109,6 @@ class LoginHandlerViews : public LoginHandler, ...@@ -110,15 +109,6 @@ class LoginHandlerViews : public LoginHandler,
return true; return true;
} }
// TODO(wittman): Remove this override once we move to the new style frame
// view on all dialogs.
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE {
return CreateConstrainedStyleNonClientFrameView(
widget,
GetWebContentsForLogin()->GetBrowserContext());
}
virtual views::View* GetInitiallyFocusedView() OVERRIDE { virtual views::View* GetInitiallyFocusedView() OVERRIDE {
return login_view_->GetInitiallyFocusedView(); return login_view_->GetInitiallyFocusedView();
} }
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "chrome/browser/ui/pdf/pdf_tab_helper.h" #include "chrome/browser/ui/pdf/pdf_tab_helper.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
...@@ -38,8 +37,6 @@ class PDFPasswordDialogViews : public views::DialogDelegate { ...@@ -38,8 +37,6 @@ class PDFPasswordDialogViews : public views::DialogDelegate {
// views::WidgetDelegate: // views::WidgetDelegate:
virtual views::View* GetInitiallyFocusedView() OVERRIDE; virtual views::View* GetInitiallyFocusedView() OVERRIDE;
virtual views::View* GetContentsView() OVERRIDE; virtual views::View* GetContentsView() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
virtual views::Widget* GetWidget() OVERRIDE; virtual views::Widget* GetWidget() OVERRIDE;
virtual const views::Widget* GetWidget() const OVERRIDE; virtual const views::Widget* GetWidget() const OVERRIDE;
virtual void DeleteDelegate() OVERRIDE; virtual void DeleteDelegate() OVERRIDE;
...@@ -50,7 +47,6 @@ class PDFPasswordDialogViews : public views::DialogDelegate { ...@@ -50,7 +47,6 @@ class PDFPasswordDialogViews : public views::DialogDelegate {
views::MessageBoxView* message_box_view_; views::MessageBoxView* message_box_view_;
views::Widget* dialog_; views::Widget* dialog_;
content::BrowserContext* browser_context_;
PasswordDialogClosedCallback callback_; PasswordDialogClosedCallback callback_;
...@@ -63,7 +59,6 @@ PDFPasswordDialogViews::PDFPasswordDialogViews( ...@@ -63,7 +59,6 @@ PDFPasswordDialogViews::PDFPasswordDialogViews(
const PasswordDialogClosedCallback& callback) const PasswordDialogClosedCallback& callback)
: message_box_view_(NULL), : message_box_view_(NULL),
dialog_(NULL), dialog_(NULL),
browser_context_(web_contents->GetBrowserContext()),
callback_(callback) { callback_(callback) {
views::MessageBoxView::InitParams init_params(prompt); views::MessageBoxView::InitParams init_params(prompt);
init_params.options = views::MessageBoxView::HAS_PROMPT_FIELD; init_params.options = views::MessageBoxView::HAS_PROMPT_FIELD;
...@@ -129,13 +124,6 @@ views::View* PDFPasswordDialogViews::GetContentsView() { ...@@ -129,13 +124,6 @@ views::View* PDFPasswordDialogViews::GetContentsView() {
return message_box_view_; return message_box_view_;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView* PDFPasswordDialogViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(widget, browser_context_);
}
views::Widget* PDFPasswordDialogViews::GetWidget() { views::Widget* PDFPasswordDialogViews::GetWidget() {
return message_box_view_->GetWidget(); return message_box_view_->GetWidget();
} }
......
...@@ -9,7 +9,6 @@ ...@@ -9,7 +9,6 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "chrome/browser/certificate_viewer.h" #include "chrome/browser/certificate_viewer.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
...@@ -238,16 +237,6 @@ bool SSLClientCertificateSelector::Accept() { ...@@ -238,16 +237,6 @@ bool SSLClientCertificateSelector::Accept() {
return false; return false;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView*
SSLClientCertificateSelector::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(
widget,
web_contents_->GetBrowserContext());
}
views::View* SSLClientCertificateSelector::GetInitiallyFocusedView() { views::View* SSLClientCertificateSelector::GetInitiallyFocusedView() {
return table_; return table_;
} }
......
...@@ -61,8 +61,6 @@ class SSLClientCertificateSelector : public SSLClientAuthObserver, ...@@ -61,8 +61,6 @@ class SSLClientCertificateSelector : public SSLClientAuthObserver,
virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE; virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
virtual bool Cancel() OVERRIDE; virtual bool Cancel() OVERRIDE;
virtual bool Accept() OVERRIDE; virtual bool Accept() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
virtual views::View* GetInitiallyFocusedView() OVERRIDE; virtual views::View* GetInitiallyFocusedView() OVERRIDE;
virtual views::View* CreateExtraView() OVERRIDE; virtual views::View* CreateExtraView() OVERRIDE;
virtual ui::ModalType GetModalType() const OVERRIDE; virtual ui::ModalType GetModalType() const OVERRIDE;
......
...@@ -9,7 +9,6 @@ ...@@ -9,7 +9,6 @@
#include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tab_modal_confirm_dialog_delegate.h" #include "chrome/browser/ui/tab_modal_confirm_dialog_delegate.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/common/chrome_switches.h" #include "chrome/common/chrome_switches.h"
#include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_host.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager.h"
...@@ -41,8 +40,7 @@ TabModalConfirmDialogViews::TabModalConfirmDialogViews( ...@@ -41,8 +40,7 @@ TabModalConfirmDialogViews::TabModalConfirmDialogViews(
TabModalConfirmDialogDelegate* delegate, TabModalConfirmDialogDelegate* delegate,
content::WebContents* web_contents) content::WebContents* web_contents)
: delegate_(delegate), : delegate_(delegate),
dialog_(NULL), dialog_(NULL) {
browser_context_(web_contents->GetBrowserContext()) {
views::MessageBoxView::InitParams init_params(delegate->GetDialogMessage()); views::MessageBoxView::InitParams init_params(delegate->GetDialogMessage());
init_params.inter_row_vertical_spacing = init_params.inter_row_vertical_spacing =
views::kUnrelatedControlVerticalSpacing; views::kUnrelatedControlVerticalSpacing;
...@@ -124,13 +122,6 @@ views::View* TabModalConfirmDialogViews::GetContentsView() { ...@@ -124,13 +122,6 @@ views::View* TabModalConfirmDialogViews::GetContentsView() {
return message_box_view_; return message_box_view_;
} }
// TODO(wittman): Remove this override once we move to the new style frame view
// on all dialogs.
views::NonClientFrameView* TabModalConfirmDialogViews::CreateNonClientFrameView(
views::Widget* widget) {
return CreateConstrainedStyleNonClientFrameView(widget, browser_context_);
}
views::Widget* TabModalConfirmDialogViews::GetWidget() { views::Widget* TabModalConfirmDialogViews::GetWidget() {
return message_box_view_->GetWidget(); return message_box_view_->GetWidget();
} }
......
...@@ -14,7 +14,6 @@ ...@@ -14,7 +14,6 @@
namespace content { namespace content {
class WebContents; class WebContents;
class BrowserContext;
} }
namespace views { namespace views {
...@@ -44,8 +43,6 @@ class TabModalConfirmDialogViews : public TabModalConfirmDialog, ...@@ -44,8 +43,6 @@ class TabModalConfirmDialogViews : public TabModalConfirmDialog,
// views::WidgetDelegate: // views::WidgetDelegate:
virtual views::View* GetContentsView() OVERRIDE; virtual views::View* GetContentsView() OVERRIDE;
virtual views::NonClientFrameView* CreateNonClientFrameView(
views::Widget* widget) OVERRIDE;
virtual views::Widget* GetWidget() OVERRIDE; virtual views::Widget* GetWidget() OVERRIDE;
virtual const views::Widget* GetWidget() const OVERRIDE; virtual const views::Widget* GetWidget() const OVERRIDE;
virtual void DeleteDelegate() OVERRIDE; virtual void DeleteDelegate() OVERRIDE;
...@@ -70,7 +67,6 @@ class TabModalConfirmDialogViews : public TabModalConfirmDialog, ...@@ -70,7 +67,6 @@ class TabModalConfirmDialogViews : public TabModalConfirmDialog,
views::MessageBoxView* message_box_view_; views::MessageBoxView* message_box_view_;
views::Widget* dialog_; views::Widget* dialog_;
content::BrowserContext* browser_context_;
DISALLOW_COPY_AND_ASSIGN(TabModalConfirmDialogViews); DISALLOW_COPY_AND_ASSIGN(TabModalConfirmDialogViews);
}; };
......
...@@ -51,8 +51,7 @@ class ConstrainedWebDialogDelegate { ...@@ -51,8 +51,7 @@ class ConstrainedWebDialogDelegate {
// //
// Since the web contents modal dialog requires platform-specific delegate // Since the web contents modal dialog requires platform-specific delegate
// implementations, this class is just a factory stub. // implementations, this class is just a factory stub.
class ConstrainedWebDialogUI class ConstrainedWebDialogUI : public content::WebUIController {
: public content::WebUIController {
public: public:
explicit ConstrainedWebDialogUI(content::WebUI* web_ui); explicit ConstrainedWebDialogUI(content::WebUI* web_ui);
virtual ~ConstrainedWebDialogUI(); virtual ~ConstrainedWebDialogUI();
......
...@@ -10,14 +10,11 @@ ...@@ -10,14 +10,11 @@
#include "ui/views/bubble/bubble_border.h" #include "ui/views/bubble/bubble_border.h"
#include "ui/views/bubble/bubble_frame_view.h" #include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/controls/button/label_button.h" #include "ui/views/controls/button/label_button.h"
#include "ui/views/corewm/shadow_types.h"
#include "ui/views/widget/widget.h" #include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_observer.h" #include "ui/views/widget/widget_observer.h"
#include "ui/views/window/dialog_client_view.h" #include "ui/views/window/dialog_client_view.h"
#if defined(USE_AURA)
#include "ui/views/corewm/shadow_types.h"
#endif
namespace views { namespace views {
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
...@@ -158,35 +155,19 @@ NonClientFrameView* DialogDelegate::CreateNonClientFrameView(Widget* widget) { ...@@ -158,35 +155,19 @@ NonClientFrameView* DialogDelegate::CreateNonClientFrameView(Widget* widget) {
// static // static
NonClientFrameView* DialogDelegate::CreateDialogFrameView(Widget* widget) { NonClientFrameView* DialogDelegate::CreateDialogFrameView(Widget* widget) {
return CreateDialogFrameView(widget, false);
}
// static
NonClientFrameView* DialogDelegate::CreateDialogFrameView(
Widget* widget,
bool force_opaque_border) {
BubbleFrameView* frame = new BubbleFrameView(gfx::Insets()); BubbleFrameView* frame = new BubbleFrameView(gfx::Insets());
const SkColor color = widget->GetNativeTheme()->GetSystemColor( const SkColor color = widget->GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_DialogBackground); ui::NativeTheme::kColorId_DialogBackground);
if (force_opaque_border) { frame->SetBubbleBorder(scoped_ptr<BubbleBorder>(new BubbleBorder(
frame->SetBubbleBorder(scoped_ptr<BubbleBorder>(new BubbleBorder( BubbleBorder::FLOAT, BubbleBorder::SMALL_SHADOW, color)));
BubbleBorder::NONE, BubbleBorder::NO_SHADOW_OPAQUE_BORDER, color)));
} else {
frame->SetBubbleBorder(scoped_ptr<BubbleBorder>(new BubbleBorder(
BubbleBorder::FLOAT, BubbleBorder::SMALL_SHADOW, color)));
}
DialogDelegate* delegate = widget->widget_delegate()->AsDialogDelegate(); DialogDelegate* delegate = widget->widget_delegate()->AsDialogDelegate();
if (delegate) { if (delegate) {
View* titlebar_view = delegate->CreateTitlebarExtraView(); View* titlebar_view = delegate->CreateTitlebarExtraView();
if (titlebar_view) if (titlebar_view)
frame->SetTitlebarExtraView(titlebar_view); frame->SetTitlebarExtraView(titlebar_view);
} }
if (force_opaque_border)
widget->set_frame_type(views::Widget::FRAME_TYPE_FORCE_CUSTOM);
#if defined(USE_AURA)
// TODO(msw): Add a matching shadow type and remove the bubble frame border? // TODO(msw): Add a matching shadow type and remove the bubble frame border?
corewm::SetShadowType(widget->GetNativeWindow(), corewm::SHADOW_TYPE_NONE); corewm::SetShadowType(widget->GetNativeWindow(), corewm::SHADOW_TYPE_NONE);
#endif
return frame; return frame;
} }
......
...@@ -91,14 +91,6 @@ class VIEWS_EXPORT DialogDelegate : public ui::DialogModel, ...@@ -91,14 +91,6 @@ class VIEWS_EXPORT DialogDelegate : public ui::DialogModel,
// Create a frame view using the new dialog style. // Create a frame view using the new dialog style.
static NonClientFrameView* CreateDialogFrameView(Widget* widget); static NonClientFrameView* CreateDialogFrameView(Widget* widget);
// The semi-transparent border and shadow of the new style frame view does not
// work on child windows under Views/Win32. This is a kludge to get a
// reasonable-looking opaque border for the dialog. Note that this does not
// support arrows.
//
// TODO(wittman): Remove once WinAura is in place.
static NonClientFrameView* CreateDialogFrameView(Widget* widget,
bool force_opaque_border);
// Returns whether this particular dialog should use the new dialog style. // Returns whether this particular dialog should use the new dialog style.
virtual bool UseNewStyleForThisDialog() const; virtual bool UseNewStyleForThisDialog() const;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment