Commit 99418069 authored by chinsenj's avatar chinsenj Committed by Chromium LUCI CQ

capture_mode: Record metric for ctrl + overview accelerator.

Currently ctrl + overview calls
CaptureModeController::CaptureScreenshotsOfALlDisplays() but this does
not record any metrics.

This CL changes it so when CaptureScreenshotsOfALlDisplays() is called,
it records to Ash.CaptureModeController.EntryPoint and
Ash.CaptureModeController.CaptureConfiguration.

Test: manual
Bug: 1140182
Change-Id: I0671ba00ef2ddb8b75c502f8495ed6259b78a1b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637778Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Reviewed-by: default avatarJeremy Chinsen <chinsenj@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845198}
parent 8df84f77
...@@ -421,6 +421,11 @@ void CaptureModeController::CaptureScreenshotsOfAllDisplays() { ...@@ -421,6 +421,11 @@ void CaptureModeController::CaptureScreenshotsOfAllDisplays() {
: BuildImagePathForDisplay(display_index)); : BuildImagePathForDisplay(display_index));
++display_index; ++display_index;
} }
// Since this doesn't create a capture mode session, log metrics here.
RecordCaptureModeEntryType(CaptureModeEntryType::kCaptureAllDisplays);
RecordCaptureModeConfiguration(CaptureModeType::kImage,
CaptureModeSource::kFullscreen);
} }
void CaptureModeController::PerformCapture() { void CaptureModeController::PerformCapture() {
......
...@@ -65,7 +65,8 @@ enum class CaptureModeEntryType { ...@@ -65,7 +65,8 @@ enum class CaptureModeEntryType {
kStylusPalette, kStylusPalette,
kPowerMenu, kPowerMenu,
kSnipKey, kSnipKey,
kMaxValue = kSnipKey, kCaptureAllDisplays,
kMaxValue = kCaptureAllDisplays,
}; };
// Enumeration of quick actions on screenshot notification. Note that these // Enumeration of quick actions on screenshot notification. Note that these
......
...@@ -9549,6 +9549,7 @@ Called by update_bad_message_reasons.py.--> ...@@ -9549,6 +9549,7 @@ Called by update_bad_message_reasons.py.-->
<int value="3" label="Stylus Palette"/> <int value="3" label="Stylus Palette"/>
<int value="4" label="Power Menu"/> <int value="4" label="Power Menu"/>
<int value="5" label="Snip Key"/> <int value="5" label="Snip Key"/>
<int value="6" label="Full Screenshot Accelerator"/>
</enum> </enum>
<enum name="CapturePixelFormat"> <enum name="CapturePixelFormat">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment