cc: Avoid redundant SQS setting and locals.

BUG=

Review URL: https://codereview.chromium.org/384643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282430 0039d316-1c4b-4281-b951-d872f2087c98
parent f37f04f6
...@@ -154,7 +154,6 @@ void PictureLayerImpl::AppendQuads( ...@@ -154,7 +154,6 @@ void PictureLayerImpl::AppendQuads(
SharedQuadState* shared_quad_state = SharedQuadState* shared_quad_state =
render_pass->CreateAndAppendSharedQuadState(); render_pass->CreateAndAppendSharedQuadState();
PopulateSharedQuadState(shared_quad_state);
shared_quad_state->SetAll(scaled_draw_transform, shared_quad_state->SetAll(scaled_draw_transform,
scaled_content_bounds, scaled_content_bounds,
scaled_visible_content_rect, scaled_visible_content_rect,
...@@ -164,8 +163,6 @@ void PictureLayerImpl::AppendQuads( ...@@ -164,8 +163,6 @@ void PictureLayerImpl::AppendQuads(
blend_mode(), blend_mode(),
sorting_context_id_); sorting_context_id_);
gfx::Rect rect = scaled_visible_content_rect;
if (current_draw_mode_ == DRAW_MODE_RESOURCELESS_SOFTWARE) { if (current_draw_mode_ == DRAW_MODE_RESOURCELESS_SOFTWARE) {
AppendDebugBorderQuad( AppendDebugBorderQuad(
render_pass, render_pass,
...@@ -175,16 +172,16 @@ void PictureLayerImpl::AppendQuads( ...@@ -175,16 +172,16 @@ void PictureLayerImpl::AppendQuads(
DebugColors::DirectPictureBorderColor(), DebugColors::DirectPictureBorderColor(),
DebugColors::DirectPictureBorderWidth(layer_tree_impl())); DebugColors::DirectPictureBorderWidth(layer_tree_impl()));
gfx::Rect geometry_rect = rect; gfx::Rect geometry_rect = scaled_visible_content_rect;
gfx::Rect opaque_rect = contents_opaque() ? geometry_rect : gfx::Rect(); gfx::Rect opaque_rect = contents_opaque() ? geometry_rect : gfx::Rect();
gfx::Rect visible_geometry_rect = occlusion_tracker.UnoccludedContentRect( gfx::Rect visible_geometry_rect = occlusion_tracker.UnoccludedContentRect(
geometry_rect, scaled_draw_transform); geometry_rect, scaled_draw_transform);
if (visible_geometry_rect.IsEmpty()) if (visible_geometry_rect.IsEmpty())
return; return;
gfx::Size texture_size = rect.size(); gfx::Size texture_size = scaled_visible_content_rect.size();
gfx::RectF texture_rect = gfx::RectF(texture_size); gfx::RectF texture_rect = gfx::RectF(texture_size);
gfx::Rect quad_content_rect = rect; gfx::Rect quad_content_rect = scaled_visible_content_rect;
PictureDrawQuad* quad = PictureDrawQuad* quad =
render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>(); render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
...@@ -207,7 +204,10 @@ void PictureLayerImpl::AppendQuads( ...@@ -207,7 +204,10 @@ void PictureLayerImpl::AppendQuads(
if (ShowDebugBorders()) { if (ShowDebugBorders()) {
for (PictureLayerTilingSet::CoverageIterator iter( for (PictureLayerTilingSet::CoverageIterator iter(
tilings_.get(), max_contents_scale, rect, ideal_contents_scale_); tilings_.get(),
max_contents_scale,
scaled_visible_content_rect,
ideal_contents_scale_);
iter; iter;
++iter) { ++iter) {
SkColor color; SkColor color;
...@@ -257,8 +257,10 @@ void PictureLayerImpl::AppendQuads( ...@@ -257,8 +257,10 @@ void PictureLayerImpl::AppendQuads(
size_t missing_tile_count = 0u; size_t missing_tile_count = 0u;
size_t on_demand_missing_tile_count = 0u; size_t on_demand_missing_tile_count = 0u;
for (PictureLayerTilingSet::CoverageIterator iter( for (PictureLayerTilingSet::CoverageIterator iter(tilings_.get(),
tilings_.get(), max_contents_scale, rect, ideal_contents_scale_); max_contents_scale,
scaled_visible_content_rect,
ideal_contents_scale_);
iter; iter;
++iter) { ++iter) {
gfx::Rect geometry_rect = iter.geometry_rect(); gfx::Rect geometry_rect = iter.geometry_rect();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment