Commit 997bc312 authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Revert "Report crash-dump for GetFontFallbacks that succeed on Windows"

This reverts commit 27ed0337.

Reason for revert: Top crasher on Windows.

Original change's description:
> Report crash-dump for GetFontFallbacks that succeed on Windows
> 
> On Windows, ShapeRuns(...) is shaping the text by trying:
>   PrimaryFont
>   GetFontFallback(...) : using DWrite
>   GetFontFallbacks(...) : using registry keys (Font Linking)
> 
> The GetFontFallbacks function is deprecated and should be
> remove. There is still a long tail of cases that succeed
> only with the use of that mechanism. This CL is making
> these cases to be reported as a crash to be analyzed
> before removing the code. The goal is to avoid breaking
> the text rendering even for a small population.
> 
> R=​robliao@chromium.org
> 
> Bug: 995789
> Change-Id: I381753ed3985779cd34dae58a34f523c2f215c9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049126
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741606}

TBR=robliao@chromium.org,etienneb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 995789
Change-Id: Ibd4e3a1dd4fadb9178511a0cab38200c8fd4ade4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068830Reviewed-by: default avatarEtienne Bergeron <etienneb@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744023}
parent 129555c1
......@@ -10,7 +10,6 @@
#include "base/command_line.h"
#include "base/containers/mru_cache.h"
#include "base/containers/span.h"
#include "base/debug/dump_without_crashing.h"
#include "base/feature_list.h"
#include "base/hash/hash.h"
#include "base/i18n/base_i18n_switches.h"
......@@ -2113,16 +2112,6 @@ void RenderTextHarfBuzz::ShapeRuns(
TRACE_STR_COPY(font_name.c_str()),
"primary_font_name", primary_font.GetFontName());
RecordShapeRunsFallback(ShapeRunFallback::FALLBACKS);
#if defined(OS_WIN)
// Resolving fallback fonts using the registry keys on windows will be
// deprecated and removed (see: http://crbug.com/995789). The crashes
// reported here should be fixed before deprecating the code.
static bool is_first_crash = true;
if (is_first_crash) {
is_first_crash = false;
base::debug::DumpWithoutCrashing();
}
#endif
return;
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment