Commit 997d7a3f authored by raymes@chromium.org's avatar raymes@chromium.org

Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1...

Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/)

Reason for revert:
Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608

Original issue's description:
> Fix RemoteFrame detachment to signal its client.
> 
> We were seeing crashes in checkFrameCountConsistency() because during
> RemoteFrame detachment the client was not getting signalled to modify
> the frame tree, resulting in inconsistent state. This CL corrects that
> problem.
> 
> BUG=430972
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987

TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=430972

Review URL: https://codereview.chromium.org/699053004

git-svn-id: svn://svn.chromium.org/blink/trunk@185015 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 44985bbb
......@@ -14,7 +14,6 @@
#include "platform/exported/WrappedResourceRequest.h"
#include "platform/weborigin/SecurityOrigin.h"
#include "platform/weborigin/SecurityPolicy.h"
#include "public/web/WebRemoteFrameClient.h"
#include "web/WebInputEventConversion.h"
#include "web/WebLocalFrameImpl.h"
#include "web/WebRemoteFrameImpl.h"
......@@ -28,17 +27,7 @@ RemoteFrameClientImpl::RemoteFrameClientImpl(WebRemoteFrameImpl* webFrame)
void RemoteFrameClientImpl::detached()
{
// Alert the client that the frame is being detached.
RefPtrWillBeRawPtr<WebRemoteFrameImpl> protector(m_webFrame);
WebRemoteFrameClient* client = m_webFrame->client();
if (!client)
return;
client->frameDetached();
// Clear our reference to RemoteFrame at the very end, in case the client
// refers to it.
m_webFrame->setCoreFrame(nullptr);
// FIXME: Implement.
}
Frame* RemoteFrameClientImpl::opener() const
......
......@@ -12,7 +12,6 @@ namespace blink {
class WebInputEvent;
class WebLocalFrame;
class WebRemoteFrame;
struct WebRect;
class WebRemoteFrameClient {
public:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment