Commit 9985cbab authored by Robert Sesek's avatar Robert Sesek Committed by Commit Bot

apple: Convert GN libs lists to frameworks in //base.

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: 1052560
Change-Id: Icb922242c8dbcfc9c4be81b355ca83c1aedd1c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276315
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784205}
parent 6a309aad
...@@ -2385,7 +2385,7 @@ component("i18n") { ...@@ -2385,7 +2385,7 @@ component("i18n") {
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (is_mac) { if (is_mac) {
libs = [ "CoreFoundation.framework" ] frameworks = [ "CoreFoundation.framework" ]
} }
} }
...@@ -3166,7 +3166,7 @@ test("base_unittests") { ...@@ -3166,7 +3166,7 @@ test("base_unittests") {
if (is_mac) { if (is_mac) {
sources += [ "message_loop/message_pump_kqueue_unittest.cc" ] sources += [ "message_loop/message_pump_kqueue_unittest.cc" ]
libs = [ frameworks = [
"CoreFoundation.framework", "CoreFoundation.framework",
"Foundation.framework", "Foundation.framework",
] ]
......
...@@ -192,7 +192,7 @@ static_library("test_support") { ...@@ -192,7 +192,7 @@ static_library("test_support") {
} }
if (is_mac) { if (is_mac) {
libs = [ "AppKit.framework" ] frameworks = [ "AppKit.framework" ]
sources += [ sources += [
"mock_chrome_application_mac.h", "mock_chrome_application_mac.h",
"mock_chrome_application_mac.mm", "mock_chrome_application_mac.mm",
...@@ -525,7 +525,7 @@ if (is_ios) { ...@@ -525,7 +525,7 @@ if (is_ios) {
":google_test_runner_shared_headers", ":google_test_runner_shared_headers",
"//base", "//base",
] ]
libs = [ "UIKit.framework" ] frameworks = [ "UIKit.framework" ]
configs += [ configs += [
"//build/config/compiler:enable_arc", "//build/config/compiler:enable_arc",
"//build/config/ios:xctest_config", "//build/config/ios:xctest_config",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment