Commit 99947195 authored by dpranke's avatar dpranke Committed by Commit bot

Revert of Ensure that builders that use goma strip absolute paths by default....

Revert of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2837863005/ )

Reason for revert:
Reverting in case this is related to the goma errors in https://crbug.com/716089

Original issue's description:
> Ensure that builders that use goma strip absolute paths by default.
>
> This CL tweaks the MB configs so that any builder that is using goma
> also sets strip_absolute_paths_from_debug_symbols_by_default=true.
> This helps ensure that we get the best goma cache hit rate possible.
> We don't just make the default equal to use_goma=true because doing
> so may make it harder for devs to debug binaries, and we want devs
> to be able to both debug binaries and use goma by default; the
> tradeoff is that their builds are slightly slower.
>
> R=thakis@chromium.org, jochen@chromium.org
> BUG=603286, 712790
>
> Review-Url: https://codereview.chromium.org/2837863005
> Cr-Commit-Position: refs/heads/master@{#467574}
> Committed: https://chromium.googlesource.com/chromium/src/+/050dbe550d14e99ad4e83093d4f4e79642b9edc3

TBR=jochen@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603286, 712790

Review-Url: https://codereview.chromium.org/2843403004
Cr-Commit-Position: refs/heads/master@{#467769}
parent 5cf597d4
......@@ -94,9 +94,7 @@ declare_args() {
# branches)
optimize_for_fuzzing = false
# Optimize symbol files for maximizing goma cache hit rate. This isn't
# on by default when goma is enabled because setting this to true may make
# it harder to debug binaries.
# Optimize symbol files for maximizing goma cache hit rate.
strip_absolute_paths_from_debug_symbols = false
}
......
......@@ -1729,10 +1729,7 @@
'goma': {
# The MB code will properly escape goma_dir if necessary in the GYP
# code path; the GN code path needs no escaping.
# We also set strip_absolute_paths to ensure that we can get deterministic
# builds. This isn't just on by default when goma is on so that devs
# can do goma builds but still be able to debug by default.
'gn_args': 'use_goma=true strip_absolute_paths_from_debug_symbols=true',
'gn_args': 'use_goma=true',
},
'gpu_fyi_tests': {
......@@ -1783,7 +1780,7 @@
},
'minimal_symbols': {
'gn_args': 'symbol_level=1',
'gn_args': 'symbol_level=1 strip_absolute_paths_from_debug_symbols=true',
},
'mipsel': {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment