Commit 99ab2289 authored by Bailey Berro's avatar Bailey Berro Committed by Commit Bot

Fix assertion logic in SmbCredentialDialog

- Previously the assertion logic in SmbCredentialDialog treated 0 as an
invalid mount_id. Since 0 is a valid mount_id, we want to ensure that
the assert is only verifying that mount_id is a number.


Bug: 928933
Change-Id: I165f6696252265a66af7de488a624d6fc41e5d22
Reviewed-on: https://chromium-review.googlesource.com/c/1455498
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629453}
parent 76df0d95
......@@ -44,7 +44,7 @@ Polymer({
var args = JSON.parse(dialogArgs);
assert(args);
assert(args.path);
assert(args.mid);
assert(typeof args.mid === 'number');
this.sharePath_ = args.path;
this.mountId_ = args.mid;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment