[CrOS Settings] Remove SettingsPageVisibility and SettingsUserAction.

We've simplified the design of our metrics collection, and these are no
longer needed

Fixed: 1047062
Change-Id: I60bf78c68b84a7a98b7e1bbb59649ac367517727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044436
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740494}

chrome/browser/ui/BUILD.gn

@@ -1995,8 +1995,6 @@ jumbo_static_library("ui") {
       "webui/settings/chromeos/plugin_vm_handler.h",
       "webui/settings/chromeos/pref_names.cc",
       "webui/settings/chromeos/pref_names.h",
-      "webui/settings/chromeos/search/settings_user_action.cc",
-      "webui/settings/chromeos/search/settings_user_action.h",
       "webui/settings/chromeos/search/settings_user_action_tracker.cc",
       "webui/settings/chromeos/search/settings_user_action_tracker.h",
       "webui/settings/chromeos/wallpaper_handler.cc",

chrome/browser/ui/webui/settings/chromeos/search/search.mojom

@@ -4,13 +4,6 @@
 
 module chromeos.settings.mojom;
 
-// Types of visibility which apply to the Chrome OS settings window.
-enum SettingsPageVisibility {
-  kVisibleAndFocused,
-  kVisibleAndUnfocused,
-  kHidden
-};
-
 // Records user actions within OS settings.
 interface UserActionRecorder {
   // Records that the settings window has been focused.

chrome/browser/ui/webui/settings/chromeos/search/settings_user_action.cc

-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/ui/webui/settings/chromeos/search/settings_user_action.h"
-
-#include "base/logging.h"
-
-namespace chromeos {
-namespace settings {
-
-// SettingsUserAction:
-
-SettingsUserAction::SettingsUserAction(Type type) : type_(type) {}
-
-SettingsUserAction::SettingsUserAction(const SettingsUserAction& other) =
-    default;
-
-SettingsUserAction& SettingsUserAction::operator=(
-    const SettingsUserAction& other) = default;
-
-SettingsUserAction::~SettingsUserAction() = default;
-
-// SettingsClickAction:
-
-SettingsClickAction::SettingsClickAction() : SettingsUserAction(Type::kClick) {}
-
-SettingsClickAction::SettingsClickAction(const SettingsClickAction& other) =
-    default;
-
-SettingsClickAction& SettingsClickAction::operator=(
-    const SettingsClickAction& other) = default;
-
-SettingsClickAction::~SettingsClickAction() = default;
-
-// SettingsNavigationAction:
-
-SettingsNavigationAction::SettingsNavigationAction()
-    : SettingsUserAction(Type::kNavigation) {}
-
-SettingsNavigationAction::SettingsNavigationAction(
-    const SettingsNavigationAction& other) = default;
-
-SettingsNavigationAction& SettingsNavigationAction::operator=(
-    const SettingsNavigationAction& other) = default;
-
-SettingsNavigationAction::~SettingsNavigationAction() = default;
-
-// SettingsVisibilityChangeAction:
-
-SettingsVisibilityChangeAction::SettingsVisibilityChangeAction(
-    mojom::SettingsPageVisibility page_visibility)
-    : SettingsUserAction(Type::kVisibilityChange),
-      page_visibility_(page_visibility) {}
-
-SettingsVisibilityChangeAction::SettingsVisibilityChangeAction(
-    const SettingsVisibilityChangeAction& other) = default;
-
-SettingsVisibilityChangeAction& SettingsVisibilityChangeAction::operator=(
-    const SettingsVisibilityChangeAction& other) = default;
-
-SettingsVisibilityChangeAction::~SettingsVisibilityChangeAction() = default;
-
-// SettingsSearchAction:
-
-SettingsSearchAction::SettingsSearchAction(const std::string& search_query)
-    : SettingsUserAction(Type::kSearch), search_query_(search_query) {}
-
-SettingsSearchAction::SettingsSearchAction(const SettingsSearchAction& other) =
-    default;
-
-SettingsSearchAction& SettingsSearchAction::operator=(
-    const SettingsSearchAction& other) = default;
-
-SettingsSearchAction::~SettingsSearchAction() = default;
-
-// SettingsChangeAction:
-
-SettingsChangeAction::SettingsChangeAction()
-    : SettingsUserAction(Type::kSettingChange) {}
-
-SettingsChangeAction::SettingsChangeAction(const SettingsChangeAction& other) =
-    default;
-
-SettingsChangeAction& SettingsChangeAction::operator=(
-    const SettingsChangeAction& other) = default;
-
-SettingsChangeAction::~SettingsChangeAction() = default;
-
-}  // namespace settings
-}  // namespace chromeos

chrome/browser/ui/webui/settings/chromeos/search/settings_user_action.h

-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_SETTINGS_USER_ACTION_H_
-#define CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_SETTINGS_USER_ACTION_H_
-
-#include <string>
-
-#include "base/time/time.h"
-#include "chrome/browser/ui/webui/settings/chromeos/search/search.mojom.h"
-
-namespace chromeos {
-namespace settings {
-
-// An action taken by a user in Chrome OS settings.
-class SettingsUserAction {
- public:
-  enum class Type {
-    kClick,
-    kNavigation,
-    kVisibilityChange,
-    kSearch,
-    kSettingChange
-  };
-
-  SettingsUserAction(const SettingsUserAction& other);
-  SettingsUserAction& operator=(const SettingsUserAction& other);
-
-  ~SettingsUserAction();
-
-  Type type() const { return type_; }
-  base::Time timestamp() const { return timestamp_; }
-
- protected:
-  explicit SettingsUserAction(Type type);
-
- private:
-  Type type_;
-  base::Time timestamp_ = base::Time::Now();
-};
-
-// A click action taken by a user in Chrome OS settings.
-class SettingsClickAction : public SettingsUserAction {
- public:
-  SettingsClickAction();
-  SettingsClickAction(const SettingsClickAction& other);
-  SettingsClickAction& operator=(const SettingsClickAction& other);
-  ~SettingsClickAction();
-};
-
-// A navigation action taken by a user in Chrome OS settings.
-class SettingsNavigationAction : public SettingsUserAction {
- public:
-  SettingsNavigationAction();
-  SettingsNavigationAction(const SettingsNavigationAction& other);
-  SettingsNavigationAction& operator=(const SettingsNavigationAction& other);
-  ~SettingsNavigationAction();
-};
-
-// A visibility change action taken by a user in Chrome OS settings.
-class SettingsVisibilityChangeAction : public SettingsUserAction {
- public:
-  explicit SettingsVisibilityChangeAction(
-      mojom::SettingsPageVisibility page_visibility);
-  SettingsVisibilityChangeAction(const SettingsVisibilityChangeAction& other);
-  SettingsVisibilityChangeAction& operator=(
-      const SettingsVisibilityChangeAction& other);
-  ~SettingsVisibilityChangeAction();
-
-  mojom::SettingsPageVisibility page_visibility() const {
-    return page_visibility_;
-  }
-
- private:
-  mojom::SettingsPageVisibility page_visibility_;
-};
-
-// A search action taken by a user in Chrome OS settings.
-class SettingsSearchAction : public SettingsUserAction {
- public:
-  explicit SettingsSearchAction(const std::string& search_query);
-  SettingsSearchAction(const SettingsSearchAction& other);
-  SettingsSearchAction& operator=(const SettingsSearchAction& other);
-  ~SettingsSearchAction();
-
-  const std::string& search_query() const { return search_query_; }
-
- private:
-  std::string search_query_;
-};
-
-// A settings change action taken by a user in Chrome OS settings.
-class SettingsChangeAction : public SettingsUserAction {
- public:
-  SettingsChangeAction();
-  SettingsChangeAction(const SettingsChangeAction& other);
-  SettingsChangeAction& operator=(const SettingsChangeAction& other);
-  ~SettingsChangeAction();
-};
-
-}  // namespace settings
-}  // namespace chromeos
-
-#endif  // CHROME_BROWSER_UI_WEBUI_SETTINGS_CHROMEOS_SEARCH_SETTINGS_USER_ACTION_H_