Commit 99c6b47d authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot

Retire ScopedObserver in /chrome/browser/ui/views/desktop_capture.

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=ellyjones@chromium.org

Bug: 1145565
Change-Id: Ie6262d31836393d9c8bdbf0cc684564a073792b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547962
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828971}
parent 876c8e24
...@@ -30,7 +30,7 @@ std::unique_ptr<views::View> DesktopMediaListController::CreateView( ...@@ -30,7 +30,7 @@ std::unique_ptr<views::View> DesktopMediaListController::CreateView(
auto view = std::make_unique<DesktopMediaListView>( auto view = std::make_unique<DesktopMediaListView>(
this, generic_style, single_style, accessible_name); this, generic_style, single_style, accessible_name);
view_ = view.get(); view_ = view.get();
view_observer_.Add(view_); view_observations_.AddObservation(view_);
return view; return view;
} }
...@@ -40,7 +40,7 @@ std::unique_ptr<views::View> DesktopMediaListController::CreateTabListView( ...@@ -40,7 +40,7 @@ std::unique_ptr<views::View> DesktopMediaListController::CreateTabListView(
auto view = std::make_unique<DesktopMediaTabList>(this, accessible_name); auto view = std::make_unique<DesktopMediaTabList>(this, accessible_name);
view_ = view.get(); view_ = view.get();
view_observer_.Add(view_); view_observations_.AddObservation(view_);
return view; return view;
} }
...@@ -147,6 +147,6 @@ void DesktopMediaListController::OnSourceThumbnailChanged( ...@@ -147,6 +147,6 @@ void DesktopMediaListController::OnSourceThumbnailChanged(
} }
void DesktopMediaListController::OnViewIsDeleting(views::View* view) { void DesktopMediaListController::OnViewIsDeleting(views::View* view) {
view_observer_.Remove(view); view_observations_.RemoveObservation(view);
view_ = nullptr; view_ = nullptr;
} }
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include <memory> #include <memory>
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
#include "base/scoped_observer.h" #include "base/scoped_multi_source_observation.h"
#include "chrome/browser/media/webrtc/desktop_media_list.h" #include "chrome/browser/media/webrtc/desktop_media_list.h"
#include "chrome/browser/media/webrtc/desktop_media_list_observer.h" #include "chrome/browser/media/webrtc/desktop_media_list_observer.h"
#include "chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h" #include "chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h"
...@@ -119,7 +119,8 @@ class DesktopMediaListController : public DesktopMediaListObserver, ...@@ -119,7 +119,8 @@ class DesktopMediaListController : public DesktopMediaListObserver,
DesktopMediaPickerDialogView* dialog_; DesktopMediaPickerDialogView* dialog_;
std::unique_ptr<DesktopMediaList> media_list_; std::unique_ptr<DesktopMediaList> media_list_;
ListView* view_ = nullptr; ListView* view_ = nullptr;
ScopedObserver<views::View, views::ViewObserver> view_observer_{this}; base::ScopedMultiSourceObservation<views::View, views::ViewObserver>
view_observations_{this};
base::WeakPtrFactory<DesktopMediaListController> weak_factory_{this}; base::WeakPtrFactory<DesktopMediaListController> weak_factory_{this};
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment