Commit 99f8fc3b authored by Yunke Zhou's avatar Yunke Zhou Committed by Commit Bot

Oobe: update strings for user creation screen in add person flow

Bug: 1127546
Change-Id: Ifc37a278a860a0443bfa961f565de8a074a32af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410071Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#806938}
parent a326c157
......@@ -762,6 +762,12 @@
<message name="IDS_OOBE_USER_CREATION_SUBTITLE" desc="Subtitle of the screen which allows users to choose whom the device is set up for.">
You can always add more people after setup. Each person can personalize their account and keep data private.
</message>
<message name="IDS_OOBE_USER_CREATION_ADD_PERSON_TITLE" desc="Title of the screen which allows users to add person to the device.">
Who would you like to add to this <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>?
</message>
<message name="IDS_OOBE_USER_CREATION_ADD_PERSON_SUBTITLE" desc="Subtitle of the screen which allows users to add person to the device.">
Each person can personalize their account and keep data private.
</message>
<message name="IDS_OOBE_USER_CREATION_SELF_BUTTON_LABEL" desc="The label of the button that leads to set up device for self.">
You
</message>
......
01474330418644fe0dabab943e275ae7293040f1
\ No newline at end of file
01474330418644fe0dabab943e275ae7293040f1
\ No newline at end of file
......@@ -55,7 +55,7 @@ found in the LICENSE file. -->
}
</style>
<oobe-dialog id="userCreationDialog" role="dialog" has-buttons
title-key="userCreationTitle" subtitle-key="userCreationSubtitle"
title-key="[[titleKey_]]" subtitle-key="[[subtitleKey_]]"
aria-label$="[[i18nDynamic(locale, 'userCreationTitle')]]"
for-step="create">
<hd-iron-icon icon1x="oobe-32:googleg" icon2x="oobe-64:googleg"
......
......@@ -62,12 +62,23 @@ Polymer({
},
/**
* Is the back button visible on the first step of the screen
* Is the back button visible on the first step of the screen. Back button
* is visible iff we are in the add person flow.
*/
isBackButtonVisible_: {
type: Boolean,
value: true,
}
},
titleKey_: {
type: String,
value: '',
},
subtitleKey_: {
type: String,
value: '',
},
},
......@@ -82,6 +93,11 @@ Polymer({
onBeforeShow() {
this.selectedUserType = UserType.SELF;
this.selectedSignInMethod = '';
this.titleKey_ = this.isBackButtonVisible_ ? 'userCreationAddPersonTitle' :
'userCreationTitle';
this.subtitleKey_ = this.isBackButtonVisible_ ?
'userCreationAddPersonSubtitle' :
'userCreationSubtitle';
if (this.uiStep === UIState.CHILD) {
chrome.send('updateOobeUIState', [OOBE_UI_STATE.GAIA_SIGNIN]);
}
......
......@@ -33,6 +33,11 @@ void UserCreationScreenHandler::DeclareLocalizedValues(
builder->AddF("userCreationTitle", IDS_OOBE_USER_CREATION_TITLE,
ui::GetChromeOSDeviceName());
builder->Add("userCreationSubtitle", IDS_OOBE_USER_CREATION_SUBTITLE);
builder->AddF("userCreationAddPersonTitle",
IDS_OOBE_USER_CREATION_ADD_PERSON_TITLE,
ui::GetChromeOSDeviceName());
builder->Add("userCreationAddPersonSubtitle",
IDS_OOBE_USER_CREATION_ADD_PERSON_SUBTITLE);
builder->Add("createForSelfLabel", IDS_OOBE_USER_CREATION_SELF_BUTTON_LABEL);
builder->Add("createForSelfDescription",
IDS_OOBE_USER_CREATION_SELF_BUTTON_DESCRIPTION);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment