Commit 99ff879f authored by Peter Wen's avatar Peter Wen Committed by Commit Bot

Reland "Android: Re-enable lint"

Original CL: http://crrev.com/c/577593

Fixes: Suppress lint errors for downstream targets.

TBR=mthiesse@chromium.org,agrieve@chromium.org

Bug: 739746,746409
Change-Id: Ib069fed8e77d1a55d75ae71592cea6096c46ff47
Reviewed-on: https://chromium-review.googlesource.com/577966Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488220}
parent c6162e38
......@@ -189,6 +189,8 @@ Still reading?
<issue id="MissingVersion">
<ignore path="AndroidManifest.xml"/>
</issue>
<!-- TODO(crbug.com/739746): Remove once platform-tools is updated. -->
<issue id="NewApi" severity="ignore"/>
<issue id="NewApi">
<ignore regexp="Attribute `paddingStart` referenced here can result in a crash on some specific devices older than API 17"/>
<ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
......@@ -234,6 +236,7 @@ Still reading?
</issue>
<issue id="PackageManagerGetSignatures">
<ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/customtabs/OriginVerifier.java"/>
</issue>
<issue id="PluralsCandidate" severity="Error">
<ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
......
......@@ -52,7 +52,7 @@ if (is_android) {
# Purposefully repeated so that downstream can change
# default_android_sdk_root without changing lint version.
default_lint_android_sdk_root = "//third_party/android_tools/sdk"
default_lint_android_sdk_version = "25"
default_lint_android_sdk_version = "26"
}
if (!defined(default_extras_android_sdk_root)) {
......
......@@ -120,6 +120,9 @@ public class VrShellDelegate
private static VrShellDelegate sInstance;
private static VrBroadcastReceiver sVrBroadcastReceiver;
private static boolean sRegisteredDaydreamHook = false;
// TODO(crbug.com/746409): Remove this suppression after this lint error is fixed.
@SuppressWarnings("StaticFieldLeak")
private static View sBlackOverlayView;
private ChromeActivity mActivity;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment