Commit 9a07080c authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

Disable string tail merging when linking with lld

String tail merging leads to smaller binaries, but they don't compress
as well, leading to increased mini_installer size.

This reduces mini_installer.exe size by 130 KB and increases chrome.dll
and chrome_child.dll by 72 KB and 154 KB, respectively for 32-bit (64-bit
is in the same ballpark).

(This depends on Clang/LLD being rolled past r332149.)

Bug: 838449
Change-Id: I1653e8d522371edb263f742f55ca1aa27ed5dd62
Reviewed-on: https://chromium-review.googlesource.com/1061733
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559459}
parent 4742976b
...@@ -118,6 +118,12 @@ config("compiler") { ...@@ -118,6 +118,12 @@ config("compiler") {
"/FIXED:NO", "/FIXED:NO",
] ]
if (use_lld) {
# String tail merging leads to smaller binaries, but they don't compress
# as well, leading to increased mini_installer size (crbug.com/838449).
ldflags += [ "/OPT:NOLLDTAILMERGE" ]
}
# TODO(siggi): Is this of any use anymore? # TODO(siggi): Is this of any use anymore?
# /PROFILE ensures that the PDB file contains FIXUP information (growing the # /PROFILE ensures that the PDB file contains FIXUP information (growing the
# PDB file by about 5%) but does not otherwise alter the output binary. It # PDB file by about 5%) but does not otherwise alter the output binary. It
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment