Rename UsbPrinterNotificationController::IsNotification

Rename IsNotification to IsNotificationDisplayed to more clearly
convey the functionality.

Change-Id: I4cfa84b8211b016f9ea867263080deb230e83c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621356
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661716}

chrome/browser/chromeos/printing/automatic_usb_printer_configurer_unittest.cc

@@ -154,7 +154,7 @@ class FakeUsbPrinterNotificationController
     open_notifications_.erase(printer_id);
   }
 
-  bool IsNotification(const std::string& printer_id) const override {
+  bool IsNotificationDisplayed(const std::string& printer_id) const override {
     return open_notifications_.contains(printer_id);
   }
 
@@ -310,7 +310,8 @@ TEST_F(AutomaticUsbPrinterConfigurerTest, NotificationOpenedForNewAutomatic) {
 
   fake_observable_printers_manager_.AddNearbyAutomaticPrinter(printer);
 
-  EXPECT_TRUE(fake_notification_controller_->IsNotification(printer_id));
+  EXPECT_TRUE(
+      fake_notification_controller_->IsNotificationDisplayed(printer_id));
 }
 
 TEST_F(AutomaticUsbPrinterConfigurerTest,
@@ -325,7 +326,8 @@ TEST_F(AutomaticUsbPrinterConfigurerTest,
   // result in a notification being shown.
   fake_observable_printers_manager_.AddNearbyAutomaticPrinter(printer);
 
-  EXPECT_TRUE(fake_notification_controller_->IsNotification(printer_id));
+  EXPECT_TRUE(
+      fake_notification_controller_->IsNotificationDisplayed(printer_id));
 }
 
 TEST_F(AutomaticUsbPrinterConfigurerTest, NotificationClosed) {
@@ -334,11 +336,13 @@ TEST_F(AutomaticUsbPrinterConfigurerTest, NotificationClosed) {
 
   fake_observable_printers_manager_.AddNearbyAutomaticPrinter(printer);
 
-  EXPECT_TRUE(fake_notification_controller_->IsNotification(printer_id));
+  EXPECT_TRUE(
+      fake_notification_controller_->IsNotificationDisplayed(printer_id));
 
   fake_observable_printers_manager_.RemoveAutomaticPrinter(printer_id);
 
-  EXPECT_FALSE(fake_notification_controller_->IsNotification(printer_id));
+  EXPECT_FALSE(
+      fake_notification_controller_->IsNotificationDisplayed(printer_id));
 }
 
 TEST_F(AutomaticUsbPrinterConfigurerTest, NotificationOpenedForNewDiscovered) {
@@ -347,7 +351,8 @@ TEST_F(AutomaticUsbPrinterConfigurerTest, NotificationOpenedForNewDiscovered) {
 
   fake_observable_printers_manager_.AddNearbyAutomaticPrinter(printer);
 
-  EXPECT_TRUE(fake_notification_controller_->IsNotification(printer_id));
+  EXPECT_TRUE(
+      fake_notification_controller_->IsNotificationDisplayed(printer_id));
 }
 
 }  // namespace chromeos

chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc

@@ -316,7 +316,7 @@ class FakeUsbPrinterNotificationController
     saved_notifications_.erase(printer_id);
     configuration_notifications_.erase(printer_id);
   }
-  bool IsNotification(const std::string& printer_id) const override {
+  bool IsNotificationDisplayed(const std::string& printer_id) const override {
     return configuration_notifications_.contains(printer_id) ||
            saved_notifications_.contains(printer_id);
   }

chrome/browser/chromeos/printing/usb_printer_notification_controller.cc

@@ -30,7 +30,7 @@ class UsbPrinterNotificationControllerImpl
     notifications_.erase(printer_id);
   }
 
-  bool IsNotification(const std::string& printer_id) const override {
+  bool IsNotificationDisplayed(const std::string& printer_id) const override {
     return base::ContainsKey(notifications_, printer_id);
   }
 

chrome/browser/chromeos/printing/usb_printer_notification_controller.h

@@ -42,7 +42,7 @@ class UsbPrinterNotificationController {
   virtual void RemoveNotification(const std::string& printer_id) = 0;
 
   // Returns true if there is an existing notification for |printer_id|.
-  virtual bool IsNotification(const std::string& printer_id) const = 0;
+  virtual bool IsNotificationDisplayed(const std::string& printer_id) const = 0;
 
  protected:
   UsbPrinterNotificationController() = default;