Commit 9a2457b9 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Make some MTPDeviceDelegateImplLinux methods non-virtual.

They have no overrides.

Change-Id: I8bb69c0a0d09f45d29db480d23f665fad6c02a4f
Reviewed-on: https://chromium-review.googlesource.com/1090232
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565565}
parent ca227d1e
......@@ -143,49 +143,46 @@ class MTPDeviceDelegateImplLinux : public MTPDeviceAsyncDelegate {
// The internal methods correspond to the similarly named methods above.
// The |root_node_| cache should be filled at this point.
virtual void GetFileInfoInternal(
const base::FilePath& file_path,
const GetFileInfoSuccessCallback& success_callback,
const ErrorCallback& error_callback);
virtual void CreateDirectoryInternal(
void GetFileInfoInternal(const base::FilePath& file_path,
const GetFileInfoSuccessCallback& success_callback,
const ErrorCallback& error_callback);
void CreateDirectoryInternal(
const std::vector<base::FilePath>& components,
const bool exclusive,
const CreateDirectorySuccessCallback& success_callback,
const ErrorCallback& error_callback);
virtual void ReadDirectoryInternal(
void ReadDirectoryInternal(
const base::FilePath& root,
const ReadDirectorySuccessCallback& success_callback,
const ErrorCallback& error_callback);
virtual void CreateSnapshotFileInternal(
void CreateSnapshotFileInternal(
const base::FilePath& device_file_path,
const base::FilePath& local_path,
const CreateSnapshotFileSuccessCallback& success_callback,
const ErrorCallback& error_callback);
virtual void ReadBytesInternal(
const base::FilePath& device_file_path,
net::IOBuffer* buf,
int64_t offset,
int buf_len,
const ReadBytesSuccessCallback& success_callback,
const ErrorCallback& error_callback);
virtual void MoveFileLocalInternal(
void ReadBytesInternal(const base::FilePath& device_file_path,
net::IOBuffer* buf,
int64_t offset,
int buf_len,
const ReadBytesSuccessCallback& success_callback,
const ErrorCallback& error_callback);
void MoveFileLocalInternal(
const base::FilePath& source_file_path,
const base::FilePath& device_file_path,
const CreateTemporaryFileCallback& create_temporary_file_callback,
const MoveFileLocalSuccessCallback& success_callback,
const ErrorCallback& error_callback,
const base::File::Info& source_file_info);
virtual void OnDidOpenFDToCopyFileFromLocal(
void OnDidOpenFDToCopyFileFromLocal(
const base::FilePath& device_file_path,
const CopyFileFromLocalSuccessCallback& success_callback,
const ErrorCallback& error_callback,
const std::pair<int, base::File::Error>& open_fd_result);
virtual void DeleteFileInternal(
const base::FilePath& file_path,
const DeleteFileSuccessCallback& success_callback,
const ErrorCallback& error_callback,
const base::File::Info& file_info);
virtual void DeleteDirectoryInternal(
void DeleteFileInternal(const base::FilePath& file_path,
const DeleteFileSuccessCallback& success_callback,
const ErrorCallback& error_callback,
const base::File::Info& file_info);
void DeleteDirectoryInternal(
const base::FilePath& file_path,
const DeleteDirectorySuccessCallback& success_callback,
const ErrorCallback& error_callback,
......@@ -193,7 +190,7 @@ class MTPDeviceDelegateImplLinux : public MTPDeviceAsyncDelegate {
// Creates a single directory to |directory_path|. The caller must ensure that
// parent directory |directory_path.DirName()| already exists.
virtual void CreateSingleDirectory(
void CreateSingleDirectory(
const base::FilePath& directory_path,
const bool exclusive,
const CreateDirectorySuccessCallback& success_callback,
......@@ -201,7 +198,7 @@ class MTPDeviceDelegateImplLinux : public MTPDeviceAsyncDelegate {
// Called when ReadDirectoryInternal() completes for filling cache as part of
// creating directories.
virtual void OnDidReadDirectoryToCreateDirectory(
void OnDidReadDirectoryToCreateDirectory(
const std::vector<base::FilePath>& components,
const bool exclusive,
const CreateDirectorySuccessCallback& success_callback,
......@@ -210,7 +207,7 @@ class MTPDeviceDelegateImplLinux : public MTPDeviceAsyncDelegate {
const bool has_more);
// Called when CheckDirectoryEmpty() succeeds.
virtual void OnDidCheckDirectoryEmptyToDeleteDirectory(
void OnDidCheckDirectoryEmptyToDeleteDirectory(
const base::FilePath& directory_path,
uint32_t directory_id,
const DeleteDirectorySuccessCallback& success_callback,
......@@ -218,7 +215,7 @@ class MTPDeviceDelegateImplLinux : public MTPDeviceAsyncDelegate {
bool is_empty);
// Calls DeleteObjectOnUIThread on UI thread.
virtual void RunDeleteObjectOnUIThread(
void RunDeleteObjectOnUIThread(
const base::FilePath& object_path,
const uint32_t object_id,
const DeleteObjectSuccessCallback& success_callback,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment