Fix Memory Leak In GrowPopupInSpace

R=estade@chromium.org
BUG=171567


Review URL: https://chromiumcodereview.appspot.com/12209101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181969 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

@@ -378,13 +378,18 @@ TEST_F(AutofillPopupControllerUnitTest, GrowPopupInSpace) {
           desired_width / 2, desired_height /2, desired_width, desired_height));
 
   for (size_t i = 0; i < element_bounds.size(); ++i) {
-    TestAutofillPopupController autofill_popup_controller(&external_delegate_,
-                                                          element_bounds[i]);
-    autofill_popup_controller.set_display(display);
-    autofill_popup_controller.Show(names, names, names, autofill_ids);
+    TestAutofillPopupController* autofill_popup_controller =
+        new TestAutofillPopupController(&external_delegate_,
+                                        element_bounds[i]);
+
+    autofill_popup_controller->set_display(display);
+    autofill_popup_controller->Show(names, names, names, autofill_ids);
 
     EXPECT_EQ(expected_popup_bounds[i].ToString(),
-              autofill_popup_controller.popup_bounds().ToString()) <<
+              autofill_popup_controller->popup_bounds().ToString()) <<
         "Popup bounds failed to match for test " << i;
+
+    // Hide the controller to delete it.
+    autofill_popup_controller->DoHide();
   }
 }

tools/heapcheck/suppressions.txt

@@ -1736,20 +1736,6 @@
    fun:::FilterBuilder::Build
    fun:::LoadWhitelistsOnBlockingPoolThread
 }
-{
-   bug_171567_a
-   Heapcheck:Leak
-   ...
-   fun:AutofillPopupControllerUnitTest_GrowPopupInSpace_Test::TestBody
-}
-{
-   bug_171567_b
-   Heapcheck:Leak
-   ...
-   fun:AutofillPopupControllerUnitTest::AutofillPopupControllerUnitTest
-   fun:AutofillPopupControllerUnitTest_GrowPopupInSpace_Test::AutofillPopupControllerUnitTest_GrowPopupInSpace_Test
-   fun:testing::internal::TestFactoryImpl::CreateTest
-}
 {
    bug_171983
    Heapcheck:Leak

tools/valgrind/memcheck/suppressions.txt

@@ -6394,14 +6394,6 @@
    fun:_ZN7WebCore14SQLTransaction19postflightAndCommitEv
    fun:_ZN7WebCore14SQLTransaction13runStatementsEv
 }
-{
-   bug_171567
-   Memcheck:Leak
-   fun:_Znw*
-   fun:_ZN17AutofillPopupView6CreateEP23AutofillPopupController
-   fun:_ZN27AutofillPopupControllerImpl4ShowERKSt6vectorISbItN4base20string16_char_traitsESaItEESaIS4_EES8_S8_RKS0_IiSaIiEE
-   fun:_ZN53AutofillPopupControllerUnitTest_GrowPopupInSpace_Test8TestBodyEv
-}
 {
    bug_171722
    Memcheck:Leak