[PartitionAlloc] Remove static locals used on the allocation path.

Threadsafe static local variables call into the C runtime on Windows,
which may not be safe in the allocation path (see linked bug). Don't use
them for code which is on this path.

This is using base::LazyInstance. It currently fulfills our needs,
though it is not ideal for a couple reasons:
- Not guaranteed to stay independent from local statics.
- Can allocate in some paths (mostly DCHECK()s)

As such, this is temporary, and we should either make sure that
LazyInstance is suitable, or have a replacement local to PartitionAlloc.

Bug: 1126432
Change-Id: I9cffed6f313c3fb380383a1607f0e6f27397c2a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401469Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805698}

base/allocator/partition_allocator/address_pool_manager.cc

@@ -15,6 +15,7 @@
 #include "base/allocator/partition_allocator/page_allocator_internal.h"
 #include "base/allocator/partition_allocator/partition_alloc_check.h"
 #include "base/bits.h"
+#include "base/lazy_instance.h"
 #include "base/notreached.h"
 #include "base/stl_util.h"
 
@@ -53,14 +54,16 @@ bool WARN_UNUSED_RESULT CommitPages(void* address, size_t size) {
   return true;
 }
 
+base::LazyInstance<AddressPoolManager>::Leaky g_address_pool_manager =
+    LAZY_INSTANCE_INITIALIZER;
+
 }  // namespace
 
 constexpr size_t AddressPoolManager::Pool::kMaxBits;
 
 // static
 AddressPoolManager* AddressPoolManager::GetInstance() {
-  static NoDestructor<AddressPoolManager> instance;
-  return instance.get();
+  return g_address_pool_manager.Pointer();
 }
 
 pool_handle AddressPoolManager::Add(uintptr_t ptr, size_t length) {

base/allocator/partition_allocator/address_pool_manager.h

@@ -10,7 +10,7 @@
 #include "base/allocator/partition_allocator/address_pool_manager_types.h"
 #include "base/allocator/partition_allocator/partition_alloc_constants.h"
 #include "base/atomicops.h"
-#include "base/no_destructor.h"
+#include "base/lazy_instance.h"
 #include "base/synchronization/lock.h"
 #include "base/thread_annotations.h"
 #include "build/build_config.h"
@@ -81,7 +81,7 @@ class BASE_EXPORT AddressPoolManager {
   static constexpr size_t kNumPools = 2;
   Pool pools_[kNumPools];
 
-  friend class NoDestructor<AddressPoolManager>;
+  friend struct base::LazyInstanceTraitsBase<AddressPoolManager>;
   DISALLOW_COPY_AND_ASSIGN(AddressPoolManager);
 };
 

base/allocator/partition_allocator/page_allocator.cc

@@ -13,6 +13,7 @@
 #include "base/allocator/partition_allocator/partition_alloc_check.h"
 #include "base/bits.h"
 #include "base/check_op.h"
+#include "base/lazy_instance.h"
 #include "base/no_destructor.h"
 #include "base/numerics/checked_math.h"
 #include "base/synchronization/lock.h"
@@ -36,10 +37,11 @@ namespace base {
 
 namespace {
 
+LazyInstance<Lock>::Leaky g_reserve_lock = LAZY_INSTANCE_INITIALIZER;
+
 // We may reserve/release address space on different threads.
 Lock& GetReserveLock() {
-  static NoDestructor<Lock> lock;
-  return *lock;
+  return g_reserve_lock.Get();
 }
 
 std::atomic<size_t> g_total_mapped_address_space;

base/allocator/partition_allocator/random.cc

@@ -4,6 +4,7 @@
 
 #include "base/allocator/partition_allocator/random.h"
 
+#include "base/lazy_instance.h"
 #include "base/no_destructor.h"
 #include "base/rand_util.h"
 #include "base/synchronization/lock.h"
@@ -12,9 +13,10 @@ namespace base {
 
 namespace {
 
+LazyInstance<Lock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER;
+
 Lock& GetLock() {
-  static NoDestructor<Lock> lock;
-  return *lock;
+  return g_lock.Get();
 }
 
 }  // namespace