Commit 9a8bad90 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Enable -Wmisleading-indentation for chromium_code.

Except on iOS, CrOS, Chromecast for now.

I did two full local non-goma builds with this off and on, and
couldn't measure any slowdown from the warning.
(`gn clean out/gn && time ninja -C out/gn content_shell`)

Bug: 1031169
Change-Id: I91fe477f00cbef12bf48dcfb377ee83ed5a3fabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063736
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743014}
parent 9c2fc554
......@@ -1522,9 +1522,6 @@ config("default_warnings") {
# TODO(https://crbug.com/1028110): Evaluate and possible enable.
"-Wno-deprecated-copy",
# TODO(https://crbug.com/1031169): Clean up and enable.
"-Wno-misleading-indentation",
# TODO(https://crbug.com/1039697): Evaluate and possibly enable.
"-Wno-range-loop-analysis",
]
......@@ -1536,6 +1533,13 @@ config("default_warnings") {
]
}
if (is_ios || is_chromeos || is_chromecast) {
cflags += [
# TODO(https://crbug.com/1031169): Clean up and enable.
"-Wno-misleading-indentation",
]
}
if (llvm_force_head_revision) {
cflags += [
# TODO(https://crbug.com/1050281): Clean up, enable.
......@@ -1675,6 +1679,12 @@ config("no_chromium_code") {
# suppressing them individually, we just blanket suppress them here.
"-Wno-unused-variable",
]
if (!is_nacl && (current_toolchain == host_toolchain || !use_xcode_clang)) {
cflags += [
# TODO(https://crbug.com/1031169): Clean up and enable.
"-Wno-misleading-indentation",
]
}
}
configs = [ ":default_warnings" ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment