Commit 9a91f85e authored by Liquan (Max) Gu's avatar Liquan (Max) Gu Committed by Commit Bot

[WebLayer] Move PaymentManifestWebdataServiceAndroid into //chrome

Before:
Compiling //components' PaymentManifestWebdataServiceAndroid in
//weblayer would fail because it depends on //chrome's
payment_manifest_webdata_service_android.

Changes:
Move //components' PaymentManifestWebdataServiceAndroid into //chrome.

After:
PaymentManifestWebdataServiceAndroid lives in //chrome and wouldn't
be compiled when //weblayer compile //components payment targets.
Going forwards, PaymentManifestWebdataService will only be used in
Chrome payment, WebLayer payment will find a replacement for it.

Bug: 1140637

Change-Id: I4a07761c5220c930cf3c0abd05d9072b63179693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488548Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820121}
parent c75c7666
...@@ -1271,6 +1271,7 @@ chrome_java_sources = [ ...@@ -1271,6 +1271,7 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/payments/PaymentAppService.java", "java/src/org/chromium/chrome/browser/payments/PaymentAppService.java",
"java/src/org/chromium/chrome/browser/payments/PaymentAppServiceBridge.java", "java/src/org/chromium/chrome/browser/payments/PaymentAppServiceBridge.java",
"java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java", "java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java",
"java/src/org/chromium/chrome/browser/payments/PaymentManifestWebDataService.java",
"java/src/org/chromium/chrome/browser/payments/PaymentPreferencesUtil.java", "java/src/org/chromium/chrome/browser/payments/PaymentPreferencesUtil.java",
"java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java", "java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java",
"java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java", "java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java",
......
...@@ -13,7 +13,6 @@ import android.util.Pair; ...@@ -13,7 +13,6 @@ import android.util.Pair;
import org.chromium.components.payments.PackageManagerDelegate; import org.chromium.components.payments.PackageManagerDelegate;
import org.chromium.components.payments.PaymentManifestDownloader; import org.chromium.components.payments.PaymentManifestDownloader;
import org.chromium.components.payments.PaymentManifestParser; import org.chromium.components.payments.PaymentManifestParser;
import org.chromium.components.payments.PaymentManifestWebDataService;
import org.chromium.components.payments.intent.WebPaymentIntentHelper; import org.chromium.components.payments.intent.WebPaymentIntentHelper;
import java.util.HashMap; import java.util.HashMap;
......
...@@ -22,7 +22,6 @@ import org.chromium.components.payments.PackageManagerDelegate; ...@@ -22,7 +22,6 @@ import org.chromium.components.payments.PackageManagerDelegate;
import org.chromium.components.payments.PaymentFeatureList; import org.chromium.components.payments.PaymentFeatureList;
import org.chromium.components.payments.PaymentManifestDownloader; import org.chromium.components.payments.PaymentManifestDownloader;
import org.chromium.components.payments.PaymentManifestParser; import org.chromium.components.payments.PaymentManifestParser;
import org.chromium.components.payments.PaymentManifestWebDataService;
import org.chromium.components.payments.PaymentOptionsUtils; import org.chromium.components.payments.PaymentOptionsUtils;
import org.chromium.components.payments.SupportedDelegations; import org.chromium.components.payments.SupportedDelegations;
import org.chromium.components.payments.intent.WebPaymentIntentHelper; import org.chromium.components.payments.intent.WebPaymentIntentHelper;
......
...@@ -16,7 +16,6 @@ import org.chromium.components.payments.PaymentManifestDownloader; ...@@ -16,7 +16,6 @@ import org.chromium.components.payments.PaymentManifestDownloader;
import org.chromium.components.payments.PaymentManifestDownloader.ManifestDownloadCallback; import org.chromium.components.payments.PaymentManifestDownloader.ManifestDownloadCallback;
import org.chromium.components.payments.PaymentManifestParser; import org.chromium.components.payments.PaymentManifestParser;
import org.chromium.components.payments.PaymentManifestParser.ManifestParseCallback; import org.chromium.components.payments.PaymentManifestParser.ManifestParseCallback;
import org.chromium.components.payments.PaymentManifestWebDataService;
import org.chromium.components.payments.WebAppManifestSection; import org.chromium.components.payments.WebAppManifestSection;
import org.chromium.url.GURL; import org.chromium.url.GURL;
import org.chromium.url.Origin; import org.chromium.url.Origin;
......
...@@ -2,11 +2,12 @@ ...@@ -2,11 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.components.payments; package org.chromium.chrome.browser.payments;
import org.chromium.base.annotations.CalledByNative; import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace; import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods; import org.chromium.base.annotations.NativeMethods;
import org.chromium.components.payments.WebAppManifestSection;
/** Java wrapper of the payment manifest web data service. */ /** Java wrapper of the payment manifest web data service. */
@JNINamespace("payments") @JNINamespace("payments")
......
...@@ -27,7 +27,6 @@ import org.chromium.components.payments.PaymentAppFactoryParams; ...@@ -27,7 +27,6 @@ import org.chromium.components.payments.PaymentAppFactoryParams;
import org.chromium.components.payments.PaymentFeatureList; import org.chromium.components.payments.PaymentFeatureList;
import org.chromium.components.payments.PaymentManifestDownloader; import org.chromium.components.payments.PaymentManifestDownloader;
import org.chromium.components.payments.PaymentManifestParser; import org.chromium.components.payments.PaymentManifestParser;
import org.chromium.components.payments.PaymentManifestWebDataService;
import org.chromium.content_public.browser.RenderFrameHost; import org.chromium.content_public.browser.RenderFrameHost;
import org.chromium.content_public.browser.WebContents; import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.test.util.CriteriaHelper; import org.chromium.content_public.browser.test.util.CriteriaHelper;
......
...@@ -34,7 +34,6 @@ import org.chromium.components.payments.PaymentApp; ...@@ -34,7 +34,6 @@ import org.chromium.components.payments.PaymentApp;
import org.chromium.components.payments.PaymentAppFactoryParams; import org.chromium.components.payments.PaymentAppFactoryParams;
import org.chromium.components.payments.PaymentManifestDownloader; import org.chromium.components.payments.PaymentManifestDownloader;
import org.chromium.components.payments.PaymentManifestParser; import org.chromium.components.payments.PaymentManifestParser;
import org.chromium.components.payments.PaymentManifestWebDataService;
import org.chromium.components.payments.WebAppManifestSection; import org.chromium.components.payments.WebAppManifestSection;
import org.chromium.content_public.browser.WebContents; import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.test.NativeLibraryTestUtils; import org.chromium.content_public.browser.test.NativeLibraryTestUtils;
......
...@@ -23,12 +23,11 @@ import org.mockito.MockitoAnnotations; ...@@ -23,12 +23,11 @@ import org.mockito.MockitoAnnotations;
import org.chromium.base.test.BaseJUnit4ClassRunner; import org.chromium.base.test.BaseJUnit4ClassRunner;
import org.chromium.base.test.util.Batch; import org.chromium.base.test.util.Batch;
import org.chromium.chrome.browser.payments.PaymentManifestVerifier.ManifestVerifyCallback; import org.chromium.chrome.browser.payments.PaymentManifestVerifier.ManifestVerifyCallback;
import org.chromium.chrome.browser.payments.PaymentManifestWebDataService.PaymentManifestWebDataServiceCallback;
import org.chromium.chrome.test.ChromeBrowserTestRule; import org.chromium.chrome.test.ChromeBrowserTestRule;
import org.chromium.components.payments.PackageManagerDelegate; import org.chromium.components.payments.PackageManagerDelegate;
import org.chromium.components.payments.PaymentManifestDownloader; import org.chromium.components.payments.PaymentManifestDownloader;
import org.chromium.components.payments.PaymentManifestParser; import org.chromium.components.payments.PaymentManifestParser;
import org.chromium.components.payments.PaymentManifestWebDataService;
import org.chromium.components.payments.PaymentManifestWebDataService.PaymentManifestWebDataServiceCallback;
import org.chromium.components.payments.WebAppManifestSection; import org.chromium.components.payments.WebAppManifestSection;
import org.chromium.content_public.browser.WebContents; import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.test.NativeLibraryTestUtils; import org.chromium.content_public.browser.test.NativeLibraryTestUtils;
......
...@@ -11,6 +11,7 @@ import("//build/config/android/rules.gni") ...@@ -11,6 +11,7 @@ import("//build/config/android/rules.gni")
generate_jni("jni_headers") { generate_jni("jni_headers") {
sources = [ sources = [
"../../../android/java/src/org/chromium/chrome/browser/payments/PaymentAppServiceBridge.java", "../../../android/java/src/org/chromium/chrome/browser/payments/PaymentAppServiceBridge.java",
"../../../android/java/src/org/chromium/chrome/browser/payments/PaymentManifestWebDataService.java",
"../../../android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java", "../../../android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java",
"../../../android/java/src/org/chromium/chrome/browser/payments/SslValidityChecker.java", "../../../android/java/src/org/chromium/chrome/browser/payments/SslValidityChecker.java",
] ]
......
...@@ -11,10 +11,10 @@ ...@@ -11,10 +11,10 @@
#include "base/check_op.h" #include "base/check_op.h"
#include "base/notreached.h" #include "base/notreached.h"
#include "base/numerics/safe_conversions.h" #include "base/numerics/safe_conversions.h"
#include "chrome/browser/payments/android/jni_headers/PaymentManifestWebDataService_jni.h"
#include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/web_data_service_factory.h" #include "chrome/browser/web_data_service_factory.h"
#include "components/keyed_service/core/service_access_type.h" #include "components/keyed_service/core/service_access_type.h"
#include "components/payments/content/android/jni_headers/PaymentManifestWebDataService_jni.h"
#include "components/webdata/common/web_data_results.h" #include "components/webdata/common/web_data_results.h"
namespace payments { namespace payments {
......
...@@ -63,7 +63,6 @@ generate_jni("jni_headers") { ...@@ -63,7 +63,6 @@ generate_jni("jni_headers") {
"java/src/org/chromium/components/payments/PaymentHandlerHost.java", "java/src/org/chromium/components/payments/PaymentHandlerHost.java",
"java/src/org/chromium/components/payments/PaymentManifestDownloader.java", "java/src/org/chromium/components/payments/PaymentManifestDownloader.java",
"java/src/org/chromium/components/payments/PaymentManifestParser.java", "java/src/org/chromium/components/payments/PaymentManifestParser.java",
"java/src/org/chromium/components/payments/PaymentManifestWebDataService.java",
"java/src/org/chromium/components/payments/PaymentRequestSpec.java", "java/src/org/chromium/components/payments/PaymentRequestSpec.java",
"java/src/org/chromium/components/payments/PaymentRequestUpdateEventListener.java", "java/src/org/chromium/components/payments/PaymentRequestUpdateEventListener.java",
"java/src/org/chromium/components/payments/PaymentValidator.java", "java/src/org/chromium/components/payments/PaymentValidator.java",
...@@ -125,7 +124,6 @@ android_library("all_java") { ...@@ -125,7 +124,6 @@ android_library("all_java") {
"java/src/org/chromium/components/payments/PaymentHandlerHost.java", "java/src/org/chromium/components/payments/PaymentHandlerHost.java",
"java/src/org/chromium/components/payments/PaymentManifestDownloader.java", "java/src/org/chromium/components/payments/PaymentManifestDownloader.java",
"java/src/org/chromium/components/payments/PaymentManifestParser.java", "java/src/org/chromium/components/payments/PaymentManifestParser.java",
"java/src/org/chromium/components/payments/PaymentManifestWebDataService.java",
"java/src/org/chromium/components/payments/PaymentOptionsUtils.java", "java/src/org/chromium/components/payments/PaymentOptionsUtils.java",
"java/src/org/chromium/components/payments/PaymentRequestLifecycleObserver.java", "java/src/org/chromium/components/payments/PaymentRequestLifecycleObserver.java",
"java/src/org/chromium/components/payments/PaymentRequestParams.java", "java/src/org/chromium/components/payments/PaymentRequestParams.java",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment