Skip to content

GitLab

T
tangled
Commit 9aa50456 authored by David Lei's avatar David Lei Committed by Commit Bot
Browse files
Options

Add favicon for chrome://media-app. 

This makes chrome://media-app show up with a favicon in the task
manager.

Follow up work needed to get the icon to show for the subframe
(crbug/1141242).

Note: We only need one of these icon sizes to get it to show but I
don't think there is any harm in adding all of them.
https://en.wikipedia.org/wiki/Favicon#HTML5_recommendation_for_icons_in_multiple_sizes

Bug: b/171350349
Change-Id: I908ab710fe71c037b427caa368a36b14e13890f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491560
Commit-Queue: David Lei <dlei@google.com>
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Reviewed-by: default avatarPatti <patricialor@chromium.org>
Auto-Submit: David Lei <dlei@google.com>
Cr-Commit-Position: refs/heads/master@{#820655}
parent 7ce5f71d
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 0 deletions
chromeos/components/media_app_ui/resources/index.html
View file @ 9aa50456
...@@ -5,6 +5,14 @@ ...@@ -5,6 +5,14 @@
<html dir="$i18n{textdirection}" lang="$i18n{language}"> <html dir="$i18n{textdirection}" lang="$i18n{language}">
<meta charset="utf-8"> <meta charset="utf-8">
<title>$i18n{appTitle}</title> <title>$i18n{appTitle}</title>
<link rel="icon" type="image/png" sizes="16x16" href="system_assets/app_icon_16.png">
<link rel="icon" type="image/png" sizes="32x32" href="system_assets/app_icon_32.png">
<link rel="icon" type="image/png" sizes="48x48" href="system_assets/app_icon_48.png">
<link rel="icon" type="image/png" sizes="64x64" href="system_assets/app_icon_64.png">
<link rel="icon" type="image/png" sizes="96x96" href="system_assets/app_icon_96.png">
<link rel="icon" type="image/png" sizes="128x128" href="system_assets/app_icon_128.png">
<link rel="icon" type="image/png" sizes="192x192" href="system_assets/app_icon_192.png">
<link rel="icon" type="image/png" sizes="256x256" href="system_assets/app_icon_256.png">
<style> <style>
body { body {
background-color: #202124; background-color: #202124;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment