Commit 9aa69689 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

bindings: Reduce the size of serialized_script_value.h

serialized_script_value.h is used in 2,000+ compilation units, and this
CL reduces its pre-processed size from 5.11MB to 1.79MB.

Also, this CL removes unnecessary #includes for
serialzied_script_value.h.

Bug: 242216
Change-Id: I8bbd09c96461d658770abe40df782d37871d3847
Reviewed-on: https://chromium-review.googlesource.com/1116410Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571051}
parent a6742710
...@@ -259,6 +259,11 @@ SerializedScriptValue::SerializedScriptValue(DataBufferPtr data, ...@@ -259,6 +259,11 @@ SerializedScriptValue::SerializedScriptValue(DataBufferPtr data,
has_registered_external_allocation_(false), has_registered_external_allocation_(false),
transferables_need_external_allocation_registration_(false) {} transferables_need_external_allocation_registration_(false) {}
void SerializedScriptValue::SetImageBitmapContentsArray(
ImageBitmapContentsArray contents) {
image_bitmap_contents_array_ = std::move(contents);
}
SerializedScriptValue::DataBufferPtr SerializedScriptValue::AllocateBuffer( SerializedScriptValue::DataBufferPtr SerializedScriptValue::AllocateBuffer(
size_t buffer_size) { size_t buffer_size) {
return DataBufferPtr(static_cast<uint8_t*>(WTF::Partitions::BufferMalloc( return DataBufferPtr(static_cast<uint8_t*>(WTF::Partitions::BufferMalloc(
......
...@@ -36,14 +36,12 @@ ...@@ -36,14 +36,12 @@
#include "base/containers/span.h" #include "base/containers/span.h"
#include "base/optional.h" #include "base/optional.h"
#include "third_party/blink/renderer/bindings/core/v8/native_value_traits.h" #include "third_party/blink/renderer/bindings/core/v8/native_value_traits.h"
#include "third_party/blink/renderer/bindings/core/v8/script_value.h"
#include "third_party/blink/renderer/bindings/core/v8/serialization/transferables.h" #include "third_party/blink/renderer/bindings/core/v8/serialization/transferables.h"
#include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/core/core_export.h"
#include "third_party/blink/renderer/core/imagebitmap/image_bitmap.h"
#include "third_party/blink/renderer/platform/wtf/allocator.h" #include "third_party/blink/renderer/platform/wtf/allocator.h"
#include "third_party/blink/renderer/platform/wtf/allocator/partitions.h" #include "third_party/blink/renderer/platform/wtf/allocator/partitions.h"
#include "third_party/blink/renderer/platform/wtf/hash_map.h" #include "third_party/blink/renderer/platform/wtf/hash_map.h"
#include "third_party/blink/renderer/platform/wtf/text/string_view.h" #include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
#include "third_party/blink/renderer/platform/wtf/thread_safe_ref_counted.h" #include "third_party/blink/renderer/platform/wtf/thread_safe_ref_counted.h"
#include "third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h" #include "third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h"
#include "v8/include/v8.h" #include "v8/include/v8.h"
...@@ -54,6 +52,7 @@ class BlobDataHandle; ...@@ -54,6 +52,7 @@ class BlobDataHandle;
class Transferables; class Transferables;
class ExceptionState; class ExceptionState;
class SharedBuffer; class SharedBuffer;
class StaticBitmapImage;
class UnpackedSerializedScriptValue; class UnpackedSerializedScriptValue;
class WebBlobInfo; class WebBlobInfo;
class DOMSharedArrayBuffer; class DOMSharedArrayBuffer;
...@@ -240,9 +239,7 @@ class CORE_EXPORT SerializedScriptValue ...@@ -240,9 +239,7 @@ class CORE_EXPORT SerializedScriptValue
ImageBitmapContentsArray& GetImageBitmapContentsArray() { ImageBitmapContentsArray& GetImageBitmapContentsArray() {
return image_bitmap_contents_array_; return image_bitmap_contents_array_;
} }
void SetImageBitmapContentsArray(ImageBitmapContentsArray contents) { void SetImageBitmapContentsArray(ImageBitmapContentsArray contents);
image_bitmap_contents_array_ = std::move(contents);
}
private: private:
friend class ScriptValueSerializer; friend class ScriptValueSerializer;
......
...@@ -6,6 +6,8 @@ ...@@ -6,6 +6,8 @@
#include "third_party/blink/renderer/bindings/core/v8/script_value.h" #include "third_party/blink/renderer/bindings/core/v8/script_value.h"
#include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h" #include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h"
#include "third_party/blink/renderer/core/execution_context/execution_context.h"
#include "third_party/blink/renderer/platform/bindings/dom_wrapper_world.h"
#include "third_party/blink/renderer/platform/bindings/script_state.h" #include "third_party/blink/renderer/platform/bindings/script_state.h"
namespace blink { namespace blink {
......
...@@ -57,6 +57,7 @@ ...@@ -57,6 +57,7 @@
#include "third_party/blink/renderer/core/loader/threadable_loading_context.h" #include "third_party/blink/renderer/core/loader/threadable_loading_context.h"
#include "third_party/blink/renderer/core/probe/core_probes.h" #include "third_party/blink/renderer/core/probe/core_probes.h"
#include "third_party/blink/renderer/platform/exported/wrapped_resource_request.h" #include "third_party/blink/renderer/platform/exported/wrapped_resource_request.h"
#include "third_party/blink/renderer/platform/heap/self_keep_alive.h"
#include "third_party/blink/renderer/platform/loader/cors/cors.h" #include "third_party/blink/renderer/platform/loader/cors/cors.h"
#include "third_party/blink/renderer/platform/loader/cors/cors_error_string.h" #include "third_party/blink/renderer/platform/loader/cors/cors_error_string.h"
#include "third_party/blink/renderer/platform/loader/fetch/fetch_parameters.h" #include "third_party/blink/renderer/platform/loader/fetch/fetch_parameters.h"
......
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
#include "third_party/blink/renderer/core/timing/performance_mark.h" #include "third_party/blink/renderer/core/timing/performance_mark.h"
#include "third_party/blink/renderer/bindings/core/v8/script_value.h"
#include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h" #include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h"
#include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_factory.h" #include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_factory.h"
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "third_party/blink/renderer/core/timing/performance_measure.h" #include "third_party/blink/renderer/core/timing/performance_measure.h"
#include "third_party/blink/renderer/bindings/core/v8/script_value.h"
#include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h" #include "third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h"
namespace blink { namespace blink {
......
...@@ -15,6 +15,7 @@ ...@@ -15,6 +15,7 @@
#include "third_party/blink/renderer/core/workers/abstract_worker.h" #include "third_party/blink/renderer/core/workers/abstract_worker.h"
#include "third_party/blink/renderer/core/workers/worker_options.h" #include "third_party/blink/renderer/core/workers/worker_options.h"
#include "third_party/blink/renderer/platform/graphics/begin_frame_provider.h" #include "third_party/blink/renderer/platform/graphics/begin_frame_provider.h"
#include "third_party/blink/renderer/platform/weborigin/kurl.h"
#include "third_party/blink/renderer/platform/wtf/forward.h" #include "third_party/blink/renderer/platform/wtf/forward.h"
namespace v8_inspector { namespace v8_inspector {
......
...@@ -31,6 +31,7 @@ ...@@ -31,6 +31,7 @@
#include "third_party/blink/renderer/modules/serviceworkers/extendable_event.h" #include "third_party/blink/renderer/modules/serviceworkers/extendable_event.h"
#include "third_party/blink/renderer/modules/serviceworkers/wait_until_observer.h" #include "third_party/blink/renderer/modules/serviceworkers/wait_until_observer.h"
#include "third_party/blink/renderer/platform/bindings/exception_state.h"
#include "third_party/blink/renderer/platform/bindings/script_wrappable.h" #include "third_party/blink/renderer/platform/bindings/script_wrappable.h"
namespace blink { namespace blink {
......
...@@ -17,6 +17,7 @@ class ExceptionState; ...@@ -17,6 +17,7 @@ class ExceptionState;
class ExecutionContext; class ExecutionContext;
class ScriptPromise; class ScriptPromise;
class ScriptState; class ScriptState;
class ScriptValue;
// Created for each ExtendableEvent instance. // Created for each ExtendableEvent instance.
class MODULES_EXPORT WaitUntilObserver final class MODULES_EXPORT WaitUntilObserver final
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment