Remove "LoadBrokenImagesFromContextMenu" feature flag

The feature is enabled by default for some time now, so it is suggested
to removed it from code.

R=avi@chromium.org

Bug: 603
Change-Id: I7a25ff9ae7c93a01ad536a29eafa10165749482e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800408Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702930}

chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -1385,9 +1385,7 @@ void RenderViewContextMenu::AppendOpenInBookmarkAppLinkItems() {
 }
 
 void RenderViewContextMenu::AppendImageItems() {
-  if (!params_.has_image_contents &&
-      base::FeatureList::IsEnabled(
-          features::kLoadBrokenImagesFromContextMenu)) {
+  if (!params_.has_image_contents) {
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_LOAD_IMAGE,
                                     IDS_CONTENT_CONTEXT_LOAD_IMAGE);
   }

chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

@@ -1145,8 +1145,6 @@ class LoadImageBrowserTest : public InProcessBrowserTest {
   void SetupAndLoadImagePage(const std::string& page_path,
                              const std::string& image_path) {
     image_path_ = image_path;
-    scoped_feature_list_.InitAndEnableFeature(
-        features::kLoadBrokenImagesFromContextMenu);
 
     embedded_test_server()->RegisterRequestHandler(base::BindRepeating(
         &LoadImageBrowserTest::HandleRequest, base::Unretained(this)));
@@ -1198,7 +1196,6 @@ class LoadImageBrowserTest : public InProcessBrowserTest {
 
   std::string image_path_;
   size_t request_attempts_ = 0u;
-  base::test::ScopedFeatureList scoped_feature_list_;
 };
 
 IN_PROC_BROWSER_TEST_F(LoadImageBrowserTest, LoadImage) {

chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

@@ -502,9 +502,6 @@ TEST_F(RenderViewContextMenuPrefsTest, DataSaverDisabledSaveImageAs) {
 
 // Check that if image is broken "Load image" menu item is present.
 TEST_F(RenderViewContextMenuPrefsTest, LoadBrokenImage) {
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(
-      features::kLoadBrokenImagesFromContextMenu);
   content::ContextMenuParams params = CreateParams(MenuItem::IMAGE);
   params.unfiltered_link_url = params.link_url;
   params.has_image_contents = false;

chrome/common/chrome_features.cc

@@ -604,10 +604,6 @@ const base::Feature kRemoveSupervisedUsersOnStartup{
     "RemoveSupervisedUsersOnStartup", base::FEATURE_DISABLED_BY_DEFAULT};
 #endif
 
-// Enables Load image context menu item for broken images.
-const base::Feature kLoadBrokenImagesFromContextMenu{
-    "LoadBrokenImagesFromContextMenu", base::FEATURE_ENABLED_BY_DEFAULT};
-
 // Controls whether to show Safety Tip warnings on low-reputation sites.
 const base::Feature kSafetyTipUI{"SafetyTip",
                                  base::FEATURE_DISABLED_BY_DEFAULT};

chrome/common/chrome_features.h

@@ -392,9 +392,6 @@ COMPONENT_EXPORT(CHROME_FEATURES)
 extern const base::Feature kRemoveSupervisedUsersOnStartup;
 #endif
 
-COMPONENT_EXPORT(CHROME_FEATURES)
-extern const base::Feature kLoadBrokenImagesFromContextMenu;
-
 COMPONENT_EXPORT(CHROME_FEATURES)
 extern const base::Feature kSafetyTipUI;
 

third_party/blink/public/web/web_local_frame.h

@@ -539,7 +539,7 @@ class WebLocalFrame : public WebFrame {
 
   // Image reload -----------------------------------------------------------
 
-  // If the provided node is an image, reload the image disabling Lo-Fi.
+  // If the provided node is an image that failed to load, reload it.
   virtual void ReloadImage(const WebNode&) = 0;
 
   // Feature usage logging --------------------------------------------------