Including <stddef.h> instead of <cstddef>.
Google C++ Style Guide [1] is neutral on this subject, but asks to be consistent with surrounding code: Note that the C headers such as stddef.h are essentially interchangeable with their C++ counterparts (cstddef). Either style is acceptable, but prefer consistency with existing code. Most of Chromium uses <stddef.h> and this was confirmed in a 2019 discussion on cxx@chromium.org [2], so let's switch checked_ptr.h to use <stddef.h> instead of <cstddef>. [1] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes [2] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/cxx/Bc1XyEL9pp4/Ie4C-_AjCAAJ Bug: 1073933 Change-Id: I8a844e32fd5f1ced327932e8cfd27bc6555a4cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209603Reviewed-by:danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#770781}
Showing
Please register or sign in to comment