Commit 9b00f349 authored by Thomas Tangl's avatar Thomas Tangl Committed by Commit Bot

Fix radio button bug on sync_page.html

The second radio button in the passphrase section
was not visibly checked on selection.

To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.

Additional change:
 - Remove aria-label attribute because the visible text
   is used automatically as radio button title.

Bug: 894385
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599157}
parent 7b6016fb
...@@ -455,25 +455,16 @@ ...@@ -455,25 +455,16 @@
aria-label="$i18n{encryptWithGoogleCredentialsLabel}"> aria-label="$i18n{encryptWithGoogleCredentialsLabel}">
$i18n{encryptWithGoogleCredentialsLabel} $i18n{encryptWithGoogleCredentialsLabel}
</cr-radio-button> </cr-radio-button>
<template is="dom-if" if="[[syncPrefs.fullEncryptionBody]]"> <cr-radio-button name="encrypt-with-passphrase"
<cr-radio-button name="encrypt-with-passphrase" class="list-item" disabled="[[syncPrefs.encryptAllData]]">
class="list-item" disabled="[[syncPrefs.encryptAllData]]" <span hidden="[[!syncPrefs.fullEncryptionBody]]">
aria-labelledby="fullEncryptionBody"> [[syncPrefs.fullEncryptionBody]]
<span id="fullEncryptionBody"> </span>
[[syncPrefs.fullEncryptionBody]] <span on-click="onLearnMoreTap_"
</span> hidden="[[syncPrefs.fullEncryptionBody]]">
</cr-radio-button> $i18nRaw{encryptWithSyncPassphraseLabel}
</template> </span>
<template is="dom-if" if="[[!syncPrefs.fullEncryptionBody]]"> </cr-radio-button>
<cr-radio-button name="encrypt-with-passphrase"
class="list-item" disabled="[[syncPrefs.encryptAllData]]"
aria-labelledby="encryptWithSyncPassphraseLabel">
<span id="encryptWithSyncPassphraseLabel"
on-click="onLearnMoreTap_">
$i18nRaw{encryptWithSyncPassphraseLabel}
</span>
</cr-radio-button>
</template>
</paper-radio-group> </paper-radio-group>
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment