Commit 9b090d42 authored by Ehimare Okoyomon's avatar Ehimare Okoyomon Committed by Commit Bot

Expose kImprovedCookieControls feature flag to java

Exposed this feature flag that makes it easier for users to enable and
manage third party cookie blocking in android.

Bug: 1040091
Change-Id: Icc58f7afb6c4c60c78d7963b44d2cbf7e93ba189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002618
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732781}
parent c6b4e014
...@@ -258,6 +258,7 @@ public abstract class ChromeFeatureList { ...@@ -258,6 +258,7 @@ public abstract class ChromeFeatureList {
public static final String HOMEPAGE_SETTINGS_UI_CONVERSION = "HomepageSettingsUIConversion"; public static final String HOMEPAGE_SETTINGS_UI_CONVERSION = "HomepageSettingsUIConversion";
public static final String HORIZONTAL_TAB_SWITCHER_ANDROID = "HorizontalTabSwitcherAndroid"; public static final String HORIZONTAL_TAB_SWITCHER_ANDROID = "HorizontalTabSwitcherAndroid";
public static final String IMMERSIVE_UI_MODE = "ImmersiveUiMode"; public static final String IMMERSIVE_UI_MODE = "ImmersiveUiMode";
public static final String IMPROVED_COOKIE_CONTROLS = "ImprovedCookieControls";
public static final String IMPROVED_COOKIE_CONTROLS_FOR_THIRD_PARTY_COOKIE_BLOCKING = public static final String IMPROVED_COOKIE_CONTROLS_FOR_THIRD_PARTY_COOKIE_BLOCKING =
"ImprovedCookieControlsForThirdPartyCookieBlocking"; "ImprovedCookieControlsForThirdPartyCookieBlocking";
public static final String INLINE_UPDATE_FLOW = "InlineUpdateFlow"; public static final String INLINE_UPDATE_FLOW = "InlineUpdateFlow";
......
...@@ -4643,11 +4643,9 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -4643,11 +4643,9 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_VALUE_TYPE( FEATURE_VALUE_TYPE(
password_manager::features::kEnablePasswordsAccountStorageSavingUi)}, password_manager::features::kEnablePasswordsAccountStorageSavingUi)},
#if !defined(OS_ANDROID)
{"improved-cookie-controls", flag_descriptions::kImprovedCookieControlsName, {"improved-cookie-controls", flag_descriptions::kImprovedCookieControlsName,
flag_descriptions::kImprovedCookieControlsDescription, kOsDesktop, flag_descriptions::kImprovedCookieControlsDescription, kOsAll,
FEATURE_VALUE_TYPE(content_settings::kImprovedCookieControls)}, FEATURE_VALUE_TYPE(content_settings::kImprovedCookieControls)},
#endif // !defined(OS_ANDROID)
{"improved-cookie-controls-for-third-party-cookie-blocking", {"improved-cookie-controls-for-third-party-cookie-blocking",
flag_descriptions::kImprovedCookieControlsForThirdPartyCookieBlockingName, flag_descriptions::kImprovedCookieControlsForThirdPartyCookieBlockingName,
......
...@@ -69,6 +69,7 @@ const base::Feature* kFeaturesExposedToJava[] = { ...@@ -69,6 +69,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
&autofill_assistant::features::kAutofillAssistantChromeEntry, &autofill_assistant::features::kAutofillAssistantChromeEntry,
&autofill_assistant::features::kAutofillAssistantDirectActions, &autofill_assistant::features::kAutofillAssistantDirectActions,
&autofill::features::kAutofillTouchToFill, &autofill::features::kAutofillTouchToFill,
&content_settings::kImprovedCookieControls,
&content_settings::kImprovedCookieControlsForThirdPartyCookieBlocking, &content_settings::kImprovedCookieControlsForThirdPartyCookieBlocking,
&download::features::kDownloadAutoResumptionNative, &download::features::kDownloadAutoResumptionNative,
&download::features::kUseDownloadOfflineContentProvider, &download::features::kUseDownloadOfflineContentProvider,
......
...@@ -1236,6 +1236,11 @@ const char kIgnoreLitePageRedirectHintsBlacklistDescription[] = ...@@ -1236,6 +1236,11 @@ const char kIgnoreLitePageRedirectHintsBlacklistDescription[] =
"Ignore blacklist decisions made by Optimization Hints for Lite Page " "Ignore blacklist decisions made by Optimization Hints for Lite Page "
"Redirect previews"; "Redirect previews";
const char kImprovedCookieControlsName[] =
"Enable improved cookie controls UI in incognito mode";
const char kImprovedCookieControlsDescription[] =
"Improved UI in Incognito mode for third-party cookie blocking.";
const char kImprovedCookieControlsForThirdPartyCookieBlockingName[] = const char kImprovedCookieControlsForThirdPartyCookieBlockingName[] =
"Enable improved UI for third-party cookie blocking"; "Enable improved UI for third-party cookie blocking";
const char kImprovedCookieControlsForThirdPartyCookieBlockingDescription[] = const char kImprovedCookieControlsForThirdPartyCookieBlockingDescription[] =
...@@ -2944,11 +2949,6 @@ const char kNtpWebUIName[] = ...@@ -2944,11 +2949,6 @@ const char kNtpWebUIName[] =
const char kNtpWebUIDescription[] = const char kNtpWebUIDescription[] =
"The WebUI new tab page is a replacement for the local NTP."; "The WebUI new tab page is a replacement for the local NTP.";
const char kImprovedCookieControlsName[] =
"Enable improved cookie controls UI in incognito mode";
const char kImprovedCookieControlsDescription[] =
"Improved UI in Incognito mode for third-party cookie blocking.";
const char kEnableReaderModeName[] = "Enable Reader Mode"; const char kEnableReaderModeName[] = "Enable Reader Mode";
const char kEnableReaderModeDescription[] = const char kEnableReaderModeDescription[] =
"Allows viewing of simplified web pages by selecting 'Customize and " "Allows viewing of simplified web pages by selecting 'Customize and "
......
...@@ -745,6 +745,9 @@ extern const char kIgnorePreviewsBlacklistDescription[]; ...@@ -745,6 +745,9 @@ extern const char kIgnorePreviewsBlacklistDescription[];
extern const char kIgnoreLitePageRedirectHintsBlacklistName[]; extern const char kIgnoreLitePageRedirectHintsBlacklistName[];
extern const char kIgnoreLitePageRedirectHintsBlacklistDescription[]; extern const char kIgnoreLitePageRedirectHintsBlacklistDescription[];
extern const char kImprovedCookieControlsName[];
extern const char kImprovedCookieControlsDescription[];
extern const char kImprovedCookieControlsForThirdPartyCookieBlockingName[]; extern const char kImprovedCookieControlsForThirdPartyCookieBlockingName[];
extern const char extern const char
kImprovedCookieControlsForThirdPartyCookieBlockingDescription[]; kImprovedCookieControlsForThirdPartyCookieBlockingDescription[];
...@@ -1733,9 +1736,6 @@ extern const char kNtpRealboxMatchOmniboxThemeDescription[]; ...@@ -1733,9 +1736,6 @@ extern const char kNtpRealboxMatchOmniboxThemeDescription[];
extern const char kNtpWebUIName[]; extern const char kNtpWebUIName[];
extern const char kNtpWebUIDescription[]; extern const char kNtpWebUIDescription[];
extern const char kImprovedCookieControlsName[];
extern const char kImprovedCookieControlsDescription[];
extern const char kEnableReaderModeName[]; extern const char kEnableReaderModeName[];
extern const char kEnableReaderModeDescription[]; extern const char kEnableReaderModeDescription[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment