Commit 9b213685 authored by hirono's avatar hirono Committed by Commit bot

Files.app: Take back disabled DefaultActionDialog/FileManagerBrowserTest.

Previously the test does not wait dialog hiding unintentinally.

BUG=452723
TEST=DefaultActionDialog/FileManagerBrowserTest

Review URL: https://codereview.chromium.org/897863002

Cr-Commit-Position: refs/heads/master@{#314531}
parent f90ebdf8
......@@ -1039,11 +1039,13 @@ INSTANTIATE_TEST_CASE_P(
TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDrive")));
// Slow tests are disabled on debug build. http://crbug.com/327719
// In addition, this test in particular has become very flaky as of this CL:
// https://codereview.chromium.org/838193002/
// Disable completely until further investigation. See: http://crbug.com/444574.
#if !defined(NDEBUG)
#define MAYBE_DefaultActionDialog DISABLED_DefaultActionDialog
#else
#define MAYBE_DefaultActionDialog DefaultActionDialog
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
DISABLED_DefaultActionDialog,
MAYBE_DefaultActionDialog,
FileManagerBrowserTest,
::testing::Values(
TestParameter(NOT_IN_GUEST_MODE, "defaultActionDialogOnDownloads"),
......
......@@ -178,8 +178,8 @@ function defaultActionDialog(expectedTaskId, windowId) {
// Wait for the dialog hidden, and the task is executed.
var dialogHiddenPromise = itemClickedPromise.then(function() {
return remoteCall.waitForElement.bind(
remoteCall, windowId, '#default-action-dialog', null);
return remoteCall.waitForElementLost(
windowId, '#default-action-dialog', null);
});
// Execute the new default task.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment