Commit 9b31ed0d authored by rbpotter's avatar rbpotter Committed by Commit Bot

Print Preview Refresh: Remove Preview Area system dialog button

This button should not be shown on Chrome OS, since there is no system
dialog on that platform.

In the existing UI, it does not work on Windows, since Windows uses a
unique print preview -> system dialog path.

It is shown very infrequently on Mac and Linux, and these users
will still have the "Print with system dialog" link on the sidebar
available if this error state does occur.

Bug: 890250
Change-Id: Icfaa4d173c34565b00fd754df3b9f204419c895a
Reviewed-on: https://chromium-review.googlesource.com/1252624Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595289}
parent eb453f1b
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
<link rel="import" href="chrome://resources/html/i18n_behavior.html"> <link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/html/util.html"> <link rel="import" href="chrome://resources/html/util.html">
<link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="../native_layer.html"> <link rel="import" href="../native_layer.html">
<link rel="import" href="../print_preview_utils.html"> <link rel="import" href="../print_preview_utils.html">
<link rel="import" href="../data/coordinate2d.html"> <link rel="import" href="../data/coordinate2d.html">
...@@ -27,7 +26,7 @@ ...@@ -27,7 +26,7 @@
<dom-module id="print-preview-preview-area"> <dom-module id="print-preview-preview-area">
<template> <template>
<style include="print-preview-shared action-link cr-hidden-style paper-button-style"> <style include="print-preview-shared action-link cr-hidden-style">
@keyframes dancing-dots-jump { @keyframes dancing-dots-jump {
0% { top: 0; } 0% { top: 0; }
55% { top: 0; } 55% { top: 0; }
...@@ -109,18 +108,6 @@ ...@@ -109,18 +108,6 @@
position: relative; position: relative;
text-align: center; text-align: center;
} }
.preview-area-action-area {
margin-top: 12px;
}
.preview-area-open-system-dialog-button-throbber {
vertical-align: middle;
}
.preview-area-open-system-dialog-button {
background-color: white;
}
</style> </style>
<div class$="preview-area-overlay-layer [[getInvisible_(previewState)]]" <div class$="preview-area-overlay-layer [[getInvisible_(previewState)]]"
aria-hidden$="[[getAriaHidden_(previewState)]]"> aria-hidden$="[[getAriaHidden_(previewState)]]">
...@@ -138,15 +125,6 @@ ...@@ -138,15 +125,6 @@
$i18n{learnMore} $i18n{learnMore}
</a> </a>
</div> </div>
<div class="preview-area-action-area"
hidden$="[[!displaySystemDialogButton_(previewState)]]">
<paper-button class="preview-area-open-system-dialog-button">
$i18n{launchNativeDialog}
</paper-button>
<div
class="preview-area-open-system-dialog-button-throbber throbber"
hidden></div>
</div>
</div> </div>
</div> </div>
<div class="preview-area-plugin-wrapper"> <div class="preview-area-plugin-wrapper">
......
...@@ -243,19 +243,6 @@ Polymer({ ...@@ -243,19 +243,6 @@ Polymer({
return this.isPreviewLoading_() ? 'jumping-dots' : ''; return this.isPreviewLoading_() ? 'jumping-dots' : '';
}, },
/**
* @return {boolean} Whether the system dialog button should be shown.
* @private
*/
displaySystemDialogButton_: function() {
return this.previewState ==
print_preview_new.PreviewAreaState.INVALID_SETTINGS ||
this.previewState ==
print_preview_new.PreviewAreaState.OPEN_IN_PREVIEW_LOADING ||
this.previewState ==
print_preview_new.PreviewAreaState.OPEN_IN_PREVIEW_LOADED;
},
/** /**
* @return {boolean} Whether the "learn more" link to the cloud print help * @return {boolean} Whether the "learn more" link to the cloud print help
* page should be shown. * page should be shown.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment