Commit 9b3957eb authored by Patrik Höglund's avatar Patrik Höglund Committed by Commit Bot

Make WebRTC Chromium Win builders disable com init check hooks.

The WebRTC chromium bots need sound cards, and the drivers for those
sound cards inject themselves into the COM stack, which triggers a
CHECK chromium does to detect precisely this. Therefore, disable
this check on these particular builders.

We will aim to get rid of the sound cards and simplify the tests
in Q1, so hopefully this is just temporary.

Depends on crrev.com/c/753591.

Bug: 737090
Change-Id: I6cc5603e345b0d8b8866b97abfd3db8d4e94e7eb
Reviewed-on: https://chromium-review.googlesource.com/753728Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519732}
parent 5bd5874c
......@@ -468,7 +468,7 @@
'chromium.webrtc': {
'Linux Builder': 'release_bot_chrome_with_codecs',
'Mac Builder': 'release_bot_chrome_with_codecs',
'Win Builder': 'release_bot_x86_minimal_symbols',
'Win Builder': 'release_bot_x86_minimal_symbols_no_com_init_hooks',
},
'chromium.webrtc.fyi': {
......@@ -479,8 +479,8 @@
'Linux Builder (dbg)': 'debug_bot',
'Mac Builder': 'release_bot_chrome_with_codecs',
'Mac Builder (dbg)': 'debug_bot',
'Win Builder': 'release_bot_x86_minimal_symbols',
'Win Builder (dbg)': 'debug_bot_x86_minimal_symbols',
'Win Builder': 'release_bot_x86_minimal_symbols_no_com_init_hooks',
'Win Builder (dbg)': 'debug_bot_x86_minimal_symbols_no_com_init_hooks',
},
'chromium.win': {
......@@ -1315,6 +1315,10 @@
'debug_bot_minimal_symbols': [ 'debug_bot', 'minimal_symbols' ],
'debug_bot_x86_minimal_symbols': [ 'debug_bot', 'x86', 'minimal_symbols' ],
'debug_bot_x86_minimal_symbols_no_com_init_hooks': [
'debug_bot', 'x86', 'minimal_symbols', 'no_com_init_hooks'
],
'debug_libfuzzer_asan': [
'debug', 'libfuzzer', 'asan', 'chromeos_codecs', 'pdf_xfa', 'disable_nacl',
],
......@@ -1587,6 +1591,10 @@
'release_bot_minimal_symbols': [ 'release_bot', 'minimal_symbols' ],
'release_bot_x86_minimal_symbols': [ 'release_bot', 'x86', 'minimal_symbols' ],
'release_bot_x86_minimal_symbols_no_com_init_hooks': [
'release_bot', 'x86', 'minimal_symbols', 'no_com_init_hooks'
],
# TODO(tikuta): Remove this once gcp goma backend supports all windows nacl compilers.
'release_bot_x86_minimal_symbols_disable_nacl_no_clang': [
'release_bot_x86_minimal_symbols_disable_nacl', 'no_clang'
......@@ -2017,6 +2025,10 @@
'gn_args': 'android_ndk_version="r13b" android_ndk_major_version=13',
},
'no_com_init_hooks': {
'gn_args': 'com_init_check_hook_disabled=true',
},
'no_gnome_keyring': {
'gn_args': 'use_gnome_keyring=false',
},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment