Commit 9b60536b authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Remove unnecessary #includes from animatable.h

This CL reduces estimated pre-processed size of animatable.h
from 3.52MB to 1.97MB.

This CL avoids unnecessary copy of a
UnrestrictedDoubleOrKeyframeAnimationOptions object on animate().

Bug: 242216
Change-Id: I066c1b6e92a0fbbdd1ee141403d134a97258978b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774001
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691056}
parent 47499a0c
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "third_party/blink/renderer/core/animation/animatable.h" #include "third_party/blink/renderer/core/animation/animatable.h"
#include "third_party/blink/renderer/bindings/core/v8/unrestricted_double_or_keyframe_animation_options.h"
#include "third_party/blink/renderer/core/animation/animation.h" #include "third_party/blink/renderer/core/animation/animation.h"
#include "third_party/blink/renderer/core/animation/document_timeline.h" #include "third_party/blink/renderer/core/animation/document_timeline.h"
#include "third_party/blink/renderer/core/animation/effect_input.h" #include "third_party/blink/renderer/core/animation/effect_input.h"
...@@ -44,7 +45,7 @@ void ReportFeaturePolicyViolationsIfNecessary( ...@@ -44,7 +45,7 @@ void ReportFeaturePolicyViolationsIfNecessary(
Animation* Animatable::animate( Animation* Animatable::animate(
ScriptState* script_state, ScriptState* script_state,
const ScriptValue& keyframes, const ScriptValue& keyframes,
UnrestrictedDoubleOrKeyframeAnimationOptions options, const UnrestrictedDoubleOrKeyframeAnimationOptions& options,
ExceptionState& exception_state) { ExceptionState& exception_state) {
EffectModel::CompositeOperation composite = EffectModel::kCompositeReplace; EffectModel::CompositeOperation composite = EffectModel::kCompositeReplace;
if (options.IsKeyframeAnimationOptions()) { if (options.IsKeyframeAnimationOptions()) {
......
...@@ -31,11 +31,9 @@ ...@@ -31,11 +31,9 @@
#ifndef THIRD_PARTY_BLINK_RENDERER_CORE_ANIMATION_ANIMATABLE_H_ #ifndef THIRD_PARTY_BLINK_RENDERER_CORE_ANIMATION_ANIMATABLE_H_
#define THIRD_PARTY_BLINK_RENDERER_CORE_ANIMATION_ANIMATABLE_H_ #define THIRD_PARTY_BLINK_RENDERER_CORE_ANIMATION_ANIMATABLE_H_
#include "third_party/blink/renderer/bindings/core/v8/unrestricted_double_or_keyframe_animation_options.h"
#include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/core/core_export.h"
#include "third_party/blink/renderer/platform/heap/heap_allocator.h" #include "third_party/blink/renderer/platform/heap/heap_allocator.h"
#include "third_party/blink/renderer/platform/heap/member.h" #include "third_party/blink/renderer/platform/heap/member.h"
#include "third_party/blink/renderer/platform/wtf/allocator/allocator.h"
namespace blink { namespace blink {
...@@ -44,6 +42,8 @@ class ExceptionState; ...@@ -44,6 +42,8 @@ class ExceptionState;
class Element; class Element;
class KeyframeEffectModelBase; class KeyframeEffectModelBase;
class ScriptState; class ScriptState;
class ScriptValue;
class UnrestrictedDoubleOrKeyframeAnimationOptions;
struct Timing; struct Timing;
// https://drafts.csswg.org/web-animations-1/#the-animatable-interface-mixin // https://drafts.csswg.org/web-animations-1/#the-animatable-interface-mixin
...@@ -55,7 +55,7 @@ class CORE_EXPORT Animatable { ...@@ -55,7 +55,7 @@ class CORE_EXPORT Animatable {
Animation* animate(ScriptState*, Animation* animate(ScriptState*,
const ScriptValue&, const ScriptValue&,
UnrestrictedDoubleOrKeyframeAnimationOptions, const UnrestrictedDoubleOrKeyframeAnimationOptions&,
ExceptionState&); ExceptionState&);
Animation* animate(ScriptState*, const ScriptValue&, ExceptionState&); Animation* animate(ScriptState*, const ScriptValue&, ExceptionState&);
......
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include "third_party/blink/public/platform/platform.h" #include "third_party/blink/public/platform/platform.h"
#include "third_party/blink/public/platform/web_media_stream.h" #include "third_party/blink/public/platform/web_media_stream.h"
#include "third_party/blink/public/platform/web_media_stream_track.h" #include "third_party/blink/public/platform/web_media_stream_track.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h"
#include "third_party/blink/renderer/core/frame/local_frame.h" #include "third_party/blink/renderer/core/frame/local_frame.h"
#include "third_party/blink/renderer/core/html/canvas/html_canvas_element.h" #include "third_party/blink/renderer/core/html/canvas/html_canvas_element.h"
#include "third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.h" #include "third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment