Commit 9b89d86e authored by Xi Cheng's avatar Xi Cheng Committed by Commit Bot

Disable Windows 10 native notification for OS builds old than 17134

Windows 10 native notification seems to have memory leak issues on OS
builds older than 17134. See crbug.com/882622. This seems to be a Windows
issue which has been fixed in 17134.

Bug: 882622
Change-Id: Icb251eb9ebb88b19b20b8e09692d85f7fcec6b54
Reviewed-on: https://chromium-review.googlesource.com/1220569Reviewed-by: default avatarJustin DeWitt <dewittj@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590531}
parent acfd829c
......@@ -875,7 +875,10 @@ std::string NotificationPlatformBridgeWin::GetProfileIdFromLaunchId(
// static
bool NotificationPlatformBridgeWin::NativeNotificationEnabled() {
return base::win::GetVersion() >= base::win::VERSION_WIN10_RS1 &&
// Windows 10 native notification seems to have memory leak issues on OS
// builds older than 17134 (i.e., VERSION_WIN10_RS4). This seems to be a
// Windows issue which has been fixed in 17134.
return base::win::GetVersion() >= base::win::VERSION_WIN10_RS4 &&
base::FeatureList::IsEnabled(features::kNativeNotifications);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment