[NTP] Convert NTP service DLOGs into DVLOGs

Some of the NTP DLOGs trigger quite often, and none of them are
very useful to see on every NTP load. Convert them all to DVLOG(1)
so as not to spam the output, they can still be triggered with --v=1.

Bug: 929875
Change-Id: Ie1fb98a357c23a4ba67c6b105b0d640f372fbb65
Reviewed-on: https://chromium-review.googlesource.com/c/1460107Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630141}

chrome/browser/search/background/ntp_background_service.cc

@@ -150,8 +150,7 @@ void NtpBackgroundService::OnCollectionInfoFetchComplete(
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: "
-                  << loader_deleter->NetError();
+    DVLOG(1) << "Request failed with error: " << loader_deleter->NetError();
     collection_error_info_.error_type = ErrorType::NET_ERROR;
     collection_error_info_.net_error = loader_deleter->NetError();
     NotifyObservers(FetchComplete::COLLECTION_INFO);
@@ -160,9 +159,8 @@ void NtpBackgroundService::OnCollectionInfoFetchComplete(
 
   ntp::background::GetCollectionsResponse collections_response;
   if (!collections_response.ParseFromString(*response_body)) {
-    DLOG(WARNING)
-        << "Deserializing Backdrop wallpaper proto for collection info "
-           "failed.";
+    DVLOG(1) << "Deserializing Backdrop wallpaper proto for collection info "
+                "failed.";
     collection_error_info_.error_type = ErrorType::SERVICE_ERROR;
     NotifyObservers(FetchComplete::COLLECTION_INFO);
     return;
@@ -246,8 +244,7 @@ void NtpBackgroundService::OnCollectionImageInfoFetchComplete(
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: "
-                  << loader_deleter->NetError();
+    DVLOG(1) << "Request failed with error: " << loader_deleter->NetError();
     collection_images_error_info_.error_type = ErrorType::NET_ERROR;
     collection_images_error_info_.net_error = loader_deleter->NetError();
     NotifyObservers(FetchComplete::COLLECTION_IMAGE_INFO);
@@ -256,8 +253,7 @@ void NtpBackgroundService::OnCollectionImageInfoFetchComplete(
 
   ntp::background::GetImagesInCollectionResponse images_response;
   if (!images_response.ParseFromString(*response_body)) {
-    DLOG(WARNING)
-        << "Deserializing Backdrop wallpaper proto for image info failed.";
+    DVLOG(1) << "Deserializing Backdrop wallpaper proto for image info failed.";
     collection_images_error_info_.error_type = ErrorType::SERVICE_ERROR;
     NotifyObservers(FetchComplete::COLLECTION_IMAGE_INFO);
     return;
@@ -295,8 +291,7 @@ void NtpBackgroundService::GetAccessTokenForAlbumCallback(
   token_fetcher_.reset();
 
   if (error != GoogleServiceAuthError::AuthErrorNone()) {
-    DLOG(WARNING) << "Failed to retrieve token with error: "
-                  << error.ToString();
+    DVLOG(1) << "Failed to retrieve token with error: " << error.ToString();
     if (error.state() ==
         GoogleServiceAuthError::State::INVALID_GAIA_CREDENTIALS) {
       album_error_info_.error_type = ErrorType::AUTH_ERROR;
@@ -363,8 +358,7 @@ void NtpBackgroundService::OnAlbumInfoFetchComplete(
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: "
-                  << loader_deleter->NetError();
+    DVLOG(1) << "Request failed with error: " << loader_deleter->NetError();
     album_error_info_.error_type = ErrorType::NET_ERROR;
     album_error_info_.net_error = loader_deleter->NetError();
     NotifyObservers(FetchComplete::ALBUM_INFO);
@@ -374,7 +368,7 @@ void NtpBackgroundService::OnAlbumInfoFetchComplete(
   ntp::background::PersonalAlbumsResponse albums_response;
   if (!albums_response.ParseFromString(*response_body) ||
       albums_response.error_on_server()) {
-    DLOG(WARNING) << "Deserializing personal albums response proto failed.";
+    DVLOG(1) << "Deserializing personal albums response proto failed.";
     album_error_info_.error_type = ErrorType::SERVICE_ERROR;
     NotifyObservers(FetchComplete::ALBUM_INFO);
     return;
@@ -416,8 +410,7 @@ void NtpBackgroundService::GetAccessTokenForPhotosCallback(
   token_fetcher_.reset();
 
   if (error != GoogleServiceAuthError::AuthErrorNone()) {
-    DLOG(WARNING) << "Failed to retrieve token with error: "
-                  << error.ToString();
+    DVLOG(1) << "Failed to retrieve token with error: " << error.ToString();
     album_photos_error_info_.error_type = ErrorType::AUTH_ERROR;
     NotifyObservers(FetchComplete::ALBUM_PHOTOS);
     return;
@@ -479,8 +472,7 @@ void NtpBackgroundService::OnAlbumPhotosFetchComplete(
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: "
-                  << loader_deleter->NetError();
+    DVLOG(1) << "Request failed with error: " << loader_deleter->NetError();
     album_photos_error_info_.error_type = ErrorType::NET_ERROR;
     album_photos_error_info_.net_error = loader_deleter->NetError();
     NotifyObservers(FetchComplete::ALBUM_PHOTOS);
@@ -490,7 +482,7 @@ void NtpBackgroundService::OnAlbumPhotosFetchComplete(
   ntp::background::SettingPreviewResponse photos_response;
   if (!photos_response.ParseFromString(*response_body) ||
       photos_response.status() == ntp::background::ErrorCode::SERVER_ERROR) {
-    DLOG(WARNING) << "Deserializing personal photos response proto failed.";
+    DVLOG(1) << "Deserializing personal photos response proto failed.";
     album_photos_error_info_.error_type = ErrorType::SERVICE_ERROR;
     NotifyObservers(FetchComplete::ALBUM_PHOTOS);
     return;

chrome/browser/search/one_google_bar/one_google_bar_loader_impl.cc

@@ -89,32 +89,32 @@ bool GetStyleSheet(const base::DictionaryValue& dict,
 base::Optional<OneGoogleBarData> JsonToOGBData(const base::Value& value) {
   const base::DictionaryValue* dict = nullptr;
   if (!value.GetAsDictionary(&dict)) {
-    DLOG(WARNING) << "Parse error: top-level dictionary not found";
+    DVLOG(1) << "Parse error: top-level dictionary not found";
     return base::nullopt;
   }
 
   const base::DictionaryValue* update = nullptr;
   if (!dict->GetDictionary("update", &update)) {
-    DLOG(WARNING) << "Parse error: no update";
+    DVLOG(1) << "Parse error: no update";
     return base::nullopt;
   }
 
   const base::DictionaryValue* one_google_bar = nullptr;
   if (!update->GetDictionary("ogb", &one_google_bar)) {
-    DLOG(WARNING) << "Parse error: no ogb";
+    DVLOG(1) << "Parse error: no ogb";
     return base::nullopt;
   }
 
   OneGoogleBarData result;
 
   if (!safe_html::GetHtml(*one_google_bar, "html", &result.bar_html)) {
-    DLOG(WARNING) << "Parse error: no html";
+    DVLOG(1) << "Parse error: no html";
     return base::nullopt;
   }
 
   const base::DictionaryValue* page_hooks = nullptr;
   if (!one_google_bar->GetDictionary("page_hooks", &page_hooks)) {
-    DLOG(WARNING) << "Parse error: no page_hooks";
+    DVLOG(1) << "Parse error: no page_hooks";
     return base::nullopt;
   }
 
@@ -312,7 +312,7 @@ void OneGoogleBarLoaderImpl::LoadDone(
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: " << simple_loader->NetError();
+    DVLOG(1) << "Request failed with error: " << simple_loader->NetError();
     Respond(Status::TRANSIENT_ERROR, base::nullopt);
     return;
   }
@@ -341,7 +341,7 @@ void OneGoogleBarLoaderImpl::JsonParsed(std::unique_ptr<base::Value> value) {
 }
 
 void OneGoogleBarLoaderImpl::JsonParseFailed(const std::string& message) {
-  DLOG(WARNING) << "Parsing JSON failed: " << message;
+  DVLOG(1) << "Parsing JSON failed: " << message;
   Respond(Status::FATAL_ERROR, base::nullopt);
 }
 

chrome/browser/search/promos/promo_service.cc

@@ -32,25 +32,25 @@ base::Optional<PromoData> JsonToPromoData(const base::Value& value,
                                           const GURL& base_url) {
   const base::DictionaryValue* dict = nullptr;
   if (!value.GetAsDictionary(&dict)) {
-    DLOG(WARNING) << "Parse error: top-level dictionary not found";
+    DVLOG(1) << "Parse error: top-level dictionary not found";
     return base::nullopt;
   }
 
   const base::DictionaryValue* update = nullptr;
   if (!dict->GetDictionary("update", &update)) {
-    DLOG(WARNING) << "Parse error: no update";
+    DVLOG(1) << "Parse error: no update";
     return base::nullopt;
   }
 
   const base::DictionaryValue* promos = nullptr;
   if (!update->GetDictionary("promos", &promos)) {
-    DLOG(WARNING) << "Parse error: no promos";
+    DVLOG(1) << "Parse error: no promos";
     return base::nullopt;
   }
 
   std::string middle = std::string();
   if (!promos->GetString("middle", &middle)) {
-    DLOG(WARNING) << "No middle promo";
+    DVLOG(1) << "No middle promo";
     return base::nullopt;
   }
 
@@ -59,7 +59,7 @@ base::Optional<PromoData> JsonToPromoData(const base::Value& value,
 
   std::string log_url = std::string();
   if (!promos->GetString("log_url", &log_url)) {
-    DLOG(WARNING) << "No promo log_url";
+    DVLOG(1) << "No promo log_url";
     return base::nullopt;
   }
 
@@ -136,8 +136,7 @@ void PromoService::OnLoadDone(std::unique_ptr<std::string> response_body) {
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: "
-                  << simple_loader_->NetError();
+    DVLOG(1) << "Request failed with error: " << simple_loader_->NetError();
     PromoDataLoaded(Status::TRANSIENT_ERROR, base::nullopt);
     return;
   }
@@ -168,7 +167,7 @@ void PromoService::OnJsonParsed(std::unique_ptr<base::Value> value) {
 }
 
 void PromoService::OnJsonParseFailed(const std::string& message) {
-  DLOG(WARNING) << "Parsing JSON failed: " << message;
+  DVLOG(1) << "Parsing JSON failed: " << message;
   PromoDataLoaded(Status::FATAL_ERROR, base::nullopt);
 }
 

chrome/browser/search/search_suggest/search_suggest_loader_impl.cc

@@ -41,19 +41,19 @@ base::Optional<SearchSuggestData> JsonToSearchSuggestionData(
     const base::Value& value) {
   const base::DictionaryValue* dict = nullptr;
   if (!value.GetAsDictionary(&dict)) {
-    DLOG(WARNING) << "Parse error: top-level dictionary not found";
+    DVLOG(1) << "Parse error: top-level dictionary not found";
     return base::nullopt;
   }
 
   const base::DictionaryValue* update = nullptr;
   if (!dict->GetDictionary("update", &update)) {
-    DLOG(WARNING) << "Parse error: no update";
+    DVLOG(1) << "Parse error: no update";
     return base::nullopt;
   }
 
   const base::DictionaryValue* query_suggestions = nullptr;
   if (!update->GetDictionary("query_suggestions", &query_suggestions)) {
-    DLOG(WARNING) << "Parse error: no query_suggestions";
+    DVLOG(1) << "Parse error: no query_suggestions";
     return base::nullopt;
   }
 
@@ -61,7 +61,7 @@ base::Optional<SearchSuggestData> JsonToSearchSuggestionData(
   std::string suggestions_html = std::string();
   if (!query_suggestions->GetString("query_suggestions_with_html",
                                     &suggestions_html)) {
-    DLOG(WARNING) << "Parse error: no query_suggestions_with_html";
+    DVLOG(1) << "Parse error: no query_suggestions_with_html";
     return base::nullopt;
   }
 
@@ -70,7 +70,7 @@ base::Optional<SearchSuggestData> JsonToSearchSuggestionData(
 
   std::string end_of_body_script = std::string();
   if (!query_suggestions->GetString("script", &end_of_body_script)) {
-    DLOG(WARNING) << "Parse error: no script";
+    DVLOG(1) << "Parse error: no script";
     return base::nullopt;
   }
 
@@ -79,7 +79,7 @@ base::Optional<SearchSuggestData> JsonToSearchSuggestionData(
   int impression_cap_expire_time_ms;
   if (!query_suggestions->GetInteger("impression_cap_expire_time_ms",
                                      &impression_cap_expire_time_ms)) {
-    DLOG(WARNING) << "Parse error: no impression_cap_expire_time_ms";
+    DVLOG(1) << "Parse error: no impression_cap_expire_time_ms";
     return base::nullopt;
   }
 
@@ -88,7 +88,7 @@ base::Optional<SearchSuggestData> JsonToSearchSuggestionData(
   int request_freeze_time_ms;
   if (!query_suggestions->GetInteger("request_freeze_time_ms",
                                      &request_freeze_time_ms)) {
-    DLOG(WARNING) << "Parse error: no request_freeze_time_ms";
+    DVLOG(1) << "Parse error: no request_freeze_time_ms";
     return base::nullopt;
   }
 
@@ -96,7 +96,7 @@ base::Optional<SearchSuggestData> JsonToSearchSuggestionData(
 
   int max_impressions;
   if (!query_suggestions->GetInteger("max_impressions", &max_impressions)) {
-    DLOG(WARNING) << "Parse error: no max_impressions";
+    DVLOG(1) << "Parse error: no max_impressions";
     return base::nullopt;
   }
 
@@ -244,7 +244,7 @@ void SearchSuggestLoaderImpl::LoadDone(
   if (!response_body) {
     // This represents network errors (i.e. the server did not provide a
     // response).
-    DLOG(WARNING) << "Request failed with error: " << simple_loader->NetError();
+    DVLOG(1) << "Request failed with error: " << simple_loader->NetError();
     Respond(Status::TRANSIENT_ERROR, base::nullopt);
     return;
   }
@@ -273,7 +273,7 @@ void SearchSuggestLoaderImpl::JsonParsed(std::unique_ptr<base::Value> value) {
 }
 
 void SearchSuggestLoaderImpl::JsonParseFailed(const std::string& message) {
-  DLOG(WARNING) << "Parsing JSON failed: " << message;
+  DVLOG(1) << "Parsing JSON failed: " << message;
   Respond(Status::FATAL_ERROR, base::nullopt);
 }