Commit 9bc9bc0d authored by Roger McFarlane's avatar Roger McFarlane Committed by Commit Bot

[sheriff] Disable SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames on Mac.

SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames seems to be executing an invalid instruction.

Builders failed on:
- Mac10.12 Tests:
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests

TBR: ekaramad@chromium.org
Bug: 852452
Change-Id: If6592678a299db04184c55d1433a6558fa78816d
Reviewed-on: https://chromium-review.googlesource.com/1099364Reviewed-by: default avatarRoger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566926}
parent 29d02cc3
...@@ -744,13 +744,21 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest, ...@@ -744,13 +744,21 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
send_tab_set_composition_wait_for_bounds_change(view); send_tab_set_composition_wait_for_bounds_change(view);
} }
// Failing on Mac - http://crbug.com/852452
#if defined(OS_MACOSX)
#define MAYBE_TrackTextSelectionForAllFrames \
DISABLED_TrackTextSelectionForAllFrames
#else
#define MAYBE_TrackTextSelectionForAllFrames TrackTextSelectionForAllFrames
#endif
// This test creates a page with multiple child frames and adds an <input> to // This test creates a page with multiple child frames and adds an <input> to
// each frame. Then, sequentially, each <input> is focused by sending a tab key. // each frame. Then, sequentially, each <input> is focused by sending a tab key.
// After focusing each input, a sequence of key presses (character 'E') are sent // After focusing each input, a sequence of key presses (character 'E') are sent
// to the focused widget. The test then verifies that the selection length // to the focused widget. The test then verifies that the selection length
// equals the length of the sequence of 'E's. // equals the length of the sequence of 'E's.
IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest, IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
TrackTextSelectionForAllFrames) { MAYBE_TrackTextSelectionForAllFrames) {
CreateIframePage("a(b,c(a,b),d)"); CreateIframePage("a(b,c(a,b),d)");
std::vector<content::RenderFrameHost*> frames{ std::vector<content::RenderFrameHost*> frames{
GetFrame(IndexVector{}), GetFrame(IndexVector{0}), GetFrame(IndexVector{}), GetFrame(IndexVector{0}),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment