Fix parcelable implementations without CREATOR in code

Fix 'ParcelableCreator' and upgrade it to errorprone error
to prevent future regressions.

Bug: 834801
Change-Id: Ifef1abd12505779a23294cb4ba976685120d9b90
Reviewed-on: https://chromium-review.googlesource.com/1135110Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#575313}

build/android/gyp/javac.py

@@ -26,8 +26,6 @@ import colorama
 ERRORPRONE_WARNINGS_TO_TURN_OFF = [
   # TODO(crbug.com/834807): Follow steps in bug
   'DoubleBraceInitialization',
-  # TODO(crbug.com/834801): Follow steps in bug.
-  'ParcelableCreator',
   # TODO(crbug.com/834790): Follow steps in bug.
   'CatchAndPrintStackTrace',
   # TODO(crbug.com/801210): Follow steps in bug.
@@ -99,6 +97,7 @@ ERRORPRONE_WARNINGS_TO_ERROR = [
   'MissingOverride',
   'NarrowingCompoundAssignment',
   'ParameterName',
+  'ParcelableCreator',
   'ReferenceEquality',
   'StaticGuardedByInstance',
   'StaticQualifiedUsingExpression',

chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java

@@ -148,6 +148,7 @@ public class LauncherActivityTest {
      * this will throw a BadParcelableException.
      */
     @SuppressLint("ParcelCreator")
+    @SuppressWarnings("ParcelableCreator")
     private static class InvalidParcelable implements Parcelable {
         @Override
         public void writeToParcel(Parcel parcel, int params) {

components/sync/android/java/src/org/chromium/components/sync/PassphraseType.java

@@ -23,17 +23,18 @@ public enum PassphraseType implements Parcelable {
     FROZEN_IMPLICIT_PASSPHRASE(2), // Frozen GAIA passphrase.
     CUSTOM_PASSPHRASE(3); // User-provided passphrase.
 
-    public static Parcelable.Creator CREATOR = new Parcelable.Creator<PassphraseType>() {
-        @Override
-        public PassphraseType createFromParcel(Parcel parcel) {
-            return fromInternalValue(parcel.readInt());
-        }
+    public static final Parcelable.Creator<PassphraseType> CREATOR =
+            new Parcelable.Creator<PassphraseType>() {
+                @Override
+                public PassphraseType createFromParcel(Parcel parcel) {
+                    return fromInternalValue(parcel.readInt());
+                }
 
-        @Override
-        public PassphraseType[] newArray(int size) {
-            return new PassphraseType[size];
-        }
-    };
+                @Override
+                public PassphraseType[] newArray(int size) {
+                    return new PassphraseType[size];
+                }
+            };
 
     public static PassphraseType fromInternalValue(int value) {
         for (PassphraseType type : values()) {